442726 - msg body context menu for move and move again menu items should be disabled for news articles

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

For news, the "move" and move again menu items should be disabled. (In the menus they are - xref bug 54123.)

Comment 1

[Magnus Melin [:mkmelin]]

Ok so this got rolled into my patch for bug 473168.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Ok, as Joey brought up in the other bug, the alternative to disabling would be to let the menu item be enabled for news/readonly imap, but have it say "Copy" when the message can't be moved.

Personally I think disabling might be clearer. Using "Copy to xxx again" when you didn't copy the last time feels a bit confusing. Not that I think cross account copying is very common anyway. 

I don't have a strong feeling about it, we could do it either way. This patch does the disabling - matching what we already do for the standalone msg window.
What to people think?

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

I don't have a better idea than disabling.  Disabling makes sense to me as I'd worry people misinterpret the 'copy ... again' to mean they did a copy previously.  Not sure that's much cause for worry, but I'd rather avoid the confusion.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 364672 [details] [diff] [review]
proposed fix

Setting that as ui-r=clarkbw

Comment 5

[Joey Minta]

Comment on attachment 364672 [details] [diff] [review]
proposed fix

I'd appreciate a comment above the if() to explain what we're protecting against.

+          let loadedFolder = GetSelectedMsgFolders()[0];
I'm not wild about GetSelectedMsgFolders now that it just wraps the folder-tree's method. I'd prefer to just call directly: gFolderTreeView.getSelectedFolders()

It's unfortunate that we're proliferating uses of the global |pref|, but I'll fight that battle another day.

r=jminta with the substituted gFolderTreeView call.

Comment 6

[Magnus Melin [:mkmelin]]

Checked in with comment and gFolderTreeView.getSelectedFolders

changeset:   2332:750958a0d6c9
http://hg.mozilla.org/comm-central/rev/750958a0d6c9

->FIXED