473168 - Move Again context menu item doesn't show destination folder

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Ryan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.6pre) Gecko/2009010907 GranParadiso/3.0.6pre
Build Identifier: Shredder/3.0b2pre

When right clicking on an email in the email list pane the Move Again context menu item doesn't show the most recent folder.  It used to say something like "Move to Junk Again".  Tested this with the nightly and a fresh profile.  The problem is referenced in Bug 378658 where they say the problem was due to a plugin.  I don't have that plugin and this seems to be a different issue than the one in  Bug 378658.

Reproducible: Always

Steps to Reproduce:
1. Right click on an email item in the list of emails, in any folder.
2. Move the email to another folder using the "Move To" item
3. Right click on another email.  The name of the last folder you moved to should be in the Move Again context item.

Comment 1

[Franklin Bynum]

Confirmed on on Linux nightly trunk builds.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090112 Shredder/3.0b2pre

This changed sometime just after the new year.

Comment 2

[Magnus Melin [:mkmelin]]

Confirming.

Comment 3

[raoul bhatia]

confirming too on windows vista. as far as i remember, thunderbird 3.0b1 has been 
fine thou. so i can also confirm that this changed somewhere around new year.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20090201 Shredder/3.0b2pre

Comment 4

[Wayne Mery (:wsmwk)]

would be cool for someone to volunteer to narrow the range - if it really happened after 2009-01-01 you probably need only check 3-4 nightlies to narrow it down to a 1-2 day range.

Comment 5

[Wayne Mery (:wsmwk)]

it's interesting that the problem doesn't exist on the "message" menu

Comment 6

[Wayne Mery (:wsmwk)]

Ryan, Raoul, can you try builds between 2009010907 (which doesn't work for ryan) and 20081230 (which does work for me)?  

If you can narrow the range then we can find which patch caused the problem.
Builds are here ftp://ftp.mozilla.org/pub/thunderbird/nightly/2009/01/

Comment 7

[Franklin Bynum]

It broke between the January 4 nightlies (in which it works) and the January 5 ones (where it doesn't).

Comment 8

[Wayne Mery (:wsmwk)]

regression of  Bug 462684 Combine messagePaneContext and threadPaneContext
Frank, thanks for that info.

Comment 9

[Frédéric Buclin]

I use "Move Again" a lot when triaging bugmail, and having no idea what the last directory was is a real pain. This should block beta3 IMO (or even a respin of beta2 would be great, as I have in mind some blockers are still open for beta2).

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

I'm putting this as a blocker since the regression seems to make this feature somewhat useless.  Hopefully there is an easy fix to get this working again.

Comment 11

[Frédéric Buclin]

(In reply to comment #10)
> I'm putting this as a blocker

Wow, putting this as a blocker means removing its target milestone? What's the logic here? :)

Comment 12

[Phil Ringnalda (:philor)]

Probably a mid-air, you know how poorly our bug tracker copes with those ;)

Comment 13

[Frédéric Buclin]

(In reply to comment #12)
> Probably a mid-air, you know how poorly our bug tracker copes with those ;)

/me won't reply to this kind of sarcasms. :-p

Comment 14

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

The main bug is just a one bit fix, but there were also some other enabling issues with that menu which are fixed by this patch. (Esp. for news.)

GetThreadTree is not defined in the standalong msg window.

Comment 15

[raoul bhatia]

please tell me when there is a nightly release that includes this patch so that i can test. thanks for taking care of this issue!

Comment 16

[Joey Minta]

Comment on attachment 364374 [details] [diff] [review]
proposed fix

I'm not sure I like the fix for the news-stuff. In my mind, the polite thing to do would be, if you can't delete messages, offer to copy them to the last destination target, rather than not offering to do anything. Either way, it would probably be best not to roll that into this patch.

+    if (!tree) // standalone msg window
This comment isn't quite right, since the function is a bit more generic. An extension could easily hit that if clause but not be in the standalone window. I'd just drop it.

Comment 17

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

Leaving the news stuff to bug 442726...

Comment 18

[Magnus Melin [:mkmelin]]

changeset:   2100:c112d8bedf8b
http://hg.mozilla.org/comm-central/rev/c112d8bedf8b

->FIXED

Comment 19

[Wayne Mery (:wsmwk)]

v.fixed Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090305 Shredder/3.0b3pre

thanks magnus

Comment 20

[raoul bhatia]

i can confirm that too for Gecko/20090304 Shredder/3.0b3pre on Windows Vista. it has been fixed since a couple of days (makes sence as the fix was commited on feb 28)

thanks!

Comment 22

[raoul bhatia]

unfortunatly, this is not/not always working with: 

> Mozilla/5.0 (X11; U; Linux i686 (x86_64); de-DE; rv:1.9.1.4pre) Gecko/20090830 Shredder/3.0b4pre


i have two imap accounts: my personal and an office@ account.


1. i moved some emails from *private* to *office* "INBOX._partner.xxx (yyy)"
2. i renamed "INBOX._partner.xxx (yyy)" to "INBOX._partner.xxx"
3. browsing to *personal* INBOX, i want to "move again" 2 emails.
4. the context menu shows: "Move to "xxx (yyy) Again"

-> not working

Comment 23

[Magnus Melin [:mkmelin]]

raoul: that would be a different bug (focusing on the rename folder after the first move), please file one if you still see it