454810 - theme the "browser tools" section

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

Attachment: sliced images for browser tools screens

The Browser Tools section of the UI (home to add-ons, prefs, and downloads) should be themed.  Attached are sliced images for the buttons and the frame around the individual sections.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: Adds theme to buttons

This patch adds the code needed to theme the buttons and background of the tools screen. It does *not* theme the actual tool panels. Those are not completely ready to land and should be done individually.

This patch adds a "radio" like behavior to the buttons to indicate which tool panel is active.

Requesting review since it would be very nice to land part of a themed tool panel instead of having no theme at all.

The only issue with this patch is the background gradient. The "glare" strip extends below the corresponding "glare" strip in the browser navtoolbar. Madhava is aware and thinking about a solution.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

landed this unbitrotted patch

http://hg.mozilla.org/mobile-browser/rev/0df6af453de5

I won't mark this bug FIXED yet. During the unbitrotting, another button was adding to the browser tools: shortcuts

Madhava, we need an image added to panel_buttons.png to support it.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Not sure if shortcuts will ship with fennec or as an extension. Marking fixed

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

verified as fixed...great job on the new theme work guys