456940 - Customize Toolbar leads to doubled account list in "Get Mail" buttons drop down

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

Thunderbird build:
Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.9.1b1pre) Gecko/20080924032742 Shredder/3.0b1pre

1. Start Thunderbird and click the "Get Mail" buttons drop down. You'll get a correct drop down with a list of all existing accounts.

2. Customize the 3-pane-windows toolbar (no change necessary - only open the customize dialog and close the dialog with "OK"! - "Cancel" doesn't lead to the bug). Click the "Get Mail" buttons drop down again. You'll get the doubled accounts list in the drop down.

Comment 1

[Magnus Melin [:mkmelin]]

Linux too.

Comment 2

[Ronald Killmer]

A second activation of Customize Toolbar caused an additional duplication and looks like this will iterate each time Customize is activated and OK'd.

Comment 4

[David Ascher (:davida)]

Joey, is this something you think might be due to the de-rdfification?

Either way, do you think you could take it on?

Comment 5

[Joey Minta]

Sure, I think I understand what's going on here. If I'm right, it shouldn't be too difficult.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Do the doubled entries persist across a restart?

Comment 7

[Ronald Killmer]

(In reply to comment #6)
> Do the doubled entries persist across a restart?

No, a restart restores the drop down list to a normal single listing.

Comment 8

[Joey Minta]

Attachment: patch v1

The patch pretty much explains itself. The popup's children stick around, but it loses its initialized state, so it tries to bring them back.

Comment 9

[Phil Ringnalda (:philor)]

Comment on attachment 358264 [details] [diff] [review]
patch v1

Looks good to me.

Comment 10

[Joey Minta]

http://hg.mozilla.org/comm-central/rev/de9df60a34e6

Comment 11

[Ilja Sekler]

I get a similar doubling of the account list - but in 'File' / 'Get New Messages for' - with Lightning installed.

STR:

1. Open the tasks tab (Ctrl+4)
2. Switch back to the mail tab(s)
3. Click on 'File' / 'Get New Messages for'

Is it a stuff for a new bug or would it fit into this one, if reopened?

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090223 Lightning/1.0pre Thunderbird/3.0b3pre

Comment 12

[Alex Ihrig [:Thunderbird_Mail_DE]]

(In reply to comment #11)

Confirming this behaviour.

Comment 13

[Ilja Sekler]

Just for the sake of completeness, more STR:

1. Disable Mail toolbar ('View' / 'Toolbars' / '[ ] Mail Toolbar')
2. Open the calendar tab (Ctrl+3)
3. Switch back to the mail tab
4. Click on 'File' / 'Get New Messages for'
5. Switch back to the calendar tab again
6. back to step 3.

Each loop adds an new duplicate of the account list in 'File' / 'Get New Messages for' as stated in comment #2 for the 'Get Mail' dropdown and the original STR.

Please reopen if appropriate.

Comment 14

[Magnus Melin [:mkmelin]]

Please file a new bug - and also note if there if it happens without lightning too.

Comment 15

[Ilja Sekler]

(In reply to comment #14)
> Please file a new bug

Done: <https://bugzilla.mozilla.org/show_bug.cgi?id=480266>.