Created attachment 352468 [details] [diff] [review] CSAT support for Fastpath, v1 This adds CSAT support to Fastpath Webchat. There are still a few things to implement (see the TODO comments in the source), but they are relatively minor: 1) I need to add a preference to the Fastpath Openfire plugin (not webchat) to specify a salt for CSAT. This will be passed to the Webchat plugin on startup via a presence message. For now, a salt is hardcoded in the patch. 2) The "chomp" routine for dealing with data that makes the URL too long can chomp too much with percent escaped characters and multibyte characters. I need to detect these and remove the right number of characters in these cases, rather than removing liberally. For testing, here's a sample URL generated by this patch: http://support.mozilla.com/tiki-feedback.php?hash=3e5d7afdfeb473231917b2b1bca44f4b9f80b57a&chatId=8qM8RV80Ti&feedback=eeqqqq&helper=zzxc&nickname=test&type=chat
Attachment #352468 - Flags: review?(laura)
Here is a url using multibyte characters in the nickname: http://support.mozilla.com/tiki-feedback.php?hash=5e3da909f541e9e5fca973c65f02b32cbed70124&chatId=8qM8RV80Ti&feedback=This%20is%20a%20question%3F&helper=zzxc&nickname=%E5%87%BA%E5%85%B8%3A%20%E3%83%95%E3%83%AA%E3%83%BC%E7%99%BE%E7%A7%91%E4%BA%8B%E5%85%B8%E3%80%8E%E3%82%A6%E3%82%A3%E3%82%AD%E3%83%9A%E3%83%87%E3%82%A3%E3%82%A2&type=chat
Comment on attachment 352468 [details] [diff] [review] CSAT support for Fastpath, v1 So...Java is rusty :) but this looks ok. I do have one question though. Why do we need to chomp the data before hashing? SHA-1 should return a consistent length hash regardless of the length of the input string. You might like to get an additional review from say, Eric, or somebody with more Java fu, but it's optional.
Attachment #352468 - Flags: review?(laura) → review+
I made comments in the other bug, but this patch changes the link structure slightly. I've already updated the tikiwiki patch, and tested it on my local dev instance. Both links worked fine with it.
Attachment #352468 - Attachment is obsolete: true
Attachment #352830 - Flags: review?(smirkingsisyphus)
Attachment #352830 - Flags: review?(smirkingsisyphus) → review+
Checked into trunk, r20820
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Verified FIXED; see also https://bugzilla.mozilla.org/show_bug.cgi?id=465518#c39 https://bugzilla.mozilla.org/show_bug.cgi?id=465518#c41
Status: RESOLVED → VERIFIED
Component: Chat → Chat
Product: support.mozilla.org → support.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.