470241 - [Firefox] test_bug248970_cache.js leaks

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Serge Gautherie (:sgautherie)]

_tests\xpcshell-simple\test_necko\unit
test_bug248970_cache.js

See bug 456414.

NB: This test leak in Firefox but not in SeaMonkey, but maybe it doesn't run everything there ?

Comment 1

[Serge Gautherie (:sgautherie)]

Confirmed by
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1238194568.1238198358.30316.gz&fulltext=1
OS X 10.5.2 mozilla-central unit test on 2009/03/27 15:56:08
}

Comment 2

[Serge Gautherie (:sgautherie)]

Confirmed by
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1238257035.1238263072.12813.gz&fulltext=1
Linux mozilla-1.9.1 unit test on 2009/03/28 09:17:15
}

Comment 3

[Serge Gautherie (:sgautherie)]

Still leaked:
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1239087413.1239095937.15732.gz&fulltext=1
Linux mozilla-central unit test on 2009/04/06 23:56:53
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1239087413.1239090686.26510.gz&fulltext=1
OS X 10.5.2 mozilla-central unit test on 2009/04/06 23:56:53
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1239087413.1239095430.13224.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/04/06 23:56:53
}

Don't leak anymore:
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1239088258.1239095493.13809.gz&fulltext=1
Linux mozilla-central unit test on 2009/04/07 00:10:58
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1239088257.1239094464.9642.gz&fulltext=1
OS X 10.5.2 mozilla-central unit test on 2009/04/07 00:10:57
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1239088257.1239098546.13066.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/04/07 00:10:57
}

Fix timeframe:
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2009-04-06+23%3A53%3A52&enddate=2009-04-07+00%3A07%3A58
10 JavaScript changesets...

Comment 4

[Serge Gautherie (:sgautherie)]

But regressed between
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1239831803.1239841199.9417.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/04/15 14:43:23
and
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1239835301.1239848095.19076.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/04/15 15:41:41

Regression timeframe:
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2009-04-15+14%3A08%3A21&enddate=2009-04-15+15%3A21%3A41
Probably one of the 11 JavaScript changesets...

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Move a var from local to global [Checkin: See comment 9 & 10]

sayrer, I'm confused by what happened in the two previous comments, could you confirm whether this leak is a JS Engine bug or not?

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)

Ftr, bug 489078 fix gave me the idea to check this...

Comment 7

[Shawn Wilsher :sdwilsh]

Comment on attachment 374081 [details] [diff] [review]
(Av1) Move a var from local to global
[Checkin: See comment 9 & 10]

I guess this is fine.

Comment 8

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1242284937.1242291296.22866.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/05/14 00:08:57

Still leaked.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1242287274.1242294566.27893.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/05/14 00:47:54

Regression leak fixed.

Fix timeframe:
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2009-05-14+00%3A05%3A55&enddate=2009-05-14+00%3A44%3A55
2 tracemonkey changesets, as expected.

***

Firefox 3.5 doesn't leak anymore, though I didn't bother to look for the fix timeframe.

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 374081 [details] [diff] [review]
(Av1) Move a var from local to global
[Checkin: See comment 9 & 10]


http://hg.mozilla.org/mozilla-central/rev/d5574404f3cc
(Av1a) trivial cleanup

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 374081 [details] [diff] [review]
(Av1) Move a var from local to global
[Checkin: See comment 9 & 10]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/24f007882aff