470356 - Cookie dialogs pop with center=screen instead of center=owner

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[mozilla]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5

This may be related to 405239.

With 3.0.5, dialogs about cookie handling pop in the "center" of the Windows "screen" (which is taken as the main monitor) instead of the center of the Firefox window. This is extremely irritating for those of us who run FF on a big second monitor, where it belongs.

Reproducible: Always

Steps to Reproduce:
1. Put Firefox on a second monitor.
2. Visit a site that causes a cookie dialog.

Actual Results:  
Dialog pops in middle of main monitor.

Expected Results:  
Dialog should pop in middle of window containing the visited site.

Comment 1

[Jesse Ruderman]

jst, could this be a regression from bug 405239?

Comment 3

[Ria Klaassen (not reading all bugmail)]

This should really block 3.1 I think.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Restoring the blocking nomination lost by the component move...

Comment 6

[Ben Newman (:bnewman) (:benjamn)]

Attachment: parenting dialog with chrome window instead of tab

With this patch, the cookie dialog is modal for the root chrome window rather than the tab containing the permission-requesting page.  This removes the confusion about which monitor is displaying the dialog, but also avoids unwanted tab switches.

I'm not testing that the root window is actually a chrome window, or that the root window is actually different from the provided parent window, but it seems safe to say the root will always be a chrome window.  If there's any problem getting the root window, |parent| will just be null, so at worst this patch degenerates to the present behavior.

Comment 7

[[e-mail]]

Comment on attachment 358083 [details] [diff] [review]
parenting dialog with chrome window instead of tab

>   // Given the nature of this dialog and the frequency of it popping
>   // up for those few users that have it enabled we do not want this
>   // dialog to be parented at a window. Pass in nsnull as the
>   // parent. See bug 405239 for more details.

r=me, but this comment is no longer correct. can you update it to mention the new parenting and this bug#?

thanks for the patch!

Comment 8

[Ben Newman (:bnewman) (:benjamn)]

Attachment: updated comment

Comment 9

[Ben Newman (:bnewman) (:benjamn)]

Attachment: updated comment without the random trash (sorry)

Comment 10

[Johnny Stenback (:jst)]

Comment on attachment 358108 [details] [diff] [review]
updated comment without the random trash (sorry)

sr=jst. I don't think I can claim that this is a blocker, but I think we should take this change for 1.9.1 nonetheless. Approving.

Comment 11

[Johnny Stenback (:jst)]

Fixed for trunk and 1.9.1.

Comment 13

[Bob Stock]

I have trouble following the bug fixing process in Firefox.  Is this bug - and any related bugs - now fixed in 3.5?  (My understanding is that even though it is marked as fixed, it wasn't fixed in 3.0.11 - it was waiting for a "major" release).

Thanks.

Comment 14

[Jesse Ruderman]

Yep, it's marked as "fixed1.9.1".  Gecko 1.9.1 corresponds to Firefox 3.5.