470474 - gDBView.hdrForFirstSelectedMessage doesn't work for cross folder saved searches in the standalone msg window

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Magnus Melin [:mkmelin]]

As noted in bug 466925 gDBView.hdrForFirstSelectedMessage doesn't work for saved searches, when viewing msgs in the standalone msg window. This makes marking as read/starred/deleted cause errors.

An error occurred updating the cmd_delete command; =[Exception... "Component
returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER)
[nsIMsgDBView.hdrForFirstSelectedMessage]"  nsresult: "0x80004003
(NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
chrome://messenger/content/mailWindowOverlay.js :: SelectedMessagesAreDeleted
:: line 726"  data: no]

Comment 1

[Rain [:rain1] (inactive)]

I can't seem to reproduce this with 20081230 trunk on Windows, IMAP/local saved searches, and the standalone message window (opened using a double click on the message). Is there an STR to follow?

Comment 2

[Rain [:rain1] (inactive)]

Oh, and the cause of this bug (if there is one) looks identical to that of bug 395495 .

Comment 3

[Magnus Melin [:mkmelin]]

I just double click a message to open in standalone message window and this exception shows in the error console:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIMsgDBView.hdrForFirstSelectedMessage]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://messenger/content/mailWindowOverlay.js :: UpdateJunkButton :: line 1647"  data: no]

Comment 4

[Magnus Melin [:mkmelin]]

Putting this on the blocking radar, if we don't have time to fix it we should at least put back some try/catches in js, so the exception doesn't blow things up more than it needs to.

Comment 5

[Kent James (:rkent)]

This is probably caused by null mTreeSelection. I notice that nsMsgDBView has some specific code to look for this and react in a similar case, for example:

  // if we don't have an tree selection we must be in stand alone mode....
  if (!mTreeSelection)
  {
    *key = m_currentlyDisplayedMsgKey;
    return NS_OK;
  }

It should not be that hard to implement something similar in the search view.

It might be willing to take this if I could reproduce, which I can't.

Comment 6

[Magnus Melin [:mkmelin]]

You're right, I can't reproduce this anymore.

->WFM

Comment 7

[Magnus Melin [:mkmelin]]

Actually, I still see this, though you have to back out bug 476418 since that masks it.

rkent: this is cross folder saved searches only - similar to bug 395495.

Comment 8

[David :Bienvenu]

sid, are you interested in taking this on?

Comment 9

[Rain [:rain1] (inactive)]

Yes, I'll take this.

Comment 10

[Rain [:rain1] (inactive)]

Attachment: patch

This basically does what rkent says in comment 5, except it uses the currently displaying view index as we don't have an m_db to use the key with.

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 375712 [details] [diff] [review]
patch

Looks good: r=Standard8. I've pushed this already:

http://hg.mozilla.org/comm-central/rev/110aa71394ef