470636 - audio doesn't stop after navigating away from the page

Status: VERIFIED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Biju]

Audio dont stop after navigating away from the page.

ie, something like Bug 448534 or bug 451457 is happening.
but not reproducible by steps in Bug 449924 

Steps:-
1. goto http://www.double.co.nz/video_test/
2. Click "Transformers Movie Trailer" link
3. click "Play" button
4. Wait of the movie to start with audio
5. Press "back" button of browser 
6. user see page http://www.double.co.nz/video_test/
7. then wait...

result:-
Audio continue to play...

Expected:-
Audio should stop play immediately...


PS:
1. This happens if we navigate to another page by clicking a link or typing new url on address bar.

2. This WONT happen if we open a new tab/window (with navigating away) and then close the <VIDEO> tab/window.

3. But if we first navigate away and then do new tab/window and close the tab/window HAD <VIDEO>, the audio continue to play.

Comment 1

[Biju]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) 
Gecko/20081220 Minefield/3.2a1pre

Comment 2

[Biju]

Also unlike Bug 460738 I could play same url in another tab

Comment 3

[cajbir (:cajbir)]

How long does the audio continue to play for? Does it play for just a few seconds? Or does it keep playing forever?

Comment 4

[Ria Klaassen (not reading all bugmail)]

Regression in the first week of December seemingly, for me on 4 Dec 2008. And here it doesn't stop by itself. It is not reproducible in my daily trunk browser.

Comment 5

[Jeff Walden [:Waldo]]

Do at-end event listeners fire when the audio finishes?  What about if you've gone to a different site entirely in that tab?

Comment 6

[cajbir (:cajbir)]

Ria, when you say it's not reproducible in your daily trunk browser, do you mean the nightly builds? Is that on Windows?

Biju, what version of FF is this? A nightly build or a 3.1 beta? Or both?

Comment 7

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #6)
> Ria, when you say it's not reproducible in your daily trunk browser, do you
> mean the nightly builds? Is that on Windows?

Yes, Windows XP. In my daily browser there are extensions and changed settings, maybe this is the reason. But the same browser shows the bug with a new profile.

Comment 8

[Ria Klaassen (not reading all bugmail)]

Yeah it's an extension that corrects the bug, Interclue if my computer isn't playing me tricks. Interclue displays a popup when you hover over a link with the contents of the linked page, so that you don't need to open the whole page.

Comment 9

[Biju]

(In reply to comment #6)
> Biju, what version of FF is this? A nightly build or a 3.1 beta? Or both?

Both
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) 
Gecko/20081221 Shiretoko/3.1b3pre

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) 
Gecko/20081220 Minefield/3.2a1pre

(In reply to comment #3)
> How long does the audio continue to play for? Does it play for just a few
> seconds? Or does it keep playing forever?

Forever (ie, till end of movie) by step on comment 0


CORRECTION on comment 0
PS
2. This WONT happen if we open a new tab/window (without navigating away) 
   and then close the <VIDEO> tab/window.

3. But if we first navigate away and then do new tab/window 
   and close the tab/window HAD <VIDEO>, the audio continue to play.
   FOR FEW SECONDS

Comment 10

[cajbir (:cajbir)]

This is caused by the following changeset on the 4th December.

http://hg.mozilla.org/mozilla-central/rev/d5969f0d3fd9

There's no bug number on the description so I can't tell what bug it was for. CCing Daniel, maybe he can advise.

If I revert that changeset then the problem goes away.

Comment 11

[cajbir (:cajbir)]

This should be blocking1.9.1 I think.

Comment 12

[cajbir (:cajbir)]

The bug for the changeset from comment 10 was bug 466607

Comment 13

[cajbir (:cajbir)]

Attachment: Advertise supporting nsIHTMLMediaElement in Video and Audio elements

nsHTMLVideoElement and nsHTMLAudioElement didn't have nsIHTMLMediaElement in the implementation map.

Comment 14

[cajbir (:cajbir)]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/fa8ac62dd13e

Comment 15

[cajbir (:cajbir)]

Pushed to mozilla-1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a76a00dc527e

Comment 16

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090507 Shiretoko/3.5b5pre
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090507 Minefield/3.6a1pre