473760 - browser components broken (Can't set default browser, RSS feed has no style information, No default browser dialog anymore, no import of bookmarks)

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Shadow912]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090115 Minefield/3.2a1pre BuildID: 20090115033950 

Can't set to system defaults browser when press [Check Now] button.

Reproducible: Always

Steps to Reproduce:
1.Open Options dialog, select Advanced panel > General tab
2.Press [Check Now] button in System Defaults

Actual Results:  
Minefield isn't set to System Defaults browser.

Expected Results:  
Minefield is set to System Defaults browser.

on error console:

Error: Components.classes['@mozilla.org/browser/shell-service;1'] is undefined
Source File: chrome://browser/content/preferences/advanced.js
Line: 531

Comment 1

[Robert Strong (they/them - no direct email)]

Confirmed using
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090115 Minefield/3.2a1pre

Now to figure out what broke this

Comment 2

[Nochum Sossonko [:Natch]]

Is this broken on 1.9.1 branch?

Comment 3

[Robert Strong (they/them - no direct email)]

No. That can be checked by installing / running Shiretoko, making sure another browser is set as default, and trying to set as default.

Comment 4

[Robert Strong (they/them - no direct email)]

Nothing obvious has changed that would cause this. A regression range would be handy.

Comment 5

[Robert Strong (they/them - no direct email)]

Also broken in latest zip builds

Comment 6

[Robert Strong (they/them - no direct email)]

Just rebuilt without a clobber and was not able to reproduce this. :(

Comment 7

[Robert Strong (they/them - no direct email)]

After packaging is when this happens

Comment 8

[Robert Strong (they/them - no direct email)]

The following build works
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090113 Minefield/3.2a1pre

SourceStamp=9dbded90af2a

Comment 9

[Robert Strong (they/them - no direct email)]

bug 467862 caused this... see bug 467862 comment #8

Comment 10

[(not currently active) Ted Mielczarek]

So only packaged builds?

Comment 11

[Robert Strong (they/them - no direct email)]

Packaged zip and installer.

Comment 12

[Robert Strong (they/them - no direct email)]

I also just verified that running in dist/bin with changeset 19e319a0647b does work

Comment 13

[Robert Strong (they/them - no direct email)]

In case you didn't see it in bug 467862 I'm taking tomorrow off and won't be back until Tuesday so I won't be able to help fix this bug anytime soon

Comment 14

[(not currently active) Ted Mielczarek]

Oops, I broke the browser components. I suspect this has to do with SHORT_LIBNAME.

Comment 17

[(not currently active) Ted Mielczarek]

< ./components/browsercomps.dll

Yeah. The browser components are getting built as "browsercomps.dll", but the packaging manifest wants to package "brwsrcmp.dll". Hilarity ensues. I guess I should either fix or remove support for SHORT_LIBNAME. (I'd prefer the latter, actually.)

Comment 18

[(not currently active) Ted Mielczarek]

Wish our unit tests were testing the packaged builds. :-/ (Granted that bug is assigned to me too.)

Comment 19

[(not currently active) Ted Mielczarek]

Pushed a bustage fix, sorry about that:
http://hg.mozilla.org/mozilla-central/rev/28e4291a4892

Comment 20

[Mark Banner (:standard8)]

(In reply to comment #19)
> Pushed a bustage fix, sorry about that:
> http://hg.mozilla.org/mozilla-central/rev/28e4291a4892

Checked in same fix to js/src/config to fix TUnit: http://hg.mozilla.org/mozilla-central/rev/865f79b35ebf

Comment 22

[Shadow912]

I've confirmed to fix this issue under Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090117 Minefield/3.2a1pre BuildID: 20090117033728.
thanks all.

Comment 23

[nightstalkerz]

This seems to be broken again in build:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090130 Minefield/3.2a1pre

so if anyone can confirm.

Comment 24

[(not currently active) Ted Mielczarek]

WFM with the same build.

Comment 25

[nightstalkerz]

Actually it WFM now on a different machine with Vista instead of XP using same build.