479274 - IE6 / IE 7 CSS layout is broken on Home and News&Events pages

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[Aakash Desai [:aakashd]]

Attachment: IE6 Layout Behavior ScreenShot

The layout for the Home and News&Events pages on IE 6 are broken. A screen shot showing this behavior is attached to this bug. Thanks StephenD for grabbing the pic.

Comment 1

[krupa raj[:krupa]]

Attachment: Tabs in IE6

Tabs in the header look broken too.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: IE 7 horked layout

Let me know if we should be spinning off separate bugs about all these issues.

Comment 4

[krupa raj[:krupa]]

Attachment: y - getting chopped

adding another screenshot:

1.go to https://spreadfirefox.authstage.mozilla.com
2.Log in with valid credentials.
3.Once logged in,notice the breadcrumb

observed behavior:
'y' in "My Account" is getting chopped off and looks like 'v'

Comment 5

[krupa raj[:krupa]]

Attachment: administer link out of the login module

Comment 6

[Neil Lee [:neilio]]

Attachment: Mega patch to fix most (all?) of the ie 6/7 bugs

Requires a bunch of new images, will attach in a zip.

Comment 7

[Neil Lee [:neilio]]

Attachment: New images to fix IE CSS bugs

Comment 8

[krupa raj[:krupa]]

Attachment: horizontal line looks too big in IE6

Horizontal line in the login component is too big in IE6(pls see screenshot)

Comment 9

[Alex Buchanan [:abuchanan]]

Comment on attachment 366339 [details] [diff] [review]
Mega patch to fix most (all?) of the ie 6/7 bugs

ugh, i hate to do it, but I've gotta R- this.  

- You changed the image height on the CTA learn more, but it was already looking exactly like the mock, changing actually made it further from the mockup.

- the changes you made to the header tabs in main.css actually made the nav tabs worse for me in FF3 on linux

Comment 10

[Alex Buchanan [:abuchanan]]

Comment on attachment 366341 [details]
New images to fix IE CSS bugs

I think this was mentioned in another bug also, but the CTA learn more link images will have to be recut w/ bg colors so the text doesn't so look rough.

Comment 11

[Neil Lee [:neilio]]

buchanae: do you have a screenshot? I didn't touch the height of the learn more image as far as I know.

I'm installing Linux to do compatibility testing - maybe we should have a separate bug just for Linux issues?

Comment 12

[Alex Buchanan [:abuchanan]]

(In reply to comment #11)
> buchanae: do you have a screenshot? I didn't touch the height of the learn more
> image as far as I know.

If you look at the patch, you'll see (abbreviated)...

Index: call-to-action-block.tpl.php
===================================================================
--- call-to-action-block.tpl.php	(revision 23017)
+++ call-to-action-block.tpl.php	(working copy)
@@ -4,19 +4,19 @@
-<p class="cta"><a href="<?= $ctas['left']['link'] ?>"><img src="<?= media('img/learnmore.png') ?>" width="79" height="13" alt="Learn More" /></a></p>
+<p class="cta"><a href="<?= $ctas['left']['link'] ?>"><img src="<?= media('img/learnmore.png') ?>" width="76" height="11" alt="Learn More" /></a></p>
 

... notice the width and height change.  Could be an accident, getting used to patches and all.

Comment 13

[Neil Lee [:neilio]]

Attachment: New patch to fix Learn More sizing

I hope I did this correctly, but I applied this patch, fixed the issue, and then diffed this new patch. Let me know if this works.

Comment 14

[Alex Buchanan [:abuchanan]]

Comment on attachment 367333 [details] [diff] [review]
New patch to fix Learn More sizing

looks OK to me.  One thing is that the patch doesn't include the ie7.css file, but you can commit that file when you commit this patch.

Comment 15

[Mary]

Hey Neil:  Just checking in on this :)

Comment 16

[Neil Lee [:neilio]]

rev=23556 - ie7.css checked in.

Comment 17

[Neil Lee [:neilio]]

rev=23609 - the entire IE enchilada committed.

Comment 18

[krupa raj[:krupa]]

Attachment: community spotlight section-chopped off

Tabs look much better but Community spotlight section looks chopped off.
Reopening...

Comment 19

[Neil Lee [:neilio]]

Whoops. Fixed in rev=23612.

Comment 20

[krupa raj[:krupa]]

Attachment: administer link in Ie6-out of login module

Administer link is still out of the Login module.Reopening.

Comment 21

[Neil Lee [:neilio]]

This should be completely fixed now. There's a teensy issue with the height of the white dividing line, but it's pretty minimal and doesn't need to be addressed, IMO.

http://i42.tinypic.com/9h4enc.jpg

Comment 22

[Stephen Donner [:stephend] Not actively reading bugmail]

I'm going to call this bug verified fixed, because it's getting too cluttered; at this stage, we need to file specific, focused bugs.

[1] Comment 20's bug is fixed in both IE 6 and 7.
[2] Original bug in comment 0, likewise.
[3] Ditto for comment 1, comment 2.

There are also known bugs, such as bug 479675 and bug 479343 comment 11, that affect all browsers and will need to be retested after the fix(es) land.

Verified FIXED.