Closed Bug 482610 Opened 12 years ago Closed 12 years ago

tango preferences icons

Categories

(Thunderbird :: Preferences, enhancement)

All
Linux
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: clarkbw, Assigned: clarkbw)

References

()

Details

(Whiteboard: tango)

Attachments

(4 files)

Andreas has created a set of Tango style icons for the preference dialog.  I've attached the tar of the icon set.  I'm tempted to just ask for review on replacing the old icons without changing anything else.  However we had planned to change the 'Privacy' tab into a 'Security' tab.   This change could involve renaming the privacy tab files, ids, and icons into security or just swapping out the text and icon from underneath.  

Perhaps I should create the 'Privacy' -> 'Security' bug w/ patch now and then commit this bug once that has been committed.
Flags: blocking-thunderbird3+
Whiteboard: tango
Attached image junk icon
Here is a junk icon I copied from tango-icon-theme (now PD, so no license issues).
bug 482617 has been opened for adding the junk tab to the preferences dialog
bug 482623 has been opened for changing the 'Privacy' tab to 'Security'
Depends on: 482623
this patch should be able to land in parallel to bug 482623 being committed since the security image was included in the other patch.  This only updates the gnomestripe theme for now with new images, when I get a chance to run on Windows I can see how good this will look and make a separate patch for that.
Comment on attachment 366876 [details] [diff] [review]
new images and cleaned permissions

tasty new icons!
Attachment #366876 - Flags: review?(mkmelin+mozilla)
Comment on attachment 366876 [details] [diff] [review]
new images and cleaned permissions

Sweet! Will check in in a moment.
Attachment #366876 - Flags: review?(mkmelin+mozilla) → review+
changeset:   2186:6cd94467079d
http://hg.mozilla.org/comm-central/rev/6cd94467079d

->FIXED
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
something is up, the old general image snuck in there:
http://hg.mozilla.org/comm-central/raw-file/6cd94467079d/mail/themes/gnomestripe/mail/preferences/general.png
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Magnus, did get a chance to look at the general file?
I have no idea how that didn't make it (an hg bug?), as i did a hg import of the patch.

It does complain when trying to apply
"patch: **** Only garbage was found in the patch input." ...
here's a patch for just the general.png file.  I'm hoping this fixes the hg import problem...
Attachment #367262 - Flags: review?(mkmelin+mozilla)
Comment on attachment 367262 [details] [diff] [review]
general.png file fix

changeset:   2206:b7731c0b1849
http://hg.mozilla.org/comm-central/rev/b7731c0b1849
Attachment #367262 - Flags: review?(mkmelin+mozilla) → review+
fixed!
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.