tango preferences icons

RESOLVED FIXED in Thunderbird 3.0b3

Status

Thunderbird
Preferences
--
enhancement
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: clarkbw, Assigned: clarkbw)

Tracking

Trunk
Thunderbird 3.0b3
All
Linux
Dependency tree / graph
Bug Flags:
blocking-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: tango, URL)

Attachments

(4 attachments)

Created attachment 366666 [details]
tango preferences icons

Andreas has created a set of Tango style icons for the preference dialog.  I've attached the tar of the icon set.  I'm tempted to just ask for review on replacing the old icons without changing anything else.  However we had planned to change the 'Privacy' tab into a 'Security' tab.   This change could involve renaming the privacy tab files, ids, and icons into security or just swapping out the text and icon from underneath.  

Perhaps I should create the 'Privacy' -> 'Security' bug w/ patch now and then commit this bug once that has been committed.
Flags: blocking-thunderbird3+
(Assignee)

Updated

9 years ago
Whiteboard: tango
Created attachment 366669 [details]
junk icon

Here is a junk icon I copied from tango-icon-theme (now PD, so no license issues).
(Assignee)

Comment 2

9 years ago
bug 482617 has been opened for adding the junk tab to the preferences dialog
(Assignee)

Comment 3

9 years ago
bug 482623 has been opened for changing the 'Privacy' tab to 'Security'
(Assignee)

Updated

9 years ago
Depends on: 482623
(Assignee)

Comment 4

9 years ago
Created attachment 366876 [details] [diff] [review]
new images and cleaned permissions

this patch should be able to land in parallel to bug 482623 being committed since the security image was included in the other patch.  This only updates the gnomestripe theme for now with new images, when I get a chance to run on Windows I can see how good this will look and make a separate patch for that.
(Assignee)

Comment 5

9 years ago
Comment on attachment 366876 [details] [diff] [review]
new images and cleaned permissions

tasty new icons!
Attachment #366876 - Flags: review?(mkmelin+mozilla)

Comment 6

9 years ago
Comment on attachment 366876 [details] [diff] [review]
new images and cleaned permissions

Sweet! Will check in in a moment.
Attachment #366876 - Flags: review?(mkmelin+mozilla) → review+

Comment 7

9 years ago
changeset:   2186:6cd94467079d
http://hg.mozilla.org/comm-central/rev/6cd94467079d

->FIXED
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

9 years ago
something is up, the old general image snuck in there:
http://hg.mozilla.org/comm-central/raw-file/6cd94467079d/mail/themes/gnomestripe/mail/preferences/general.png
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

9 years ago
Magnus, did get a chance to look at the general file?

Comment 10

9 years ago
I have no idea how that didn't make it (an hg bug?), as i did a hg import of the patch.

It does complain when trying to apply
"patch: **** Only garbage was found in the patch input." ...
Created attachment 367262 [details] [diff] [review]
general.png file fix

here's a patch for just the general.png file.  I'm hoping this fixes the hg import problem...
Attachment #367262 - Flags: review?(mkmelin+mozilla)

Comment 12

9 years ago
Comment on attachment 367262 [details] [diff] [review]
general.png file fix

changeset:   2206:b7731c0b1849
http://hg.mozilla.org/comm-central/rev/b7731c0b1849
Attachment #367262 - Flags: review?(mkmelin+mozilla) → review+
fixed!
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.