489116 - please QA 3.5 major update window

Status: VERIFIED DUPLICATE of bug 483058

(www.mozilla.org :: General, defect)

Description

[John Slater]

Hi guys. The 3.0 -> 3.5 major update is happening with the 3.5 launch instead of a few weeks later like we've done in the past. Please work your QA magic to make sure it checks out.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

We don't have an update path from any 3.0.x to any 3.1/3.5b set up at the moment, but will do once 3.0.9 and 3.5b4 are complete (which will probably dovetail nicely with having more translations in bug 488640). Would we want testing sooner than that ? Would be quick to create a dummy update to confirm that the content displays OK in the major update dialog box.

Comment 2

[Tony Chung [:tchung]]

we've already done a thorough trial MU from 3.0.7 to 3.1b3 last month.  See testresults at https://wiki.mozilla.org/QA/Firefox3/TestPlan/MajorUpdate/Results:3.0.6_fx3.1b3.   Nick do you anticipate update code to be much different in an update to 3.5b4?  I dont want to create extra work for qa when its already been completed.    

Testing MU from 3.0.x to 3.5 final release is already part of the final plan.

Comment 3

[juan becerra [:juanb]]

The updater code will not be different, but we will have to check that the content in the major update dialog fits for each of the platforms and locales. We should wait for bug 488640 to be completed, and use those translations with either a dummy MU or another test major update.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Steps to test the en-US content:
1, Create a new profile with 3.0.9 candidate build2
2, Visit https://www-trunk.stage.mozilla.com/en-US/firefox/3.5/details/ to establish http auth
3, Load about:config, create a new string preference called app.update.url.override, with value
 http://people.mozilla.org/~nthomas/update-fx35-test.xml
4, Help > Check for updates
5, Eyeball major update offer

The update is a no-op but will fail (it seems the updater requires having something to do). The choice of "3.1b3" is arbitrary, happy to change it to whatever you want.

Looks OK on mac, except for the content is taller than the available space. NB Firefox 3.0.8 on Mac displays two vertical scrollbars, fixed by bug 374820.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Page looks fine to me when just loading it by itself -- the QAE team can finish testing the integration pieces (other locales, dialog sizes, etc?); I haven't been asked to, nor tested that, in quite some time.

Comment 6

[John Slater]

Just checking back in here...is there anything holding us back from resolving this bug? 

(more details at https://bugzilla.mozilla.org/show_bug.cgi?id=483058#c34)

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #6)
> Just checking back in here...is there anything holding us back from resolving
> this bug? 
> 
> (more details at https://bugzilla.mozilla.org/show_bug.cgi?id=483058#c34)

I'm working on testing this on en-US, with Juan's help, today; will post back with results.  He and Al will be testing the locales (I think) after en-US -- maybe in a separate (tracking?) bug.

Comment 8

[juan becerra [:juanb]]

Attachment: Mac: Fail

Comment 9

[juan becerra [:juanb]]

Attachment: Windows: Fail

Comment 10

[Al Billings [:abillings - ex-MoCo]]

This is going to get worse with l10n.

Comment 11

[juan becerra [:juanb]]

Attachment: Linux: OK

Details page looks OK in Linux only. Mac and Windows have some scrollers which should not be there.

Comment 12

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

1) john: do you know who can/should look at the scrollbars on win32 and mac? I ask because I dont know! :-(

2) pascal: any ETA on the l10n pages?

Comment 13

[Pascal Chevrel:pascalc]

Kubla is currently broken for publishing (Bug 493207), I am doing a check-out of both stage and production tags to publish the 50 locales ready manually, 12 haven't done the translation yet.

Comment 14

[Steven Garrity [:sgarrity]]

(In reply to comment #12)
> 1) john: do you know who can/should look at the scrollbars on win32 and mac? I
> ask because I dont know! :-(

I'll look at this issue tomorrow (Tuesday).

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Why is this not just a dupe of / being reported on bug 483058?

Comment 16

[Steven Garrity [:sgarrity]]

(In reply to comment #15)
> Why is this not just a dupe of / being reported on bug 483058?
Not sure which bug I should be commenting on...

(In reply to comment #12)
> 1) john: do you know who can/should look at the scrollbars on win32 and mac? I
> ask because I dont know! :-(
I've addressed the scrolling on win32 in r25884. Mac is too far off to avoid scrolling without a major layout change, which is probably ill advised at this point.

How did this window end up at a different size on all three platforms? Probably not a useful question at this point.

Comment 17

[juan becerra [:juanb]]

I don't think there's a reason why this isn't duped to bug 483058. I'll dupe after I add three more window shots corresponding to the MU offer when there are incompatible addons, in which case the space is further reduced to accommodate the warning.

Comment 18

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #16)
> (In reply to comment #15)
> > Why is this not just a dupe of / being reported on bug 483058?
> Not sure which bug I should be commenting on...
> (In reply to comment #12)
> > 1) john: do you know who can/should look at the scrollbars on win32 and mac? I
> > ask because I dont know! :-(
> I've addressed the scrolling on win32 in r25884. Mac is too far off to avoid
> scrolling without a major layout change, which is probably ill advised at this
> point.

Could you elaborate? Layout change of the website page? Change to the dialog box? Both?


> How did this window end up at a different size on all three platforms? Probably
> not a useful question at this point.

Actually, I think could be useful question, in the context of MU being something we'll need to do again, so figuring whats involved in fixing this? 

Also, I remember some discussions about unexpected scrollbars in the update dialog of the FF2->FF3.0 major update offers. Was that an earlier occurrence of this same problem, or are we seeing a new problem here?

Comment 19

[juan becerra [:juanb]]

Attachment: Mac (incompatible extension): Fail

Comment 20

[juan becerra [:juanb]]

Attachment: Windows (incompatible extension): Fail

Comment 21

[juan becerra [:juanb]]

Attachment: Linux (incompatible extension): Fail

Comment 22

[Pascal Chevrel:pascalc]

well, there isn't much space in this box and we have a big logo taking a good chunk of the little space we have. I vote for a small Firefox logo :)

Comment 23

[juan becerra [:juanb]]

I've added the images for reference. I am going to dupe this to bug 483058, because that bug seems to be about the content of the details page, whereas this one seems to be about the page fitting in the window. Since the size of the window is a constraint to its content, we'll use bug 483058 to track all of this.