Keyboard shortcut for "Undo close window" fails if no windows are open (and "recently closed windows" submenu hasn't been shown)

NEW
Unassigned

Status

()

Firefox
Keyboard Navigation
P5
minor
9 years ago
a year ago

People

(Reporter: Jesse Ruderman, Unassigned, Mentored)

Tracking

(Blocks: 2 bugs)

Trunk
x86
Mac OS X
Points:
5
Dependency tree / graph
Bug Flags:
blocking-firefox3.5 -
wanted-firefox3.5 +

Firefox Tracking Flags

(blocking2.0 -)

Details

(Whiteboard: [qx:spec][outreachy-12])

(Reporter)

Description

9 years ago
1. Launch Firefox
2. ⌘W (close the only browser window without quitting Firefox)
3. ⇧⌘N (try to reopen the window)

Result: fail beep

4. Open "History" menu
5. Open "Recently Closed Windows" submenu
6. Close the menus
7. ⇧⌘N

Result: now it works
Flags: blocking-firefox3.5?
Does this also happen if there are arbitrary open/close tab or window steps between 2 and 3? Trying to gauge effect.
Assignee: nobody → paul
(In reply to comment #1)
> Does this also happen if there are arbitrary open/close tab or window steps
> between 2 and 3? Trying to gauge effect.

Still happens. Close any number of windows until you have 0 left and the keyboard shortcut doesn't work (so long as you don't access the menu at all).

The question is, is that a problem with out menu system? The keyboard shortcut works if you have a window open but have never accessed the History menu.

If not I guess the "easy" solution is to listen for "domwindowclosed" and force the menu to update every time (or call out from sessionstore if that's possible)
Sucks, but doesn't block as I don't think we're gonna have a lot of people reaching for that oh-so-easy three-fingered command sequence.

We should fix it, though.
Flags: wanted-firefox3.5+
Flags: blocking-firefox3.5?
Flags: blocking-firefox3.5-
(Reporter)

Updated

8 years ago
Duplicate of this bug: 565632
I hit this probably once a day. It's a really frustrating paper cut. Please? :)
blocking2.0: --- → ?
Random theory - does this not work because the menuitem with the keyboard shortcut is never generated until the menu is shown? Could we maybe fix this by adding a dummy entry in the menu with the keyboard shortcut?
(Reporter)

Comment 7

8 years ago
This bug essentially means that the keyboard shortcut for "Undo close window" does not work for people who only keep one window open.
Blocks: 565515
(In reply to comment #6)
> Random theory - does this not work because the menuitem with the keyboard
> shortcut is never generated until the menu is shown? Could we maybe fix this by
> adding a dummy entry in the menu with the keyboard shortcut?

If true, that's probably the reason for this bug as well:

https://bugzilla.mozilla.org/show_bug.cgi?id=328746
Colin, it seems like it _might_ be related to that bug, but not sure.

I took a second and tested, but it didn't help. My next theory is that we're not looking to into 2nd level menupopups for keyboard shortcuts (unless they are viewed first?). Doesn't make a whole lot of sense but it's the next guess as to why it wouldn't even work with a dummy menu entry

I don't have any time right now to investigate, so if anybody wants to look into it, please do.
Assignee: paul → nobody
Doesn't block, but would love to see a safe patch that made Colin happier.
blocking2.0: ? → -

Comment 12

5 years ago
Can't believe this hasn't been fixed. I stopped using Firefox a really long time ago and was hoping this had been fixed.

Comment 13

5 years ago
My workaround is to hit Cmd-J (opening the downloads/history/bookmarks window), then hit Cmd-Shift-N (now it works!), then Cmd-` or something (..whatever you've set that switches to the previous/next window), and Cmd-W. Only four combos! Still, having the one work would be nice.

I'm not sure why I hit Cmd-J instead of Cmd-N, maybe because it's usually smaller and less in-the-way, or it might have been faster that one time.
Whiteboard: [qx] → [qx:spec]
Priority: -- → P5
Note that this also causes the keyboard shortcut to fail if there are just no windows open on the currently selected Space, even if there are windows open on other Spaces....
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Blair, please comment in the bug if you got anywhere on this. In the meantime I'll reassign it to Katie as she can work on it next week.
Assignee: bmcbride → kbroida
Whiteboard: [qx:spec] → [qx:spec][outreachy-12]
I haven't had the free time I had hoped I would to tackle this. I'm going to free it up for the next person.
Assignee: kbroida → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.