Open Bug 492953 Opened 15 years ago Updated 2 years ago

gloda activity manager processes have incorrect / incomplete context for account - shows null

Categories

(Thunderbird :: Search, defect)

defect

Tracking

(Not tracked)

People

(Reporter: asuth, Unassigned)

References

Details

(Keywords: polish, Whiteboard: [b3ux] [student-project])

currently they are like so:
  process.contextType = "account";
  process.contextObj  = aFolder;

We are missing a contextDisplayText, but also, Standard8 proposes we use the incomingServer as the context.  Since aFolder is (potentially confusingly) a string in the above case, the gloda indexer listener interface would want to be augmented to take the nsIMsgFolder in question (or null) instead.

example of using the incomingServer context setup:
http://mxr.mozilla.org/comm-central/source/mail/components/activity/modules/alertHook.js#66
Severity: normal → enhancement
Flags: blocking-thunderbird3?
Whiteboard: [b3ux]
Target Milestone: --- → Thunderbird 3.0b3
Keywords: polish
I'm not sure if this is the bug for it, but I miss having both server + folder in the activity manager operations. "Inbox is up to date" etc. really doesn't say anything when you have several accounts.
Target Milestone: Thunderbird 3.0b3 → Thunderbird 3.0b4
Flags: wanted-thunderbird3+
Flags: blocking-thunderbird3?
Flags: blocking-thunderbird3-
Whiteboard: [b3ux] → [b3ux] [student-project]
Component: Mail Window Front End → Search
QA Contact: front-end → search
Target Milestone should be resetted, 3.0 is out ...
Target Milestone: Thunderbird 3.0b4 → Future
In addition to the contextDisplayText missing, the aFolder argument seems to be null as if the gloda service is not sending the folder name. The result is that there is a context title above the progress bar just showing 'null', which is bad. So this is no longer an enhancement but a visible bug.

I could update the listener to take a real nsIMsgFolder, but why is gloda not sending anything? Is there a problem with _indexingFolder at
http://mxr.mozilla.org/comm-central/source/mailnews/db/gloda/modules/indexer.js#707
Severity: enhancement → normal
Target Milestone: Thunderbird 11.0 → ---
Maybe GlodaMsgIndexer._indexerEnterFolder should be calling GlodaIndexer._notifyListeners() around the area after where it logs what folder it is entering.  If we did this, then _worker_folderIndex will no longer need to call GlodaIndexer._notifyListeners.
getting this too.
Same "null" header is present on TB 45.2.0.
Same null header is present in TB 52.0b3
I confirm the same 'null' in TB 52.0.1.

Same 'null' header is present in TB 60.6.1

Summary: gloda activity manager processes have incorrect / incomplete context → gloda activity manager processes have incorrect / incomplete context for account - shows null
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.