494598 - Update Lightning icons to match new Thunderbird default theme

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[[:Aureliano Buendía]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4 (.NET CLR 3.5.30729)
Build Identifier: 

Thunderbird 3.0 move to a new default theme that implement Tango style on all
OS supported. Lightning icons should be move to Tango style first of 1.0 release.


Reproducible: Always

Comment 1

[Martin Schröder [:mschroeder]]

Kind of a duplicate of bug 401883, but I'm almost in favor of keeping this fresh bug report open and closing the other one.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Confirmed, agreed. Bryan, any comment on this?

Comment 4

[[:Aureliano Buendía]]

Should be wanted or blocking 1.0?

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

It'd be good to have a cleaner set of icons.  We need to scope the amount of work this is before starting.  Right now I'm not sure how many icons we have to work on.  What is the story for the other themes?

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

This being blocking 1.0 mainly depends on if someone (i.e andreasn/clarkbw ?) is willing to drive this. I've already spoken to andreasn recently, and I have counted a total of 25-30 icons per theme. Note this is the total amount for the whole project, its quite likely that we don't have to change all the icons.

Calendar only has two themes currently, pinstripe for mac and winstripe for Windows/Linux and some common data shared by both themes. The smallest solution for this bug would be to just replace the existing icons, but given that mail has gnomestripe/pinstripe/qute, we might want to create a new theme at least for the icons. I'd be willing to do some theme cleanup if we decide to go that route.

Comment 7

[Lajos Kósa]

I guess some kind of relationship between this topics and what I've realised today. I dowloaded thunderbird 3.0b3, and tested. I have lightning 0.9. And practically nothing works. I cannot set a lot of options, and the down half of thunderbird is the lightning pane - looks very bad. I know thunderbird is only in beta phase now but I assume it's a lightning problem. It would be nice to get it solved, since I like lightning.

If you need some screenshots, I will put it on my ftp.

openSuSE 11.1 I am using.

Comment 8

[[:Aureliano Buendía]]

(In reply to comment #7)
> I guess some kind of relationship between this topics and what I've realised
> today. I dowloaded thunderbird 3.0b3, and tested. I have lightning 0.9. And
> practically nothing works. 

Because Lightning 0.9 is for TB 2 and not for TB3.

Use this 

http://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/latest-comm-1.9.1/win32-xpi/

Comment 9

[Martin Schröder [:mschroeder]]

(In reply to comment #7)
> I guess some kind of relationship between this topics and what I've realised
> today. I dowloaded thunderbird 3.0b3, and tested. I have lightning 0.9. And
> practically nothing works.

Lightning 0.9 is not compatible with any Thunderbird 3.0 beta or nightly build. You shouldn't be able to install Lightning 0.9 without editing some version details. Please have a look at ftp://ftp.mozilla.org/pub/calendar/lightning/nightly/latest-comm-1.9.1/ for Lightning 1.0pre nightly builds which work with Thunderbird 3.0 builds.

Comment 10

[Lajos Kósa]

> Because Lightning 0.9 is for TB 2 and not for TB3.
> 
> Use this 
> 
> http://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/latest-comm-1.9.1/win32-xpi/

Actually, I needed this... ;)

http://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/latest-comm-1.9.1/linux-xpi/

But it works fine, thank you! Shall I already report a problem when I find something?

Comment 11

[Ilya Usvyatsky]

Is there a 64-bit (x86_64) linux XPI for the 1.9.1 or any other version compatible with Thunderbird 3.0?
Thanks,

Comment 12

[Philipp Kewisch [:Fallen][📱📆]]

Could we please keep the talk about which version of Lightning works with which version of Thunderbird out of this bug? This bug is about new icons for Thunderbird 3.0!

So, to get back to the real topic, what are the chances that we could get some new icons soon?

Comment 13

[Andreas Nilsson (:andreasn)]

Bryan asked me to look into this. What icons have the highest priority?

Comment 14

[Philipp Kewisch [:Fallen][📱📆]]

From simple inspection, the most user visible icons are:

calendar/base/themes/?instripe/
    mode-switch-icons.png (The Mail icon is probably not used though)
    calendar-occurrence-prompt.png
    toolbar-large/small.png:
      The today pane icon (calendar day with 31 on it)
      Add Task / Add Event icons

Comment 15

[Andreas Nilsson (:andreasn)]

In order to get the linux styling working properly, we need a separate gnomestripe theme space, like in bug 406742 for Thunderbird.

Comment 16

[Andreas Nilsson (:andreasn)]

Bryan suggested Phillip might be able to help out with that. Should we spin that off as a separate patch?

Comment 17

[Andreas Nilsson (:andreasn)]

err.. Philipp I mean, sorry for the misspell.

Comment 18

[Stefan Sitter [:ssitter]]

See existing Bug 471378 for gnomestripe theme.

Comment 19

[Andreas Nilsson (:andreasn)]

Attachment: gnomestripe icons

Since we don't have a theme space for this yet, I'm attaching these in a zip file rather than as a patch for now.

Comment 20

[Andreas Nilsson (:andreasn)]

Attachment: and the aero icons

Comment 21

[Martin Schröder [:mschroeder]]

Comment on attachment 415109 [details]
gnomestripe icons

The order of icons doesn't seem to be the same for normal and small toolbar icons (the pairs of 11/12th and 13/14th icon seem to be switched).

Comment 22

[Andreas Nilsson (:andreasn)]

Attachment: Updated gnomestripe with icons in their correct places

Comment 23

[Andreas Nilsson (:andreasn)]

Attachment: calendar-event-dialog-toolbar for gnomestripe

Comment 24

[Andreas Nilsson (:andreasn)]

Attachment: calendar-event-dialog-toolbar for aero

Comment 25

[Stefan Sitter [:ssitter]]

Thank you for your icon work. I noticed that some icons use the old calendar style (orange bar on top) but other icons use a new style (blue bar on top). Maybe this could be unified?

Comment 26

[Philipp Kewisch [:Fallen][📱📆]]

Andreas, does anything need to be updated to better match the 3.3 icons, or can we directly use the icons here. Sorry for not checking these in earlier! Also, what about comment 25?

Comment 27

[Decathlon]

If all the icons have to be changed in the Aero theme, then the twenty-first icon in the file toolbar-small.png needs to be changed with an equivalent icon without the text "31" because that icon is used for the todaypane button (see http://mxr.mozilla.org/comm-central/source/calendar/base/themes/winstripe/images/toolbar-small.png). Alternatively, a new icon should be added in the image.

Comment 28

[Andreas Nilsson (:andreasn)]

(In reply to comment #26)
> Andreas, does anything need to be updated to better match the 3.3 icons, or can
> we directly use the icons here. Sorry for not checking these in earlier! Also,
> what about comment 25?

Do you mean icons like this under Aero? http://www.andreasn.se/blog/images/aero-glass-preview.png

Comment 29

[Philipp Kewisch [:Fallen][📱📆]]

Yes, those I meant. I could have just looked at the attachments, sorry :) What do you think should be done for this bug? Maybe we can use the attached aero icons on non-aero platforms instead, so they don't go to waste? That means we would need new aero icons as in your screenshot.

I'll integrate the gnome icons using chrome modifiers so we don't have to create a full gnomestripe skin for now.

Comment 30

[Richard Marti (:Paenglab)]

Attachment: Corrected aero icons (missing calendar-event-dialog-toolbar-small-aero.png)

I updated the files and packet them together.

- On calendar-event-dialog-toolbar-aero.png the arrows there in the wrong direction.

- Removed icons in mode-switch-icons-aero.png which weren't in the files in tree. Also made the big icons smaller to fit to the used -moz-image-region.

- Added tasks-actions-aero.png. Extracted from toolbar-small-aero.png.

- Removed in toolbar-small-aero.png the number in the 11nt icon as in the file in tree (used for calendar-status-todaypane-button in the status bar).

Missing is calendar-event-dialog-toolbar-small-aero.png

Andreasn: please can you check the changed files if they have still the correct styling

Comment 31

[Richard Marti (:Paenglab)]

Attachment: Corrected gnomestripe icons (missing calendar-event-dialog-toolbar-small-linux.png)

Also for gnomestripe I updated the files and packet them together.

- On calendar-event-dialog-toolbar-linux.png the arrows there in the wrong direction.

- Added tasks-actions-linux.png. Extracted from toolbar-small-linux.png.

- Removed in toolbar-small-linux.png the number in the 11nt icon as in the file in tree (used for calendar-status-todaypane-button in the status bar).

Missing is calendar-event-dialog-toolbar-small-linux.png

Again Andreasn: please can you check the changed files if they have still the correct styling?

Comment 32

[Andreas Nilsson (:andreasn)]

(In reply to comment #31)
> Again Andreasn: please can you check the changed files if they have still
> the correct styling?

From a quick look (haven't tried them in action yet), they look good!

Comment 33

[Andreas Nilsson (:andreasn)]

Attachment: small linux calendar toolbar graphics

Comment 34

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Patch with images - v1

This patch contains the images and jar changes. Whats missing:

* Testing on mac/windows
* calendar-event-dialog-toolbar-small-aero.png
* aero css rules

Comment 35

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Patch with images - v2

This patch contains the images and jar changes. Whats missing:

* Testing on mac
* calendar-event-dialog-toolbar-small-aero.png

Comment 36

[Richard Marti (:Paenglab)]

Fallen, I have no build system. Please can you start try builds so I can test them?

Comment 37

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Patch with images - v3

This patch contains the images and jar changes. Whats missing:

* calendar-event-dialog-toolbar-small-aero.png

I'll create test builds within the next few hours.

Comment 38

[Philipp Kewisch [:Fallen][📱📆]]

http://mozilla.kewis.ch/bug-494598-lightning-linux64.xpi
http://mozilla.kewis.ch/bug-494598-lightning-win32.xpi

Can you also test on mac? If so then I'll create a build for you.

Comment 39

[Richard Marti (:Paenglab)]

(In reply to comment #38)
> 
> Can you also test on mac? If so then I'll create a build for you.

I have no Mac, but I could analyze the XPI.

Comment 40

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Patch with images - v4

This fixes another mac issue, preprocessor directives cannot be indented otherwise they don't function (but silently fail, yuck!)

Here's my mac build:
http://mozilla.kewis.ch/bug-494598-lightning-macosx64.xpi

Comment 41

[Andreas Nilsson (:andreasn)]

Attachment: aero graphics

Comment 42

[Richard Marti (:Paenglab)]

Comment on attachment 540692 [details] [diff] [review]
Patch with images - v4

Review of attachment 540692 [details] [diff] [review]:
-----------------------------------------------------------------

Code wise I'll give a r+ but graphics have some problems.

The Mac part looks good what I can say from checking the XPI.

The Linux part is missing the delete icon in calendar-event-dialog-toolbar-small-linux.png between the forward and Junk symbols). This is visible when you switch between normal and small icon mode in calendar-event-dialog.

For Windows the mode-switch-icons-aero.png isn't added nor used. If this will be used either it can fully replace the old image, or additional rules are needed in lightning-aero.css.

The new calendar-event-dialog-toolbar-small-aero.png added today is with his monochrome styling completely different to the normal calendar-event-dialog-toolbar-aero.png. The small one has also totally different dimensions to the XP icons and are needing additional rules to fit. I think it's to late for this release to change to the monochrome styling with new button- and toolbar appearance. Better would be the colored small icons would be used and the monochrome icons can be introduced in the next version.

Overall, if the graphics problems are solved this patch can land.

Comment 43

[Andreas Nilsson (:andreasn)]

(In reply to comment #42)
> The new calendar-event-dialog-toolbar-small-aero.png added today is with his
> monochrome styling completely different to the normal
> calendar-event-dialog-toolbar-aero.png. The small one has also totally
> different dimensions to the XP icons and are needing additional rules to
> fit. I think it's to late for this release to change to the monochrome
> styling with new button- and toolbar appearance. Better would be the colored
> small icons would be used and the monochrome icons can be introduced in the
> next version.

Indeed, will fix this. Monochrome icons will land in another bug.

Comment 44

[Philipp Kewisch [:Fallen][📱📆]]

Andreas, any chance you could fix this today?

Comment 45

[Andreas Nilsson (:andreasn)]

Attachment: lets see if this works better

New version of calendar-event-dialog-toolbar-small-aero.png

Comment 46

[Andreas Nilsson (:andreasn)]

Attachment: new calendar-event-dialog-toolbar-small-linux.png graphics

Comment 47

[Philipp Kewisch [:Fallen][📱📆]]

Andreas, thanks for taking care this early in the morning :)

I have imported the icons, added a rule for mode-switch-icons-aero and also fixed the "icons beside text" not working in the event dialog toolbar. Note this patch is only tested on mac, but since I don't have my win/linux box with me I'm going to let the build machines create the build (rc2) and see if it works afterwards.

comm-central:

changeset:   8018:230e76c2936f
tag:         tip
user:        Philipp Kewisch <[e-mail]>
date:        Mon Jun 20 05:41:00 2011 +0200
summary:     Fix bug 494598 - Update Lightning icons to match new Thunderbird default theme. r=paenglab

comm-miramar:

changeset:   7850:6c44f2673a19
user:        Philipp Kewisch <[e-mail]>
date:        Mon Jun 20 05:41:00 2011 +0200
summary:     Fix bug 494598 - Update Lightning icons to match new Thunderbird default theme. r=paenglab

changeset:   7853:cb34a7848acc
branch:      COMM50_20110620_RELBRANCH
tag:         tip
user:        Philipp Kewisch <[e-mail]>
date:        Mon Jun 20 05:41:00 2011 +0200
summary:     Fix bug 494598 - Update Lightning icons to match new Thunderbird default theme. r=paenglab

Comment 48

[Philipp Kewisch [:Fallen][📱📆]]

Pushed another fix for the mode switch icons:


comm-central

changeset:   8020:c0cd6fb84c73
tag:         tip
user:        Philipp Kewisch <[e-mail]>
date:        Mon Jun 27 16:02:18 2011 +0300
summary:     Bug 494598 - Update Lightning icons to match new Thunderbird default theme - Correct Aero mode switch icons


comm-miramar

changeset:   7854:ec401a096a8c
branch:      COMM50_20110620_RELBRANCH
tag:         CALENDAR_1_0b4_BUILD2
user:        Philipp Kewisch <[e-mail]>
date:        Mon Jun 27 16:02:18 2011 +0300
summary:     Bug 494598 - Update Lightning icons to match new Thunderbird default theme - Correct Aero mode switch icons

changeset:   7855:5e39b790fe71
parent:      7850:6c44f2673a19
user:        Philipp Kewisch <[e-mail]>
date:        Mon Jun 27 16:02:18 2011 +0300
summary:     Bug 494598 - Update Lightning icons to match new Thunderbird default theme - Correct Aero mode switch icons