496655 - Tag Page: Functionality

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Mike Lee]

As indicated on the Tagging Spec
(http://docs.google.com/Doc?docid=dds6vwb4_1dxwx5vg3&hl=en)

1.10 - Tag page
A tag page should have an URL that is easy to understand, like "addons.mozilla.org/tag/photography".  This page should contain a listing (similar to a search results page) for add-ons with a specific tag.

This bug involves:
+ CakePHP code
+ unit tests via Simpletest

Comment 1

[Mike Lee]

This is basically a Search Results page (bug 488519), except that the UI wouldn't have text reading "Search Results, Showing 1-10 of 401 results..." at the top and "Refine Results" in the left column.

Comment 2

[Mike Lee]

ETA: possibly tomorrow. Yem and Mark looking into this now.

Comment 3

[Mike Lee]

Work in progress. Aiming to complete it tomorrow.

Comment 4

[Mike Lee]

ETA moved to EOD Monday.

Comment 5

[Wil Clouser [:clouserw]]

(In reply to comment #4)
> ETA moved to EOD Monday.

Status?

Comment 6

[Mike Lee]

Notes from Mark:

I resolved my bugs involving SERP so unless something mysterious appears I'm trying to focus in on Tag Pages, which have caused me endless head scratching. I'm spinning my wheels about it.

Originally, since the UI for SERP and Tag pages were so similar, it made sense to not repeat the code and instead to make a route
amo/tag/tag_name => amo/search?tag=tag_name

But I ran into a bunch of obstacles with this approach. After talking it over, it makes more sense to do this the proper way (even if some code will be repeated) by creating this functionality in the Tag controller.

I'd like to have this knocked out at the very latest by eod tomorrow night.

Comment 7

[Mark Wunsch]

Attachment: Update to Tag controller and Routes

Comment 8

[Mark Wunsch]

The attached patch updates the tag controller with a new function, display().
Took the naming convention from the addons controller.

Display takes a tag_name and runs a search() with it. Had to pull in some additional Models and Components.

In addition, I also updated the routes so you can have what the spec describes:
addons.mozilla.org/tag/tag_name

as well as

addons.mozilla.org/tags/display/tag_name

I added the UI task (bug 496657) as a dependency to this bug. The new view will be attached there.

Comment 9

[Wil Clouser [:clouserw]]

Thanks, this is r29298