496657 - Tag Page: UI

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Mike Lee]

As indicated on the Tagging Spec
(http://docs.google.com/Doc?docid=dds6vwb4_1dxwx5vg3&hl=en)

1.10 - Tag page
A tag page should have an URL that is easy to understand, like "addons.mozilla.org/tag/photography".  This page should contain a listing (similar to a search results page) for add-ons with a specific tag.

This bug involves the HTML/CSS/jQuery portion of this task.

Comment 1

[Mike Lee]

Hi Nick,

As visual designs are completed for this UI flow (or if you're able to
articulate what the flow should do & look like), please add them to this bug.
Thanks.

Comment 2

[Nick Nguyen [:osunick]]

Neil, can you attach the designs you have for tagging (or link the bugs where you have them)?

Comment 3

[Neil Lee [:neilio]]

All of the tagging design-related files are on bug #488517.

Comment 4

[Mike Lee]

Thanks Neil. Do all of those images (tag icon & collections icon) exist already? If so, do you happen to know if they are in SVN or in the db? (Perhaps the second question is for Wil). Thanks!

Comment 5

[Wil Clouser [:clouserw]]

(In reply to comment #4)
> Thanks Neil. Do all of those images (tag icon & collections icon) exist
> already? If so, do you happen to know if they are in SVN or in the db? (Perhaps
> the second question is for Wil). Thanks!

The small tag and collection icons are in /site/app/webroot/img/amo2009/icons/icons.png

Comment 6

[Neil Lee [:neilio]]

As Wil said, as far as I know all of the image assets should be available already, but let me know if you're missing something.

Comment 7

[Andrew Wooldridge]

So does this page look like like a SRP only there's a single tag on the left?

Comment 8

[Mike Lee]

Yes. Except where it says, "Showing 1-10 of 401 results for bookmark manager",
perhaps it can say, "Showing 1-10 of 401 results for tag name".

So perhaps this bug is really a duplicate of:
https://bugzilla.mozilla.org/show_bug.cgi?id=496659

Comment 9

[Neil Lee [:neilio]]

Mike is exactly right - the search subheading should change to say something along the lines of "Showing 1-10 of 401 items tagged with ##tag name##".

Sorry for not making this clear - it's something we discussed but it wasn't added to the wireframes or mock.

Comment 10

[Mike Lee]

Oops - quick correction: this Tag Page is the same as the SERP page, but without the Refine Results (as said earlier in this bug) and without the "Search Results
Showing 1-10 of 401 results..." at the top.

Comment 11

[Mike Lee]

FYI: the bug for the SERP UI is bug 496657. Both of these pages (Tags page & SERP page) will have a very similar UI. Both bug owners should coordinate with each other on these pages. And if someone is further along than the other, you can take on the corresponding bug too :)

Comment 12

[Mike Lee]

Would help if I put in the correct SERP UI bug, huh? bug 496659

Comment 13

[Andrew Wooldridge]

Given that this page is just a derivation of the other one, and there really should be just one owner since the code is the same, I'm sending this over to Mark.

Comment 14

[Mike Lee]

ETA: possibly tomorrow. Yem and Mark looking into this now.

Comment 15

[Mike Lee]

Work in progress. Aiming to complete it tomorrow.

Comment 16

[Mike Lee]

ETA moved to EOD Monday.

Comment 18

[Wil Clouser [:clouserw]]

(In reply to comment #16)
> ETA moved to EOD Monday.

Status?

Comment 19

[Mark Wunsch]

Has the same issues as bug 496659 -- needs to be localized

Comment 20

[Mike Lee]

Notes from Mark:

I resolved my bugs involving SERP so unless something mysterious appears I'm trying to focus in on Tag Pages, which have caused me endless head scratching. I'm spinning my wheels about it.

Originally, since the UI for SERP and Tag pages were so similar, it made sense to not repeat the code and instead to make a route
amo/tag/tag_name => amo/search?tag=tag_name

But I ran into a bunch of obstacles with this approach. After talking it over, it makes more sense to do this the proper way (even if some code will be repeated) by creating this functionality in the Tag controller.

I'd like to have this knocked out at the very latest by eod tomorrow night.

Comment 21

[Mark Wunsch]

Attachment: The UI for the Tag Page

This is how I designed the Tag Page to look like -- like the old-style SERP.

Comment 22

[Mark Wunsch]

Attachment: New file for the Tag Page view

This is the new file for the VIEW for the display action of the tag controller (see bug 496655). Should go in app/views/tags/display.thtml.

Comment 23

[Wil Clouser [:clouserw]]

I committed the page so we can test the other bugs but I'm reopening as this page is the old style.  

At a minimum it should have the applications and the "sort by" dropdown at the top of it.

Comment 24

[Mark Wunsch]

Alright -- should there be a "Refine Results" similar to SERP as well? I'll work on this and work on some patches tonight.

Comment 25

[Nick Nguyen [:osunick]]

Nope- no need for a refine UI- otherwise it might be too similar to a SERP.

Comment 26

[Wil Clouser [:clouserw]]

You're probably already on it, but just so I don't forget: the title of the page needs to reflect the tag also

Comment 27

[Mark Wunsch]

Attachment: Tag Page revisions: App selector and Sort

The app selector is now available, and you can sort the results. Default Sort is by popularity of addon.
Also the title of the page is "tag_name :: Add-ons for Firefox"

Comment 28

[Wil Clouser [:clouserw]]

r29335