496659 - Search Results Page: UI

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Mike Lee]

After AMO search has been revised to include tags, the search results page
(SERP) will need to be modified.

This bug involves:
+ CakePHP code
+ unit tests via Simpletest

Comment 1

[Nick Nguyen [:osunick]]

added blocking bug for search results design

Comment 2

[Nick Nguyen [:osunick]]

New design for SERP:

https://bugzilla.mozilla.org/attachment.cgi?id=381541

Comment 3

[Mike Lee]

FYI: For the Advanced Options panel, add a checkbox that limits the search to tags. Perhaps this could be the UI (added below the Sort By option):

"Search Tags Only []"

Comment 4

[Mike Lee]

FYI: The text for the "Showing 1-10 of XXX items..." text should read:

Showing 1-10 of 401 items tagged with ##tag name##

Comment 5

[Mike Lee]

FYI: the bug for the Tag Page UI is bug 496657. Both of these pages (Tags page & SERP page) will have a very similar UI. Both bug owners should coordinate with each other on these pages. And if someone is further along than the other, you can take on the corresponding bug too :)

Comment 6

[Mike Lee]

ETA: possibly tomorrow. Yem and Mark looking into this now.

Comment 7

[Mike Lee]

Work in progress. Aiming to complete it tomorrow.

Comment 8

[Mike Lee]

ETA moved to EOD Monday.

Comment 9

[Mark Wunsch]

Attachment: SERP UI Patch for tagging

This patch also addresses Bugs 501175 and 501182

Comment 10

[Wil Clouser [:clouserw]]

This patch contains unlocalizable strings, see also bug 501284.  Otherwise works as expected.

Comment 11

[Mark Wunsch]

Attachment: Patch for Bugs 501284 and 501146

Comment 12

[Wil Clouser [:clouserw]]

Comment on attachment 386152 [details] [diff] [review]
Patch for Bugs 501284 and 501146

This patch uses the wrong format, concatenates l10n, doesn't include all the strings, and introduces a bug that was fixed (s/lver/app_version).  I don't want to reopen this bug again so I just rewrote the patch in r29161.