497696 - Menus don't close when repeatedly firing menu shortcuts / mouse clicks on them in really short intervals

Status: NEW

(Core :: XUL, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: screenshot

Running a Mozmill test like the following lines will open the Tool, Bookmarks, History, and View menus. None of the first 3 menus will close when the next one gets opened. Inserting sleep intervals in between the steps let only the first and last menu appear. Menus opened in-between aren't visible.

var setupModule = function(module) {
  module.controller = mozmill.getBrowserController();
}

var testFoo = function(){
  controller.keypress(null, 't', {altKey: true});
  controller.keypress(null, 'b', {altKey: true});
  controller.keypress(null, 's', {altKey: true});
  controller.keypress(null, 'v', {altKey: true});
}

keypress uses the synthesizeKey method from EventUtils.js to fire the event on the active window.

Comment 1

[Neil Deakin]

Menus are opened asynchronously so you're not waiting for one menu to open before the next one. Also, pressing Alt+Key while a menu is open shouldn't open the other one anyway.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Neil, the above script sends key events in a very fast manner to the window itself. Why it should not open other menus? I can only see this when the alt key is halted but it is not the case with the above code. Between the calls the alt key is released so a new menu appears.

A probably similar behavior was reported in bug 497883 where the user is able to show multiple menus while moving the mouse very fast over the menubar.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: screenshot with search bar popup

It looks like we don't forget about former key or mouse events and open all those menus. Right now it happened to me while running L10n spotchecks on XP inside a VM. The system hung for a moment but I was clicking on different items in the menubar and the drop down inside the search bar. All of those popups are open now.

Comment 5

[martinez.pr0team]

It's the same bug I've reported (duplicated). I can reproduce it on both Winstripe Modern 3.2 and Default Theme so I think it's theme-independent.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #1)
> Menus are opened asynchronously so you're not waiting for one menu to open
> before the next one. Also, pressing Alt+Key while a menu is open shouldn't open
> the other one anyway.

Neil, more and more users reporting this behavior by normal user actions. It's really not a problem of our Mozmill test and looks to be laying deeper in the widget code?

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I sometimes have this problem without mozmill at startup. I start up the application, do something that eats a lot of CPU (i.e switching to the lightning tab) and then Press Alt+T+E (for the error console). The result is sometimes that the tools and edit menus are open.

Comment 9

[Mikeal Rogers [:mikeal] (mrogers@)]

Could the fix for this be similar to Clint's other sleep(0) thing?

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #9)
> Could the fix for this be similar to Clint's other sleep(0) thing?

For Mozmill it is. I have tested it yesterday and it works perfectly.

For the real world problem I wonder how that exists. Looks like the system has to be really under pressure and will be not able to propagate the click/press to the widget before the next click/press happens?

Comment 13

[Daniel Holbert [:dholbert]]

Attachment: screenshot of "File" & "View" menus open

(In reply to comment #1)
> Also, pressing Alt+Key while a menu is open shouldn't open
> the other one anyway.

It does for me (actually without needing to press 'alt' for the second key), if a large page is loading.  Here's what I do:
 - Load http://planet.ubuntu.com/ (or Shift+Reload, if it's already up)
 - As soon as page content starts appearing, quickly hit "Alt+f" and then "v"

About half of the time, this takes me to print-preView (expected), and half of the time it opens File & View simultaneously.  Screenshot attached.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a4pre) Gecko/20100406 Minefield/3.7a4pre

Comment 15

[Daniel Holbert [:dholbert]]

(Setting branch to "Trunk" since this still affects trunk builds)

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 5 duplicates.
:enndeakin, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 17

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.