501426 - make the open tabs in background pref be named mail.tabs.loadInBackground and allow overriding default for context/middle click with the shift key

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, enhancement)

Description

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

+++ This bug was initially created as a clone of Bug #480632 +++

Even though the pref to open tabs in background doesn't affect double clicking I really think it should be named like the firefox one.

Besides, it's now named mail.contextMenuBackgroundTabs but also affects middle click. mail.tabs.loadInBackground seems like a better name.

This patch changes that, and also allows the user to override default for context/middle click with the shift key. (Like firefox does.)

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 386065 [details] [diff] [review]
proposed fix

Patch is good by me, but clarkbw's input is still required.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 386065 [details] [diff] [review]
proposed fix

sure

Comment 3

[Magnus Melin [:mkmelin]]

changeset:   3015:c6f51d0b3261
http://hg.mozilla.org/comm-central/rev/c6f51d0b3261

->FIXED

Comment 4

[Thomas D. (:thomas8)]

Is there any documentation about this??
How does it work?
And why does the pref not affect double-clicking?

See bug 701500.

Comment 5

[Magnus Melin [:mkmelin]]

If you set mail.tabs.loadInBackground false tabs are loaded in the foreground by default. Holding shift while clicking lets you do the opposite as the pref, on a per click basis.

Re double-click, it's just designed that way - see bug 480632 comment 11.

Comment 6

[Thomas D. (:thomas8)]

(In reply to Magnus Melin from comment #5)
> If you set mail.tabs.loadInBackground false tabs are loaded in the
> foreground by default. Holding shift while clicking lets you do the opposite
> as the pref, on a per click basis.

Well, "by default" is not really true given that all the magic only works from context menu or middle click, but not for Enter, double-click, message menu Open, or Ctrl+O.

> Re double-click, it's just designed that way - see bug 480632 comment 11.

I'll have to let that sink in, play with it and think a bit more before commenting, but my immediate impression about this pref and its context-menu-limited experience is *confusion*!

Besides, Shift on context menu is undocumented in (1) and (2), and middleclick should be documented in (1).

(1) https://support.mozillamessaging.com/en-US/kb/keyboard-shortcuts
(2) https://support.mozillamessaging.com/en-US/kb/message-tabs?s=open+messages+in+background&as=s