Closed Bug 501426 Opened 12 years ago Closed 12 years ago

make the open tabs in background pref be named mail.tabs.loadInBackground and allow overriding default for context/middle click with the shift key

Categories

(Thunderbird :: Toolbars and Tabs, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: mkmelin, Assigned: mkmelin)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch proposed fixSplinter Review
+++ This bug was initially created as a clone of Bug #480632 +++

Even though the pref to open tabs in background doesn't affect double clicking I really think it should be named like the firefox one.

Besides, it's now named mail.contextMenuBackgroundTabs but also affects middle click. mail.tabs.loadInBackground seems like a better name.

This patch changes that, and also allows the user to override default for context/middle click with the shift key. (Like firefox does.)
Attachment #386065 - Flags: ui-review?(clarkbw)
Attachment #386065 - Flags: review?(bugmail)
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 3.0b3
Comment on attachment 386065 [details] [diff] [review]
proposed fix

Patch is good by me, but clarkbw's input is still required.
Attachment #386065 - Flags: review?(bugmail) → review+
Comment on attachment 386065 [details] [diff] [review]
proposed fix

sure
Attachment #386065 - Flags: ui-review?(clarkbw) → ui-review+
changeset:   3015:c6f51d0b3261
http://hg.mozilla.org/comm-central/rev/c6f51d0b3261

->FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Is there any documentation about this??
How does it work?
And why does the pref not affect double-clicking?

See bug 701500.
Depends on: 701500
If you set mail.tabs.loadInBackground false tabs are loaded in the foreground by default. Holding shift while clicking lets you do the opposite as the pref, on a per click basis.

Re double-click, it's just designed that way - see bug 480632 comment 11.
(In reply to Magnus Melin from comment #5)
> If you set mail.tabs.loadInBackground false tabs are loaded in the
> foreground by default. Holding shift while clicking lets you do the opposite
> as the pref, on a per click basis.

Well, "by default" is not really true given that all the magic only works from context menu or middle click, but not for Enter, double-click, message menu Open, or Ctrl+O.

> Re double-click, it's just designed that way - see bug 480632 comment 11.

I'll have to let that sink in, play with it and think a bit more before commenting, but my immediate impression about this pref and its context-menu-limited experience is *confusion*!

Besides, Shift on context menu is undocumented in (1) and (2), and middleclick should be documented in (1).

(1) https://support.mozillamessaging.com/en-US/kb/keyboard-shortcuts
(2) https://support.mozillamessaging.com/en-US/kb/message-tabs?s=open+messages+in+background&as=s
You need to log in before you can comment on or make changes to this bug.