503312 - selected message in the message list doesn't show as blue when it has keyboard focus

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Jason Merrill]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1) Gecko/20090630 Fedora/3.5-1.fc11 Firefox/3.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.1pre) Gecko/20090708 Shredder/3.0b3pre

In 3.0b2, the currently selected message in the message list is highlighted in blue when it has keyboard focus.  In 20090707 and 0708 Shredder, this is still true in the folder list, but not in the message list.

(Possibly related is that sometimes keyboard focus gets lost; for a while, hitting F8 to open or close the message pane would cause keyboard focus to go somewhere mysterious, so that I had to hit Tab to get it somewhere I could see.  After F8 to close the message pane, even the menu shortcuts (Alt-H, etc) didn't work until I hit Tab to move the keyboard focus.  But I haven't figured out how to reproduce this yet; it's working fine just at the moment.)


Reproducible: Always

Comment 1

[Ludovic Hirlimann [:Usul]]

this is wfm on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2pre) Gecko/20090729 Shredder/3.0b4pre.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #1)
> this is wfm on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
> rv:1.9.1.2pre) Gecko/20090729 Shredder/3.0b4pre.

WFM too.

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #2)
> (In reply to comment #1)
> > this is wfm on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
> > rv:1.9.1.2pre) Gecko/20090729 Shredder/3.0b4pre.
> 
> WFM too.

That was on Mac, and also WFM on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.1) Gecko/20090715 Thunderbird/3.0b3

Reporter, retest with Beta 3? http://www.mozillamessaging.com/en-US/thunderbird/early_releases/

Comment 4

[Jason Merrill]

Still doesn't work for me with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.2pre) Gecko/20090729 Shredder/3.0b4pre, or with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.1) Gecko/20090721 Fedora/3.0-2.5.b3.fc11 Thunderbird/3.0b3.

It still worked properly with the Fedora 3.0b2 package until I replaced it with b3.

I also have thunderbird built from source, any suggestions about where I might start trying to debug this?

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I was on Ubuntu GTK - I wonder if this might be a factor - though afaik Fedora also uses GNOME.

How about a screenshot or two for a start?

Comment 6

[Jason Merrill]

Attachment: screenshot of keyboard focus in gray

Comment 7

[Magnus Melin [:mkmelin]]

I've also seen the gray, but not with my current theme, so i suspect it's due to the native theme. 

As for what you're looking for, see bug 483761 comment 20 and the changes made by that bug.

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

i'm seeing this and getting other reports as well

Comment 10

[Delphine Ménard]

(In reply to comment #9)
> *** Bug 508236 has been marked as a duplicate of this bug. ***

Just want to point out that the problem as described in Bug 508236 is "blocking", as selected rows display white font on white background. (see screenshots in Bug 508236)

Comment 11

[Renato S. Yamane]

Just to remember: Bug 508236 is related with KDE 3.5 (Debian Lenny).

Thunderbird 3Beta3 default theme, and any combination of KDE 3.5
color scheme.

Not happening on Thunderbird 2 or 3Beta2.

Comment 12

[Renato S. Yamane]

Attachment: [Bug 508236] Selected rows display white font and white background

Selected rows display white font on white background, so, all fields is hidden.
This bug happening on KDE 3.5

Comment 13

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: separates out the focus and selection selector giving each a color choice [Checkin: Comment 18]

I've been running with this patch for a while and I think it's correct.  It really would have been sweet if I put this up before so we could get some testing in the nightlies; but with my time machine in the shop and all this is the best I can do at present.  Anyway I'd love for some testing of this patch if people have a chance.

The only issue I've seen so far is that certain themes give the cellhighlight and css highlight very similar colors such that they aren't really distinguishable from each other.  I don't think there's much I can do about that.

Comment 14

[Bryan Clark (DevTools PM) [:clarkbw]]

I don't think this will block but we want to get it in for TB3

Comment 15

[Renato S. Yamane]

I really apreciate if someone apply this patch and make available to me :-)
And... IMHO, this bug will block TB3.

Comment 16

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 400146 [details] [diff] [review]
separates out the focus and selection selector giving each a color choice
[Checkin: Comment 18]

magnus, do you have a chance to look at this?

Comment 17

[Magnus Melin [:mkmelin]]

Comment on attachment 400146 [details] [diff] [review]
separates out the focus and selection selector giving each a color choice
[Checkin: Comment 18]

Looks good to me

Comment 18

[Serge Gautherie (:sgautherie)]

Comment on attachment 400146 [details] [diff] [review]
separates out the focus and selection selector giving each a color choice
[Checkin: Comment 18]


http://hg.mozilla.org/comm-central/rev/490357d5177c

Comment 19

[Renato S. Yamane]

This bug still happening on Thunderbird 3B4

Comment 20

[Mark Banner (:standard8)]

(In reply to comment #19)
> This bug still happening on Thunderbird 3B4

That is because it was only fixed after beta 4.