50523 - Update Name of null plugin

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Henrik Gemal]

When right-clicing on the NPNUL32.DLL file in the plugins directory you can get 
the see in the Version tab that the file says it's copyrighted by Netscape, 
1997, etc...

This should be updated to say something about Mozilla instead!

The code for the copyright stuff:
http://lxr.mozilla.org/mozilla/source/modules/plugin/default/windows/npnul32.rc#
76

Comment 1

[Braden]

The file name ought to be changed as well ("np" obviously stands for "Netscape
plugin", when what we really mean is "Mozilla plugin"), but that probably
deserves a different bug report.

This might not *quite* be an API issue, but it's close enough. Making a blocker
for bug 35548.

Comment 2

[Ben Bucksch (:BenB)]

bradne, do you have an CVS account? If yes, just fix it right away.

Comment 3

[Ben Bucksch (:BenB)]

Taking bug.

Comment 4

[Ben Bucksch (:BenB)]

Attachment: Fix, version 1

Comment 5

[Ben Bucksch (:BenB)]

av, please review <http://www.bucksch.org/1/projects/mozilla/review.html>. The
Win32 change is untested - I have no Win32 build environment. Please test it,
including <about:plugins> and the DLL info.

Comment 6

[av (gone)]

Changes look OK to me. I applied it on Windows, and everything works fine. a=av

Comment 7

[Ben Bucksch (:BenB)]

av, who should give a review?

Comment 8

[av (gone)]

I think to get the fix in you should escalate the bug and get rtm+ status in the 
Whiteboard, then send it to the team of reviewers as described on the top of the 
tinderbox page.

Nominating for rtm.

Comment 9

[Ben Bucksch (:BenB)]

*** Bug 55790 has been marked as a duplicate of this bug. ***

Comment 10

[timeless]

Erm, we're in the process of rewriting the plugin to be XPCOM instead of n4.x, 
I'll make sure that it doesn't say netscape assuming we've decided to rename 
the plugin "Mozilla Default Plugin" or would we prefer for the plugin to be 
polymorphic "&Branding; Default Plugin" [i'm not sure of the correct entity but 
you get the point].

Marking [remind] because i'll need to check on this when an xpcom null plugin 
lands.

Comment 11

[Ben Bucksch (:BenB)]

ETA?

Comment 12

[ekrock's old account (dead)]

Andrei, please make sure you don't spend more than five minutes on this bug. We
have numerous outstanding plug-in bugs that actually cause user-visible failures
(crashes, PDT forms not submitting, RealPlayer not working, QuickTime failing to
display) so we absolutely can't afford to be spending your time on this bug
until we're certain that all these other bugs that actually harm users will get
fixed for RTM. (We could live with the erroneous copyright issue for RTM;
Netscape won't enforce a copyright notice that was asserted by accident and it
could be fixed after RTM. Sounds like you'll fix that during the XPCOM rewrite
anyway though. BTW, what's the motivation for the XPCOM rewrite at this point?)
Many thanks to all who are working on this bug; if you can reassign the bug to
yourself and handle the check-in for Andrei, many thanks!

Comment 13

[Ben Bucksch (:BenB)]

ops, I thought, it were assigned to me. Taking bug again.

timeless doesn't know when he'll get to rewrite the backend. It surely might be
a good idea, because the old one is Netscape-centristic (unsurprisingly).
Anyway, we should get this in before mozilla0.9.

ekrock, Netscape might be in hot times, but it also has responsibilities towards
mozilla.org. There are distributions other than Netscape 6, and the world
doesn't stop while Netscape is busy. But I think, av's part in this bug is done.

Comment 14

[Scott Collins]

These changes seem reasonable; av built on Windows ... so, sr=scc.

Comment 15

[Ben Bucksch (:BenB)]

scc, I now have a=av and sr=scc collected. Do I need an r=?

Comment 16

[Scott Collins]

As I understand it, no.  Since av has super-review powers for this module, and I
have super-review powers in general, you can count either one of as the reviewer
and the other as the super-reviewer.  One review + one super-review is enough
for an external contributor to check into the trunk (normal open-and-green rules
still apply, of course).

Comment 17

[Ben Bucksch (:BenB)]

Checked in.

Comment 18

[Henrik Gemal]

Verified.
The plugin properties now says mozilla.org as company name, etc....

Comment 19

[Ben Bucksch (:BenB)]

Please verify for Linux and Windows. The changes are not XP.

Comment 20

[Ben Bucksch (:BenB)]

.

Comment 21

[shrirang khanzode]

verified on windows trunk 1128. I looked in the properties menu option for the 
null plugin on linux but there is no specific name mentioned. Looks ok..unless I 
missed something.Marking VERIFIED.