50767 - multi selection of folders in folderpane should work

Status: RESOLVED DUPLICATE of bug 1600103

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[vijayalakshmi]

From Bugzilla Helper:
User-Agent: Mozilla/4.61 [en] (OS/2; I)
BuildID:    20000726hs

while working on US Merlin with base fix pac 14,unable to select two folders at 
a time , so it is blocking deletion of 2 folders in mail window of mozilla.

Reproducible: Always
Steps to Reproduce:
tried again & again					

Actual Results:  unable to get the result

Expected Results:  select & then delete the selected folders

Comment 1

[Mike Kaply [:mkaply]]

Did you test this on a Windows build as well?

This function does not appear to work on Windows either.

Comment 2

[lchiang]

Yes, for this particular bug, it's also in the Windows platform.  User is unable
to multi-select in the thread pane.

Workaround: select one folder at a time to delete.

Comment 3

[Jean-Francois Ducarroz]

reassogn to putterman

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 66765 has been marked as a duplicate of this bug. ***

Comment 5

[Håkan Waara]

This is something that imho should be done prior to Mozilla 1.0 if possible. 
For example, being able to select multiple folders and delete them, compact 
them, or unsubscribe from more than one newsgroup at once is a useful 4xp 
feature.

Putterman?

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

We get this for free, with outliner - in fact, we have a workaround to stop
<outliner> from multiple selection in the folder pane.  

Comment 7

[Gilbert Fang]

Does this bug means user can select multiple folders at one time and do some
actions on them at one time ?

"while working on US Merlin with base fix pac 14,unable to select two folders at 
a time , so it is blocking deletion of 2 folders in mail window of mozilla."
Does it mean blocking deletion of 2 folders <b>at one time</b>?

At least, user can delete one folder at one time?

Comment 8

[Jay Smith]

"Lack of feature" still present on Mozilla 1.2 Mozilla/5.0 (X11; U; Linux i686;
en-US; rv:1.2) Gecko/20021202.

I used to use this feature to select multiple folders to "Compact Folders".
Since we have hundreds of folders, this is handy.

Comment 9

[WD]

*** Bug 223827 has been marked as a duplicate of this bug. ***

Comment 10

[Wayne Mery (:wsmwk)]

not major

Comment 11

[Lewis Rosenthal]

(In reply to comment #10)
> not major
> 

That sounds a bit dismissive, Wayne, if I do say so myself. No offense intended, but there are folks (like yours truly) who literally have hundreds of folders, and find a need from time to time (more than a few times per year) to perform operations on multiple folders. I should have voted for it ages ago.

Lewis

Comment 12

[Wayne Mery (:wsmwk)]

Not saying at all that the issue isn't major. I'd like to see it myself for me and my organization.

But my reading of the bug is this never existed in the new code base (though it I guess it existed in Netscape?), i.e. is not something that broke.  If I have interpreted the history incorrectly or the correct assignment please someone modify the bug.

Anyway, after being in a deep sink hole here for 5 years, it may get greater attention now as an enhancement request!  Someone needs to hook it up with a developer.

Comment 13

[Lewis Rosenthal]

(In reply to comment #12)

> Anyway, after being in a deep sink hole here for 5 years, it may get greater
> attention now as an enhancement request!  Someone needs to hook it up with a
> developer.
> 
Yes, it was indeed present in Communicator 4.x, and I hung on for dear life to 4.61... ;-)

I do see your point, however. Comment #6 seems to imply that this capability was/is possible, and is simply disabled for some reason (though I am not familiar with the outliner component mentioned in that comment - is it still in the code?). If the capability isn't in there, then an RFE is what is required. Is it possible for someone to change this bug to an RFE?

Lewis

Comment 14

[Lewis Rosenthal]

Never mind. I see you did change the severity, Wayne. Sorry for the bug spam, everyone...

Lewis

Comment 15

[Håkan Waara]

See bug 296655 for thunderbird (this is suite).

Comment 16

[Magnus Melin [:mkmelin]]

Multi-folder selection has been possible for a while now. [Teaking summary]
(For tb, doing something sensible with the multi-selection was bug 296655)

Comment 17

[Lewis Rosenthal]

Interesting, Magnus, as this doesn't work for me, even in Classic theme (SM 1.1.16 on OS/2). I am unable to Ctrl-LMB in the folder pane to select either multiple virtual folders or multiple folders (Ctrl-LMB *does* work for multiple selection of items in the message list pane). FWIW, Shift-LMB doesn't work to select a range in the folder pane, either.

I'm not near a Linux or Win box to test on those platforms, but I'll have a look at my next opportunity.

Comment 18

[Magnus Melin [:mkmelin]]

Pretty sure you'd want an seamonkey2 beta (or tb3 beta) to see it though.

Comment 20

[Jens Hatlak (:InvisibleSmiley)]

Bug 496543 should be ported in addition to (the applicable parts of) bug 296655.

Comment 22

[Jens Hatlak (:InvisibleSmiley)]

Attachment: disabling patch

In case this bug is not fixed for 2.0 I'm attaching a patch that disables both New Folder and Properties/Settings to reflect reality. I'll only request review once either a real fix would be too late for 2.0 or such a fix is not approved for that release.

That said, fixing this bug will include string changes so needs to be fixed before the 2.0 string freeze. It also has a light dependency on the JS-driven folder pane that is yet to be ported to SM (maybe not in time for 2.0), i.e. it's probably easier to port after the JS-driven folder pane has been ported but it should also be possible to do without (e.g. with GetSelectedMsgFolders() instead of gFolderTreeView.getSelectedFolders()).

Comment 23

[[e-mail]]

Are there actually any menuitems that work with a multiple selection?

Comment 24

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #23)
> Are there actually any menuitems that work with a multiple selection?

Not yet (not even delete using the Del key), that's what this bug is all about. If you suggest to solve this another way then I'd like to remind you that this is only meant to be a temporary fix for the 2.0 line, it will be removed afterwards anyway. Still I'd like to have it since it's an easy/obvious fix and prevents people from expecting something to happen (other than the JS error that is thrown when using Properties on multiple folders ;-)).

Comment 25

[[e-mail]]

So you're suggesting that showing a context menu with a disabled item is better than not showing one at all, say?

Comment 26

[Jens Hatlak (:InvisibleSmiley)]

Attachment: disabling patch v2 [Checkin: comment #29]

(In reply to comment #25)
> So you're suggesting that showing a context menu with a disabled item is better
> than not showing one at all, say?

No. There are no disabled items with my first patch. There is a very tiny box (like 2x2-5x5 pixels) on Windows, though; maybe it's not there on Linux or I didn't notice first. The new patch should fit better (note: I don't know if the exiting numSelected check was handling a null case as well so I kept it as part of the new one).

Comment 27

[[e-mail]]

(In reply to comment #26)
> (In reply to comment #25)
> > So you're suggesting that showing a context menu with a disabled item is better
> > than not showing one at all, say?
> No. There are no disabled items with my first patch. There is a very tiny box
> (like 2x2-5x5 pixels) on Windows
Ah yes, a context menu with no items is no good at all ;-)

Comment 28

[Karsten Düsterloh]

Comment on attachment 404852 [details] [diff] [review]
disabling patch v2 [Checkin: comment #29]

>+  if (!numSelected || numSelected != 1)
>     return false;

The !numSelected is superfluous, and you need to change the line for the real fix anyway.
And even the null value is != 1... ;-)

r/moa/a=me with that.

Comment 29

[Karsten Düsterloh]

Comment on attachment 404852 [details] [diff] [review]
disabling patch v2 [Checkin: comment #29]

Pushed as <http://hg.mozilla.org/comm-central/rev/12caebd92935> without the !numSelected bit.
Leaving bug open for the Real Fix™.

Comment 30

[Robert Kaiser]

Hrm, now this patch shows up in the watcher queue for "approved for 2.0 but not fixed-seamonkey2.0" :(
I'm not sure what to do about it, but it disturbs the radar...

Comment 31

[[e-mail]]

(In reply to comment #30)
> Hrm, now this patch shows up in the watcher queue for "approved for 2.0 but not
> fixed-seamonkey2.0" :(
> I'm not sure what to do about it, but it disturbs the radar...
It's clear to me. The bug is not RESOLVED FIXED, because it's not really fixed. But we have a workaround in place for seamonkey 2.0, so it's fixed-seamonkey2.0

Comment 32

[Frank-Rainer Grahl (:frg)]

Bug 1600103 enabled applying actions to multiple folders. If there are remaining issues they should go into a new bug.