509268 - Attachment icon is big compared to the other elements

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Andreas Nilsson (:andreasn)]

In the beta3 feedback, one of the points that came up is that the attachment icon is big compared to the other elements in the message list.
We should look into having a smaller one. Either the same size as the header icon, or something in between that and the current one.

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: [checked in] patch for gnomestripe

Using the same size as the header image.
Not sure if this makes it _too_ small or not.

Comment 2

[Andreas Nilsson (:andreasn)]

Attachment: patch for qute

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

If I remember correctly we used the attachment.png for the attachment reminder so it would be good to keep around a size that continues to work for that.  It could be as a new image, attachment-reminder.png

Comment 4

[Andreas Nilsson (:andreasn)]

(In reply to comment #3)
> If I remember correctly we used the attachment.png for the attachment reminder

As far as I can see, the attachment reminder uses the graphics from the compose toolbar.

/mail/themes/gnomestripe/mail/compose/messengercompose.css, line 229:

#attachmentNotificationBox > notification .messageImage {
  width: 22px;
  height: 22px;
  background-image: url(chrome://messenger/skin/messengercompose/compose-toolbar.png);
  background-position: left -66px;
}

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

oh right,  my bad

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

don't forget to put these up for review

Comment 7

[Decathlon]

What about to do the same thing for other icons in the message list? In my opinion smaller icons (those ones of column header) for starred and, in particular, for junk status would be better.

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 395303 [details] [diff] [review]
patch for qute

just tested this out and it looks good to me.

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 395302 [details] [diff] [review]
[checked in] patch for gnomestripe

looks good to me.  I'll switch the code review over to magnus, we gave philor a bunch of windows bugs already

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 395302 [details] [diff] [review]
[checked in] patch for gnomestripe

Quite nice indeed! r=mkmelin

Comment 11

[rsx11m]

Does this need another review for attachment 395303 [details] [diff] [review] or is it ready
for a "checkin-needed" flag?

(In reply to comment #7)
> What about to do the same thing for other icons in the message list? In my
> opinion smaller icons (those ones of column header) for starred and, in
> particular, for junk status would be better.

You'd probably have to file new bugs for those if not yet present, this bug is about the attachment icon and is close to done.

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 395303 [details] [diff] [review]
patch for qute

As attachment.png is only "used" in searchDialog.css, it should also be removed completely, and the searchDialog.css ref updated. Not that the searchdialog currently has any attachment col, but we might add one i suppose...

Comment 13

[Mark Banner (:standard8)]

Comment on attachment 395302 [details] [diff] [review]
[checked in] patch for gnomestripe

Checked in: http://hg.mozilla.org/comm-central/rev/6e8d1b550421

Comment 14

[Andreas Nilsson (:andreasn)]

Attachment: updated qute patch

Comment 15

[Magnus Melin [:mkmelin]]

Comment on attachment 401203 [details] [diff] [review]
updated qute patch

Does this build?
attachment.png is still there in mail/themes/qute/jar.mn

Comment 16

[Magnus Melin [:mkmelin]]

Comment on attachment 401203 [details] [diff] [review]
updated qute patch

Minusing as i expect the answer is no

Comment 17

[Andreas Nilsson (:andreasn)]

Attachment: updated patch

hopefully this one works better!

Comment 18

[Magnus Melin [:mkmelin]]

Comment on attachment 402820 [details] [diff] [review]
updated patch

a-tb3=mkmelin as well

Comment 19

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/af8d52631eb5

Optimistically closing, since Pinstripe looks fine to me, and I really really like bugs that only get one checkin, rather than multiples across multiple milestones.