515390 - Polish for autoconfig dialog

Status: RESOLVED INVALID

(Thunderbird :: General, defect)

Description

[Andreas Nilsson (:andreasn)]

we need some css polish for the autoconfig after things land in trunk.

Some things from the top of my head (will file individual bugs):

all:
* make the inactive entrys look like labels instead of textboxes
* Specific graphics for all three platforms

gnomestripe:
* background color needs to be -moz-appearance: window;
* align config_status_title to the border of the left of the vbox, aligning it to the graphics.

Comment 1

[Vlado Valastiak [:wladow]]

Attachment: need to align boxes correctly

Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9.1.4pre) Gecko/20090910 Shredder/3.0b4pre

Another thing to polish

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Well dang!  I tested on Windows XP, Ubuntu, and Mac OS X.  Are you running Vista or Windows 7, perhaps?

Thanks,
Blake.

Comment 3

[Andreas Nilsson (:andreasn)]

(In reply to comment #2)
> Well dang!  I tested on Windows XP, Ubuntu, and Mac OS X.  Are you running
> Vista or Windows 7, perhaps?

I didn't get this on my Vista machine. I think it's due to the locale taking up more space than the English translation, but yes, we should probably figure this out somehow.

Comment 4

[Jim Porter (:squib)]

One other thing to note in that screenshot is that the disabled button is a different size (and appears to use a different font) than the enabled button. I've seen this in XP too, and it's probably present in Linux, but it's less obvious there.

Comment 5

[Nomis101]

Attachment: misaligned input fields in german autoconfig

(In reply to comment #3)
> I didn't get this on my Vista machine. I think it's due to the locale taking up
> more space than the English translation, but yes, we should probably figure
> this out somehow.

Yes, this is a locale thing. I also see this in a german build, but not in the en-US from the same day.

Tested with
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; de; rv:1.9.1.5pre) Gecko/20091010 Shredder/3.0pre
and
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; de; rv:1.9.1.4pre) Gecko/20090915 Thunderbird/3.0b4

Comment 6

[Andreas Nilsson (:andreasn)]

Attachment: increased label width

This could partly solve the issue, however, this also mean we're risking to run out of space for the error messages on the right, especially considering German locales.

Going to try a table layout as well, that would mean that if one label gets wider, the other ones become equally wide.

Comment 8

[Andreas Nilsson (:andreasn)]

Attachment: patch using tables

Adding this here so I won't loose it. No idea why it doesn't work as a proper table and put things in rows. Will look into further.

Comment 9

[Vincent (caméléon)]

Attachment: Autoconfig dialog with colomn name

It would also look prettiest with column name for server parameters like:
- hostname
- port
- socket type

Comment 10

[Ben Bucksch (:BenB)]

Comment on attachment 407261 [details] [diff] [review]
increased label width

Don't use fixed size, it will break with locales who have even longer names. Also, will waste space for those locales with shorter names.
Instead, use different layout to work with any size. In particular, a <grid>.

Comment 11

[Ben Bucksch (:BenB)]

Comment on attachment 411434 [details] [diff] [review]
patch using tables

Use <grid>

(Patch is not going to work like that anyways, because table is in html XML namespace, not in XUL namespace).

Comment 12

[Ben Bucksch (:BenB)]

A good part of this is covered by bug 549045.
The top part with the email address input field is not covered there. But it should go in a new bug focused on that.

Comment 14

[rsx11m]

Is this still relevant/applicable after the bug 549045 redesign is in now?