515422 - Make sure the autoconfig window is usable with any OS theme colors

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Andreas Nilsson (:andreasn)]

Attachment: patch to fix the issue

the new autoconfig window currently use a blue tinted background color. Should make it use -moz-dialog instead.

Comment 1

[Andreas Nilsson (:andreasn)]

Comment on attachment 399507 [details] [diff] [review]
patch to fix the issue

Standard8 said this could go in b4 as long as I got a UI ok from Bryan.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 399507 [details] [diff] [review]
patch to fix the issue

yep

Comment 3

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of patch in action

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Awww, we've lost the beautiful grouping background rounded rectangles...  :(

(i.e. https://bug506290.bugzilla.mozilla.org/attachment.cgi?id=399339)

Would it make more sense to find a different color from https://developer.mozilla.org/en/CSS/color_value ?  Or to not set it at all, and see what happens?

Thanks,
Blake.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Attachment: Linux, Mac, and Windows, in that order.

"-moz-dialog" seems to be a nice enough color on all three platforms.
How about we use that?

Later,
Blake.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Wait, that's what you're using.  Man, I'm apparently too tired to be commenting on bugs.  Sorry about that.  Let me just close with "Do you want to make that change to all three platforms?"

Comment 7

[Phil Ringnalda (:philor)]

Ah, the joy of making near-freeze bug comments :)

What we want to do is what I should have done before reviewing: take a screenshot to see what should be visible, then switch Linux to High Contrast Inverse, and Windows to Classic, High Contrast Black (or whatever the Vista/7 equivalent is), since those are most likely to show pain, and see what's actually hidden by having a background but no color, or a color but no background, or one of them that assumes the other will be something it's not. From a quick glance, what's invisible looks like "nearly everything in gnomestripe, but not much in qute other than disabled menulists being rather white on white."

All/All is actually a bit broad: conveniently, since OS X doesn't really _do_ OS theming, it's actually just qute/gnomestripe that need worrying about.

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 399615 [details]
Linux, Mac, and Windows, in that order.

that windows shot looks horrible :(  everything else is ok.

Comment 9

[Phil Ringnalda (:philor)]

Attachment: Linux and Windows high contrast inverse

This is why I'm thinking blocker, and wanting more than just one background fixed - the particularly unsavory Linux image does actually have everything filled in, despite the way we're mocking people who need high contrast white on black by giving them white on white and white on blue-grey.

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

I'd agree this is blocking the TB3 release but I'd suggest a milestone of rc1 because I don't think we need to hold the b4 release on this.  Not to say we shouldn't aim to get patches in by Friday.

Comment 11

[Mark Banner (:standard8) (afk until 21st July)]

Agreed, it doesn't need to block b4 - wanted though, but we should sort it for rc1.

Comment 12

[Andreas Nilsson (:andreasn)]

Attachment: fixes for gnomestripe

This takes care of the HC issues on Linux. Will look into if these things can be shared across the themes or not, so not asking for review yet.

Comment 13

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of HighContrast and Clearlooks using the patch above

Comment 14

[Andreas Nilsson (:andreasn)]

Attachment: updated gnomestripe patch

Here is a updated patch for gnomestripe using -moz-appearance: -moz-dialog; instead of -moz-appearance: window;

Works great with HighContrast and other themes.

Comment 15

[Andreas Nilsson (:andreasn)]

Attachment: [checked in] first stab at the windows patch

this takes care of the background color issue. Still having issues with the inactive dropdowns, so those will come later.

Comment 16

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 400010 [details] [diff] [review]
updated gnomestripe patch

this looks fine.  I'm not sure philor is going to like your commenting approach to the CSS change.  Lets see how he's feeling :)

Comment 17

[Phil Ringnalda (:philor)]

Typo there - you got the word "not" too early, instead of in "is not going to like" :)

Comment 18

[Andreas Nilsson (:andreasn)]

Attachment: [checked in] patch without commented out stuff

Indeed, how ugly of me. Fixed!

Comment 19

[Phil Ringnalda (:philor)]

Comment on attachment 400144 [details] [diff] [review]
[checked in] patch without commented out stuff

V. nice.

Comment 20

[Mark Banner (:standard8) (afk until 21st July)]

Comment on attachment 400034 [details] [diff] [review]
[checked in] first stab at the windows patch

Checked in: http://hg.mozilla.org/comm-central/rev/fc63f7910dd2

Comment 21

[Mark Banner (:standard8) (afk until 21st July)]

Comment on attachment 400144 [details] [diff] [review]
[checked in] patch without commented out stuff

Checked in: http://hg.mozilla.org/comm-central/rev/0d54d4b5f11f

Comment 22

[Bryan Clark (DevTools PM) [:clarkbw]]

looks like the rest of the windows pieces will be handled by bug 517171

Comment 23

[Bryan Clark (DevTools PM) [:clarkbw]]

marking this fixed and setting bug 517171 as the blocker to handle the rest of the work