515479 - remove mail accounts from old account wizard for TB

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P3)

Description

[David :Bienvenu]

File | New | Other Accounts brings up the old account wizard, which includes items for mail account and two forms of gmail accounts (imap and pop3). I think we want to remove those items for TB to get rid of duplicate UI. 

If/when SM decides to use the new auto config stuff, then we could rip out a fair amount of the old wizard.

Comment 1

[David :Bienvenu]

I feel somewhat responsible for making sure this happens, so I'll take it :-)

Comment 2

[Simon Paquet [:sipaq]]

David, I guess as long as we don't remove all the code for the old account wizard, this bug does not have any l10n impact, right?

Comment 3

[David :Bienvenu]

no l10n impact, really, other than we'll be removing the use of a couple strings from TB but not SM. We can leave the strings in the TB .dtd or .properties files, or remove them, whatever's easier for l10n.

Comment 4

[Simon Paquet [:sipaq]]

Removing strings also counts as l10n impact :)

I would suggest that we either try to get to this before the final string freeze at the end of September or just remove the UI from TB3 and remove the strings in a followup bug once TB3 is on its own comm-1.9.1 branch.

Comment 5

[David :Bienvenu]

Attachment: possible fix

I need to try this on the mac, and have someone try it on linux to see that it does the right thing. It seems to do the right thing on Windows. In particular, I'm worried about movemail on linux (if that shows up at all today; I'm not sure. I don't see it on the mac).

I guess I need to worry a bit more about mail/installer/removed-files.in as well, to add the gmail and docmac rdf files.

Comment 6

[Phil Ringnalda (:philor)]

In theory, movemail still shows up on Linux, and you should be able to get it to show up on OS X by just copying movemail.rdf from src/mailnews/base/ispdata/movemail.rdf to Thunderbird.app/Contents/MacOS/isp/ (which is probably less trouble than seeing whether the extension I attached in bug 379705 still works).

Oh, and you should probably look at that attachment before trying to get anyone to use it, since it looks more like an hg stat than an hg (q)diff :)

Comment 7

[David :Bienvenu]

(In reply to comment #6)
> 
> Oh, and you should probably look at that attachment before trying to get anyone
> to use it, since it looks more like an hg stat than an hg (q)diff :)

Yes, the actual diff is left as an exercise for the reader :-)

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #7)
> (In reply to comment #6)
> > 
> > Oh, and you should probably look at that attachment before trying to get anyone
> > to use it, since it looks more like an hg stat than an hg (q)diff :)
> 
> Yes, the actual diff is left as an exercise for the reader :-)

ah, it's more of an abstract diff then.  I see some amazing code but bad commenting :-)

Comment 9

[David :Bienvenu]

Attachment: actual diff

Heh. So I really don't understand mail/installer/removed-files.in - it seems to already have isp/gmail.rdf, which is what I would have thought I would have added to remove gmail.rdf...

Comment 10

[Phil Ringnalda (:philor)]

No, isp/gmail.rdf is the old one from before we had isp/en-US/gmail.rdf and isp/de-DE/googlemail.rdf. You want to remove isp/ab_CD/(gmail|googlemail).rdf, and... good luck with that!

Comment 11

[David :Bienvenu]

ah, grazie!

Comment 12

[Thomas Bertels]

Keep in mind that this wizard can be called with the "New Account" button in the "Mail & Newsgroups Account Settings" window. http://www.mozilla.org/projects/security/pki/psm/smime_land_files/accountSettingSecuri.gif

I'm not sure how many peaople use "New > Mail Account" to create an account, but the other way is more likely what former Outlook (Express) users are going to use.

Maybe the "mail accounts" option from the old wizard should stay but call the new wizard ?

Comment 13

[Renato S. Yamane]

Only to let you know: I *never* use File --> New --> Mail Account to create an mail account.

I always use "Add account" button in the account settings dialog.

By this missing knowledge I create a bugreport, thinking that "autoconfig" is missing. Bug #518558

Comment 14

[Magnus Melin [:mkmelin]]

That button will have to go i think.

Comment 15

[Renato S. Yamane]

You wanna remove it?
I think that it is a bad idea.

If you remove it from me, I need go to Google ask "how to create a mail account in Thunderbird", because I always use this button (in account manager).

I never see, in the past, File --> New --> Mail account (I see it only TODAY).

Comment 16

[Magnus Melin [:mkmelin]]

Well we can hardly have two buttons there (for the different types).

Comment 17

[David :Bienvenu]

I think the idea is to have a drop down button like we have on the toolbar - new mail account by default, but with an option to add an other kind of account.

Comment 18

[David :Bienvenu]

I'm not sure it's worth enumerating all the possible localized gmail rdf files we should remove from 2.0 installations, since there's not much harm in leaving them there. Users with those localized builds would still see gmail as an option in the old account wizard, which isn't ideal, but not the end of the world either.

Comment 19

[David :Bienvenu]

Attachment: proposed fix

I ended up trying to add all the files we should remove from 2.0 installs. Eventually, someone has to clean up the locales to get rid of isps.txt, but I don't think that's required for this bug.

requesting sr from Neil to make sure this doesn't affect SM.

Comment 20

[[e-mail]]

Comment on attachment 403582 [details] [diff] [review]
proposed fix

I can believe that this won't affect SeaMonkey.

Comment 21

[Alfred Kayser]

Note, in the File/New menu there is a separator between Mail Account and Other Accounts. It would be more logical to move the separator below Other Accounts.

Also, when ripping the New Account Setup dialog, after removing Email account, and Gmail IMAP and Gmail POP (which are also no longer needed), only the Blogs&News Feeds and the Newsgroup Account remain. Better to move this two options to the File New menu, so that it becomes:
File->New->Mail Account
File->New->Blogs&News Feeds (Which doesn't really require a wizard)
File->New->Newsgroup Account

Comment 22

[David :Bienvenu]

pinging for review

Comment 23

[David :Bienvenu]

fix checked in.