Closed Bug 51597 Opened 26 years ago Closed 26 years ago

[meta] Accelerators the Browser Must Have

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P2)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: lake, Assigned: mcafee)

References

Details

(Keywords: meta, Whiteboard: [nsbeta3-][PDTP2][rtm++])

Attachments

(1 file)

These are the Accelerators that are Must Haves for the Browser of Netscape6. Additional Accelerators to be implimented post nsbeta3 will be addressed in another bug. Alt - Alt on Windows and Linux, Option on MacOS (unless stated otherwise) Ctrl - Ctrl on Windows and Linux, Cmd on MacOS (unless stated otherwise) Ctrl + B Manage Bookmarks Ctrl + D Add current Page (to Bookmarks) Ctrl + F Find on This Page Ctrl + I Page Info Ctrl + L Open Web Location (File) Ctrl + O Open File Crtl + R Reload Ctrl + S Save as file Ctrl + + or = Increase indent Ctrl + - Decrease indent Ctrl + Arrow Key Left Back Ctrl + Arrow Key Right Forward Codeing comentary is welcome here. Other comentary please see the tracking bug.
lake@netscape.com, would you like to assign this to the person(s) that is charged with making it happen.
Keywords: KB1
I think McAfee is the person for this.
Assignee: asa → mcafee
->keybaord nav
Component: Browser-General → Keyboard Navigation
QA Contact: doronr → sairuh
Keywords: nsbeta3
Whiteboard: [nsbeta+]
Whiteboard: [nsbeta+] → [nsbeta3+]
another blocker for bug 22529, i b'lieve.
Blocks: 22529
BackSpace - Back to previous page (like in ie and win explorer).
Please do not add functionality to this bug. For this realease we only have enough time and effort for one methid for each critical function. Duplication and other functionality will be addressed later. If you have comments please use bug 22529, the Meta bug for Keyboard stuff. Yes this is a blocker.
Backspace already works on win32. And there's a problem with the original reporter; back and forward will be alt+left arrow and alt+right arrow, not ctrl.
Summary: Accellerators the Browser Must Have → Accelerators the Browser Must Have
actually, it'd be best to file a seperate bug/enhancement request (under this same component) for additional features, for easier tracking. thx!
Ctrl + U needs to open page source (from bug 51541).
*** Bug 51541 has been marked as a duplicate of this bug. ***
Ctrl+U was not to be critical for this release for the browser so was not on this bug. However, if it is in and working for Email it should be for the Browser. This is covered in Bug 51541.
backspace does "page up" in 4.x, the complement to "spacebar".
What does Increase/Decrease Indent (modifier + +/-) do? And is that in the browser, or composer-only? I think Jag was planning on using + and - for text resize, which makes much more sense to me.
Ack! You are right. I checked back to the spec and I misplaced the lines in moving things to the bug. This was supposed to be increase and decerease text tize for non editable things like a web page in the brouser. This did not cover the Editor they already have things worked out. It should read "text size" not indent.
Cool, so how do I do that? xulkey="true" key="+" doesn't work, xulkey="true" keycode="VK_ADD" doesn't either. Suggestions?
Keywords: meta
nav triage team: this is the list that engineering and PMs agreed upon as the minimum necessary. setting to P2
Priority: P3 → P2
Every day I use CTRL-PgUp/PgDn for moving to begin/end of document. Think should be in.
Hmmm, this was because of bug 50252, fixed by akkana. So here's another question: There's a + above the = key on my keyboard, and then there's the + in the numeric pad. I take it either + should work, but should ctrl-= also work? ctrl-- doesn't need shift pressed, and having to press it for ctrl-+ (ctrl-shift-=) is logical but may not seem immediately obvious. Also, should (all) the accelerators mentioned in this bug still be localizable?
Priority: P2 → P3
jag: For now, enable Ctrl-= as well. For the future, if there is no way of specifying a keyboard shortcut like `Control, plus whatever key the "+" symbol happens to be on for any given keyboard layout', file an RFE for it.
Really setting this to P2 this time.
Priority: P3 → P2
PDT agrees P2
Whiteboard: [nsbeta3+] → [nsbeta3+][PDTP2]
cc'ing akkana. Akk, do you know a way to do what mpt suggests? "specify[ing] a keyboard shortcut like `Control, plus whatever key the "+" symbol happens to be on for any given keyboard layout'" For now, I've attached a patch which does accel -, accel +, accel = and shift accel + (so just pretend I wrote accel instead of ctrl in the attachment comment ;-) ) catching the most common ways to do accel - and accel +.
Keywords: patch, review
Hold this for RTM and hope it doesn't hose the l10n folks ...
Keywords: rtm
Whiteboard: [nsbeta3+][PDTP2] → [nsbeta3-][PDTP2][rtm+]
So, landing these changes on the branch won't happen anytime soon. Any reason I can't check this in on the trunk?
Checked in +/- on the trunk.
AFAIK, the only way is to have two bindings, one for + with shift specified, and the other for + with shift unspecified. There doesn't seem to be a way of specifying a binding that's agnostic about whether shift is pressed, alas. But we should do the two-binding thing, so that both shifted + and keypad + will work.
Yup yup, checked in already, should work for you too.
Added "Fix checked in on trunk" to status whiteboard.
Whiteboard: [nsbeta3-][PDTP2][rtm+] → [nsbeta3-][PDTP2][rtm+] Fix checked in on trunk
Note, the + bindings weren't working for me on yesterday's trunk build.
*** Bug 53964 has been marked as a duplicate of this bug. ***
PDT marking [rtm-]. This looks like feature work, and it looks like the patch is for CTRL+/- to change the font size and the bug report asks for CTRL+/- to change the indentation level. Too late for this kind of stuff.
Whiteboard: [nsbeta3-][PDTP2][rtm+] Fix checked in on trunk → [nsbeta3-][PDTP2][rtm-] Fix checked in on trunk
Re my previous comment: I think I got a mislabelled build. When I pulled a later trunk build, ctrl +/- worked fine.
phil, I'm removing rtm-, I believe this was minused on wrong grounds. Even though at the beginning of this bug report ctrl + and - are marked as increase / decrease indent, later on it is stated that for non-editing environments, it should be increase/decrease font size. See Lakespur Roca 2000-09-15 10:32. Since this places increase / decrease font size within the category "Accelerators the Browser Must Have", does "feature work" still apply?
Whiteboard: [nsbeta3-][PDTP2][rtm-] Fix checked in on trunk → [nsbeta3-][PDTP2] Fix checked in on trunk
PDT folks, the fix for the "ctrl-- / ctrl-+" problem is already on the trunk. Resubmitting as per request by "jag".
Whiteboard: [nsbeta3-][PDTP2] Fix checked in on trunk → [nsbeta3-][PDTP2][rtm+] Fix on trunk
It's not feature work: the feature is already there, and all that remains is to make the accelerators correct to match the spec, so that people won't have to relearn them now, then re-relearn them in 6.01 when we do switch them back to the correct ones. The temporary accelerators also conflict with editing key bindings on unix (so they won't work if focus happens to be in the urlbar or a text control), and are not mnemonic the way the correct ones are. Please reconsider.
Blocks: 49437
PDT adding mcarlson to cc list. If l10n is willing to approve this change at this late date, we'll take it.
approving for L10n, please check it asap
rtm++ then
Whiteboard: [nsbeta3-][PDTP2][rtm+] Fix on trunk → [nsbeta3-][PDTP2][rtm++] Fix on trunk
Just checked in on the branch.
Keywords: review
Whiteboard: [nsbeta3-][PDTP2][rtm++] Fix on trunk → [nsbeta3-][PDTP2][rtm++]
Filed http://bugzilla.mozilla.org/show_bug.cgi?id=55438 for back, forward. I believe everything else is working and checked into the trunk & branch, marking fixed. Let's deal with bac, forward in 55438.
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
i've verified fixed (unless mentioned otherwise) the following accelerated shortcuts using the 2000.10.06.xx-n6 [commercial branch] bits on linux, winNT and mac. needs trunk verification on the 3 platforms. where the accelerator key is Ctrl on Windows and Linux, and Command on MacOS. Ctrl + B Manage Bookmarks Ctrl + D Add current Page (to Bookmarks) Ctrl + F Find on This Page Ctrl + I Page Info (doesn't work, see bug 55569) Ctrl + L Open Web Location (File) Ctrl + O Open File Crtl + R Reload Ctrl + S Save as file Ctrl + + or = Increase textsize (not on mac, see bug 39117) Ctrl + - Decrease textsize (bug 39117) bug 55438 covers accel+left/right issues.
Keywords: vtrunk
Verified Fixed on trunk builds with se's noted exceptions. linux 101808 RedHat 6.2 win32 101804 NT 4 mac 101804 Mac OS9 Setting bug to Verified and removing vtrunk keyword
Status: RESOLVED → VERIFIED
Keywords: vtrunk
Keywords: KB1, rtm → nsrtm
Component: Keyboard: Navigation → User events and focus handling
Summary: Accelerators the Browser Must Have → [meta] Accelerators the Browser Must Have
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: