51597 - [meta] Accelerators the Browser Must Have

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Lakespur Roca]

These are the Accelerators that are Must Haves for the Browser of Netscape6. 
Additional Accelerators to be implimented post nsbeta3 will be addressed in 
another bug. 

Alt - Alt on Windows and Linux, Option on MacOS (unless stated otherwise) 
Ctrl - Ctrl on Windows and Linux, Cmd on MacOS (unless stated otherwise) 


Ctrl + B                 Manage Bookmarks 
Ctrl + D                 Add current Page (to Bookmarks) 
Ctrl + F                 Find on This Page
Ctrl + I                 Page Info 
Ctrl + L                 Open Web Location (File) 
Ctrl + O                 Open File 
Crtl + R                 Reload 
Ctrl + S                 Save as file
Ctrl +  + or =           Increase indent
Ctrl + -                 Decrease indent
Ctrl + Arrow Key Left    Back
Ctrl + Arrow Key Right   Forward

Codeing comentary is welcome here. Other comentary please see the tracking bug.

Comment 1

[Asa Dotzler [:asa]]

[e-mail], would you like to assign this to the person(s) that is
charged with making it happen.  

Comment 2

[Lakespur Roca]

I think McAfee is the person for this.

Comment 3

[Blake Ross]

->keybaord nav

Comment 4

[sairuh (rarely reading bugmail)]

another blocker for bug 22529, i b'lieve.

Comment 5

[Eugene Savitsky]

BackSpace - Back to previous page (like in ie and win explorer).

Comment 6

[Lakespur Roca]

Please do not add functionality to this bug. For this realease we only have 
enough time and effort for one methid for each critical function. Duplication 
and other functionality will be addressed later. If you have comments please use 
bug 22529, the Meta bug for Keyboard stuff. Yes this is a blocker.  

Comment 7

[Blake Ross]

Backspace already works on win32.  And there's a problem with the original 
reporter; back and forward will be alt+left arrow and alt+right arrow, not ctrl.

Comment 8

[sairuh (rarely reading bugmail)]

actually, it'd be best to file a seperate bug/enhancement request (under this
same component) for additional features, for easier tracking. thx!

Comment 9

[Chris McAfee]

Ctrl + U needs to open page source (from bug 51541).

Comment 10

[Chris McAfee]

*** Bug 51541 has been marked as a duplicate of this bug. ***

Comment 11

[Lakespur Roca]

Ctrl+U was not to be critical for this release for the browser so was not on 
this bug. However, if it is in and working for Email it should be for the 
Browser.  This is covered in Bug 51541.

Comment 12

[Chris McAfee]

backspace does "page up" in 4.x, the complement to "spacebar".

Comment 13

[Blake Ross]

What does Increase/Decrease Indent (modifier + +/-) do?  And is that in the 
browser, or composer-only? I think Jag was planning on using + and - for text 
resize, which makes much more sense to me.

Comment 14

[Lakespur Roca]

Ack! You are right. I checked back to the spec and I misplaced the lines in 
moving things to the bug. This was supposed to be increase and decerease text 
tize for non editable things like a web page in the brouser. This did not cover 
the Editor they already have things worked out. It should read "text size" not 
indent. 

Comment 15

[Peter "jag" Annema]

Cool, so how do I do that?

xulkey="true" key="+" doesn't work, xulkey="true" keycode="VK_ADD" doesn't
either. Suggestions?

Comment 16

[johng]

nav triage team:
this is the list that engineering and PMs agreed upon as the minimum necessary. 
 setting to P2

Comment 17

[Eugene Savitsky]

Every day I use CTRL-PgUp/PgDn for moving to begin/end of document.

Think should be in.

Comment 18

[Peter "jag" Annema]

Hmmm, this was because of bug 50252, fixed by akkana.

So here's another question:
There's a + above the = key on my keyboard, and then there's the + in the
numeric pad. I take it either + should work, but should ctrl-= also work? ctrl--
doesn't need shift pressed, and having to press it for ctrl-+ (ctrl-shift-=) is
logical but may not seem immediately obvious.

Also, should (all) the accelerators mentioned in this bug still be localizable?

Comment 19

[Matthew T (active 1999-2002)]

jag: For now, enable Ctrl-= as well. For the future, if there is no way of 
specifying a keyboard shortcut like `Control, plus whatever key the "+" symbol 
happens to be on for any given keyboard layout', file an RFE for it.

Comment 20

[don]

Really setting this to P2 this time.

Comment 21

[Phil Peterson]

PDT agrees P2

Comment 22

[Peter "jag" Annema]

Attachment: [patch] implement ctrl-- / ctrl-+ for text smaller / larger

Comment 23

[Peter "jag" Annema]

cc'ing akkana. Akk, do you know a way to do what mpt suggests?
"specify[ing] a keyboard shortcut like `Control, plus whatever key the "+"
symbol happens to be on for any given keyboard layout'"

For now, I've attached a patch which does accel -, accel +, accel = and shift
accel +  (so just pretend I wrote accel instead of ctrl in the attachment
comment ;-) ) catching the most common ways to do accel - and accel +.

Comment 24

[don]

Hold this for RTM and hope it doesn't hose the l10n folks ...

Comment 25

[Peter "jag" Annema]

So, landing these changes on the branch won't happen anytime soon. Any reason I
can't check this in on the trunk?

Comment 26

[Chris McAfee]

Checked in +/- on the trunk.

Comment 27

[Akkana Peck]

AFAIK, the only way is to have two bindings, one for + with shift specified, and
the other for + with shift unspecified.  There doesn't seem to be a way of
specifying a binding that's agnostic about whether shift is pressed, alas.  But
we should do the two-binding thing, so that both shifted + and keypad + will work.

Comment 28

[Peter "jag" Annema]

Yup yup, checked in already, should work for you too.

Comment 29

[don]

Added "Fix checked in on trunk" to status whiteboard.

Comment 30

[Akkana Peck]

Note, the + bindings weren't working for me on yesterday's trunk build.

Comment 31

[Peter "jag" Annema]

*** Bug 53964 has been marked as a duplicate of this bug. ***

Comment 32

[Phil Peterson]

PDT marking [rtm-]. This looks like feature work, and it looks like the patch is
for CTRL+/- to change the font size and the bug report asks for CTRL+/- to
change the indentation level. Too late for this kind of stuff.

Comment 33

[Akkana Peck]

Re my previous comment: I think I got a mislabelled build.  When I pulled a
later trunk build, ctrl +/- worked fine.

Comment 34

[Peter "jag" Annema]

phil, I'm removing rtm-, I believe this was minused on wrong grounds. Even
though at the beginning of this bug report ctrl + and - are marked as increase /
decrease indent, later on it is stated that for non-editing environments, it
should be increase/decrease font size. See Lakespur Roca 2000-09-15 10:32. Since
this places increase / decrease font size within the category "Accelerators the
Browser Must Have", does "feature work" still apply?

Comment 35

[don]

PDT folks, the fix for the "ctrl-- / ctrl-+" problem is already on the trunk.
Resubmitting as per request by "jag".

Comment 36

[Akkana Peck]

It's not feature work: the feature is already there, and all that remains is to
make the accelerators correct to match the spec, so that people won't have to
relearn them now, then re-relearn them in 6.01 when we do switch them back to
the correct ones.  The temporary accelerators also conflict with editing key
bindings on unix (so they won't work if focus happens to be in the urlbar or a
text control), and are not mnemonic the way the correct ones are.  Please
reconsider.

Comment 37

[Phil Peterson]

PDT adding mcarlson to cc list. If l10n is willing to approve this change at
this late date, we'll take it.

Comment 38

[msanz]

approving for L10n, please check it asap

Comment 39

[Phil Peterson]

rtm++ then

Comment 40

[Peter "jag" Annema]

Just checked in on the branch.

Comment 41

[Chris McAfee]

Filed http://bugzilla.mozilla.org/show_bug.cgi?id=55438 for back, forward.
I believe everything else is working and checked into the trunk & branch,
marking fixed.  Let's deal with bac, forward in 55438.

Comment 42

[sairuh (rarely reading bugmail)]

i've verified fixed (unless mentioned otherwise) the following accelerated
shortcuts using the 2000.10.06.xx-n6 [commercial branch] bits on linux, winNT
and mac. needs trunk verification on the 3 platforms.

where the accelerator key is Ctrl on Windows and Linux, and Command on MacOS.

Ctrl + B                 Manage Bookmarks 
Ctrl + D                 Add current Page (to Bookmarks) 
Ctrl + F                 Find on This Page
Ctrl + I                 Page Info (doesn't work, see bug 55569)
Ctrl + L                 Open Web Location (File) 
Ctrl + O                 Open File 
Crtl + R                 Reload 
Ctrl + S                 Save as file
Ctrl +  + or =           Increase textsize (not on mac, see bug 39117)
Ctrl + -                 Decrease textsize (bug 39117)

bug 55438 covers accel+left/right issues.

Comment 43

[Asa Dotzler [:asa]]

Verified Fixed on trunk builds with se's noted exceptions.
linux 101808 RedHat 6.2
win32 101804 NT 4
mac 101804 Mac OS9
Setting bug to Verified and removing vtrunk keyword