518523 - brief hang ("Not Responding" on Windows) with high CPU in spell check when composing or forwarding long text string with many misspellings. Tab out of address field triggers spell check.

Status: RESOLVED WORKSFORME

(Thunderbird :: Message Compose Window, defect)

Description

[Jonathan Protzenko [:protz]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20090915 Thunderbird/3.0b4

I just received an HTML email that I tried to forward. Thunderbird hangs when I try to set the recipient. This happens every time on this particular email but not on other emails.

Reproducible: Always

Steps to Reproduce:
1. Click "forward" in message header.
2. Type some junk in the "to" field
3. Use tab key to focus out of the to: field.
Actual Results:  
Thunderbird hangs, must kill it.


Doesn't happen when using the mouse to get out of the to: field. Doesn't happen when simply replying. Doesn't happen when forwarding other emails. Very weird...

Comment 1

[WADA:World Anti-bad-Duping Agency]

> Doesn't happen when using the mouse to get out of the to: field.
> Doesn't happen when simply replying.
> Doesn't happen when forwarding other emails.

(Q1) No problem in viewing of the mail?
(Q2) What option do you use?
     - View Display Attachments Inline : Enabled/Dispabled
     - View/Message Body As : Original HTML/Simple HTML/Plain Text
(Q3) With which mail format in forward? HTML? Text? Or both?
(Q4) Does similar problem occur when composition of new mail?
     If reply, To: is preset, but when forward, To: is not set, and if you typed
     at To: field, address book access, auto-complete etc. occurs.
(Q5) Does problem occur with -safe-mode of Tb?
(Q6) Can you reproduce problem with new profile, dummy POP3 account?
(1) Save the mail to a local mail folder(say folder-A)
(2) Create new profile, define dummy POP3 account(no Global Inbox use)
(3) Copy file of folder-A in current profile directory to mail directory for the dummy POP3 account under new profile directory.
(4) Restart Tb. Rebuild-Index if required.
(5) "Forward" with several combinations of next options.
    - View Display Attachments Inline : Enabled/Dispabled
    - View/Message Body As : Original HTML/Simple HTML/Plain Text
    - Format : Forward in HTML/Forward in Text

Comment 2

[Jonathan Protzenko [:protz]]

1) No problem in viewing the mail or opening it in a new tab.
2) View > Display attachments inline: yes. View > Message body as > Original HTML (default options).
3) The mail I forward is in HTML format.
4) Does not occur when composing a new email.
5) DOES occur in safe mode.
6) I created a fresh new profile, checked out via POP3 the problematic account with the problematic email, repeated the same procedure, and Thunderbird hung again with 100%cpu. 
6 again) In that fresh profile, I made a local folder, put the problematic email in it, created another fresh profile, created a dummy POP3 account on fresh profile #2, moved the folder with the problematic email into the dummy POP3 account, restart Tb, etc. Results:

- still the same issue when forwarding the email
- unchecked "View display attachments inline", did nothing
- "View > Message body as plain text" selected, still the same issue (and the email was forwarded in plain text that time)
- Same issue with "View message body in simple HTML"
- Checking "Forward messages as an attachment" *solves the issue*

By the way, I ran some additional tests. When I click "forward", the compose message window opens, and the to: field is focused. If I use the mouse to click in the message's body, nothing happens, I can re-focus the to: field using the mouse. If I type some junk in the to: field then move out of it with the mouse, it's ok. It's only when using the tab key to focus out of the to: field that it crashes.

I can create at tarball of fresh profile #2 and upload it somewhere if you wish, there's really nothing confidential at all in it. I'm just afraid that this very specific bug will be hard to reproduce... anyway, if there's anything I can do to help, feel free to ask.

Comment 3

[Jason Oster (:Parasyte)]

Reporter: Is this fixed? Looks similar to Bug 543077.

Comment 4

[Jonathan Protzenko [:protz]]

No that was a different issue. Bug 543077 just prevents me from entering diacritics and wasn't there in gecko 1.9.1. This bug was in gecko 1.9.1 and thunderbird was completely stuck.

I don't remember which email it was so I can't even see if it's fixed now. But last time I tried, it wasn't.

Comment 5

[Jason Oster (:Parasyte)]

Bug 543077 also affected some other things, like the toolbar (Bug 542060)  And step 3 in your STR made me think of it. But you're right, that wasn't in 1.9.1.

If you can find the offending email, would it be possible to anonymize and attach it to this bug?

Comment 6

[Jonathan Protzenko [:protz]]

This is crash report 8456c979-b4a3-45c6-9885-344f62100615 (I'm not sure bugzilla recognizes this, here's the url just in case http://crash-stats.mozilla.com/report/index/8456c979-b4a3-45c6-9885-344f62100615)

I managed to find the offending email, and I reproduced using 3.1b2. Thunderbird went 100% cpu, I killed it using SIGSEGV which triggered the crash reporter. Dan, any thoughts?

I'm afraid this is very specific to my configuration, and there's nothing offending in the email, so I'm attaching the .eml file, but I'm not sure you will manage to reproduce it.

Comment 7

[Jonathan Protzenko [:protz]]

Attachment: The offending email

Comment 8

[Jason Oster (:Parasyte)]

There's spell check stuff in your crash stack.  Maybe this is fixed by Bug 564608 - Update Hunspell to 1.2.11

Could you try with a trunk build? (v3.2 alpha)  See Bug 528368 Comment #2 for instructions and more information.

Comment 9

[Jonathan Protzenko [:protz]]

Yup. Still hangs. BTW, it's actually really simple to reproduce the issue. Have you reproduced it on your side? Just opening the email from File > Open and hitting Ctrl-L and then tab / tab triggers the issue. The issue seems to happen even earlier in comm-central buildsd.

Comment 10

[Jason Oster (:Parasyte)]

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11pre) Gecko/20100531 Lightning/1.0b1 Shredder/3.0.6pre

With this build, Thunderbird only becomes unresponsive for a short time, less than one minute.  Is this what you're seeing?  It sounds like you experience a real hang, per comment #0.

I will try 1.9.2 and 1.9.3 builds when I'm able.

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Nothing jumps out at me, other than that the next step is (assuming you can get a build with debug symbols to do this) to attach with the debugger and poke around a bit more to try and get a more detailed understanding of what's happening...

Comment 12

[Wayne Mery (:wsmwk)]

odd. see this with trunk. no problem with spell check off.

https://bugzilla.mozilla.org/buglist.cgi?type1-0-0=substring&field0-0-0=short_desc&bug_severity=blocker&bug_severity=critical&bug_severity=major&bug_severity=normal&type0-0-1=anywordssubstr&field0-0-1=keywords&type1-0-1=allwordssubstr&value1-0-1=spell&resolution=---&classification=Client%20Software&classification=Components&query_format=advanced&value1-0-0=spell&value0-0-1=hang%20perf&type0-0-0=anywordssubstr&value0-0-0=slow%20hangs&field1-0-0=short_desc&product=Core&product=MailNews%20Core&product=Thunderbird&field1-0-1=component

Comment 13

[Wayne Mery (:wsmwk)]

I can still reproduce with current daily.
after i detached windbg, thunderbird UI was freed up - so I guess not a true hang.

Comment 14

[Wayne Mery (:wsmwk)]

Attachment: windbg stacktrace

Comment 15

[Wayne Mery (:wsmwk)]

related to bug 383718 	?

Comment 16

[Wayne Mery (:wsmwk)]

protz, to what extent can you still reproduce this?

Comment 17

[Wayne Mery (:wsmwk)]

JOe, can you reproduce?

Comment 18

[Joe Sabash [:JoeS1]]

Yes, I get about 25 seconds of 100% CPU during which the UI is basically frozen.

Comment 19

[Wayne Mery (:wsmwk)]

protz, I've optimistically changed this to major based on comment 10, 18 and my own findings on windows with current daily.

This may be a regression, given fixed bug 201866 and bug 282278 and bug 324521

related / duplicate bugs
bug 549332
bug 386040
bug 549332
bug 635843

perhaps someone would care to make the appropriate dups?

query: https://bugzilla.mozilla.org/buglist.cgi?list_id=3552874;short_desc=spell;field0-0-0=short_desc;type0-0-1=substring;field0-0-1=keywords;resolution=---;resolution=FIXED;resolution=DUPLICATE;query_format=advanced;short_desc_type=allwordssubstr;value0-0-1=perf;type0-0-0=anywordssubstr;value0-0-0=forward%20repl;product=MailNews%20Core;product=Thunderbird

Comment 20

[Jonathan Protzenko [:protz]]

I think processing power has increased because at the time I reported this bug, I was using a lower-end computer which *did* hang for >1min, but no worries for downgrading the severity of the bug.

Comment 21

[Jonathan Protzenko [:protz]]

bug 635843 may be remotely related but it's hard to tell. It really does sound like a defect in the spell checking algorithm, or the way we run it, because it shouldn't take that long.

Comment 22

[Wayne Mery (:wsmwk)]

Main point is we shouldn't be spell checking that stuff *at all*. 

Note: historically, spell check has choked when too many strings fail

Comment 23

[Wayne Mery (:wsmwk)]

> Note: historically, spell check has choked when too many strings fail

correction - historically, firefox and thunderbird has choked when too many strings fail spell check - whether individual spell check needs to or can be faster remains to be seen.

Comment 24

[Wayne Mery (:wsmwk)]

Made a profile but I'm not very happy with th results http://people.mozilla.org/~bgirard/cleopatra/?1473650435741#report=5362a54783b3c3587ff6c4d783031ccddcadc57d

Comment 25

[Wayne Mery (:wsmwk)]

> click in the message's body, nothing happens [no problem]... It's only when using the tab key to focus out of the to: field that it crashes.

This sequence[1] (about 80 "/INBOX.sbd/Corbeille.sbd") is enough to put us in a tizzy. The original testcase contains four such lines. Replace slashes with some other punctuation character and same problem [2]. Same effect if I paste the above in a new message, put cursor in address field, and tab to subject. Replace punctuation with spaces and there is no problem

This feels like it would be a duplicate, but I don't see any likely duplicates in https://mzl.la/2lrdtV3 

[1]    ./INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/INBOX.sbd/Corbeille.sbd/

[2]     .HINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbdHINBOX.sbdCCorbeille.sbd/

Comment 26

[Jorg K (CEST = GMT+2)]

Interesting bug, I reproduced it with the attached test message before reading down to Wayne's abridged version in comment #25. Clearly it's incorrectly classified as Thunderbird::Message Compose Window. This should clearly go into Core::Editor or Core::Spelling Checker. Anyway, when I have less burning fires, I can take a look.

Oh, can you make FF hang by pasting this into http://www-archive.mozilla.org/editor/midasdemo/?

Comment 27

[Jorg K (CEST = GMT+2)]

"Same effect if I paste the above in a new message, put cursor in address field, and tab to subject."

I tried pasting the text from comment #25 [1] into a new message and Midas and no hang. Wayne, what are the exact steps?

Comment 28

[Arthur K. (he/him)]

Is this still happening since 78.x was released?

Comment 29

[Wayne Mery (:wsmwk)]

(In reply to Arthur K. [He/Him] from comment #28)

Is this still happening since 78.x was released?

None of the original participants are active. Are you able to reproduce?

Comment 30

[Antony]

I'll try and have a go with a 78 installation later

Comment 31

[Antony]

(In reply to Wayne Mery (:wsmwk) from comment #29)

(In reply to Arthur K. [He/Him] from comment #28)

Is this still happening since 78.x was released?

None of the original participants are active. Are you able to reproduce?

Sorry, meant to post that as a reply

I'll try and have a go with a 78 installation later

Comment 32

[Arthur K. (he/him)]

(In reply to Wayne Mery (:wsmwk) from comment #29)

(In reply to Arthur K. [He/Him] from comment #28)

Is this still happening since 78.x was released?

None of the original participants are active. Are you able to reproduce?

Nope.