Closed Bug 1068186 Opened 9 years ago Closed 8 years ago

[e10s] Add search engine button on mozilla website does not work

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Type:
defect
Priority:
Not set
Severity:
normal
Points:
5

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 38
Iteration:
38.2 - 9 Feb
Tracking Flags:
Tracking Status
e10s m6+ ---
firefox38 --- fixed

People

(Reporter: tomasz, Assigned: mossop)

References

Details

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1068186: Update window.sidebar and window.external APIs to support e10s.
39 bytes, text/x-review-board-request
Felipe
: review+
Details 
Repro:
1. navigate to https://addons.mozilla.org/en-US/firefox/search/?atype=4
2. try "add to firefox" on any search engine
3. a) from user perspective: nothing happens
b) from console: JavaScript error: file:///Users/mozilla/gecko-dev/obj-ff-dbg/dist/NightlyDebug.app/Contents/MacOS/browser/components/nsSidebar.js, line 89: TypeError: win is null
JavaScript error: https://addons.cdn.mozilla.net/static/js/impala-min.js?build=934bc15-5416ea4f, line 2: NS_ERROR_UNEXPECTED: 
[Parent 29373] WARNING: No docshells for remote frames!: file /Users/mozilla/gecko-dev/content/base/src/nsFrameLoader.cpp, line 511
Ideally we would fix this and bug 518929 at the same time.
Flags: firefox-backlog+
Flags: qe-verify?
Reproduced with Nightly 37.0a1 2014-12-02 under Win 7 64-bit.
Component: General → Search
OS: Mac OS X → All
Hardware: x86 → All
Points: --- → 5
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Iteration: --- → 38.2 - 9 Feb
Depends on: 518929
Attached file MozReview Request: bz://1068186/Mossop (obsolete) — 
/r/3321 - Bug 1068186: Update window.sidebar and window.external APIs to support e10s.

Pull down this commit:

hg pull review -r 3e9caa49383e78e73e5f111ff09fb063f2cfa7c0
Comment on attachment 8559262 [details]
MozReview Request: bz://1068186/Mossop

/r/3321 - Bug 1068186: Update window.sidebar and window.external APIs to support e10s.

Pull down this commit:

hg pull review -r 3e9caa49383e78e73e5f111ff09fb063f2cfa7c0
Attachment #8559262 - Flags: review?(felipc)
Attachment #8559262 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/9ebe4e3c1085
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Dave, you missed Metro:
/mozilla/browser/metro/components/Sidebar.js
I understand that some group in the innards of Mozilla Corp is doing Metro builds.
Flags: needinfo?(dtownsend)
Metro code is not maintained in m-c and will be removed in bug 1039866, it does not need to be patched.
Flags: needinfo?(dtownsend)
Depends on: 1130886
Depends on: 1132030
QA Whiteboard: [good first verify][verify in Nightly only]

        Attachment #8559262 -
        Attachment is obsolete: true

        Attachment #8618372 -
        Flags: review+

          You need to log in
          before you can comment on or make changes to this bug.