1068186 - [e10s] Add search engine button on mozilla website does not work

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Tomasz Kołodziejski [:tomasz]]

Repro:
1. navigate to https://addons.mozilla.org/en-US/firefox/search/?atype=4
2. try "add to firefox" on any search engine
3. a) from user perspective: nothing happens
b) from console: JavaScript error: file:///Users/mozilla/gecko-dev/obj-ff-dbg/dist/NightlyDebug.app/Contents/MacOS/browser/components/nsSidebar.js, line 89: TypeError: win is null
JavaScript error: https://addons.cdn.mozilla.net/static/js/impala-min.js?build=934bc15-5416ea4f, line 2: NS_ERROR_UNEXPECTED: 
[Parent 29373] WARNING: No docshells for remote frames!: file /Users/mozilla/gecko-dev/content/base/src/nsFrameLoader.cpp, line 511

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Ideally we would fix this and bug 518929 at the same time.

Comment 6

[Petruta Horea [:phorea], Desktop QA]

Reproduced with Nightly 37.0a1 2014-12-02 under Win 7 64-bit.

Comment 10

[Dave Townsend [:mossop]]

Attachment: MozReview Request: bz://1068186/Mossop

/r/3321 - Bug 1068186: Update window.sidebar and window.external APIs to support e10s.

Pull down this commit:

hg pull review -r 3e9caa49383e78e73e5f111ff09fb063f2cfa7c0

Comment 11

[Dave Townsend [:mossop]]

Comment on attachment 8559262 [details]
MozReview Request: bz://1068186/Mossop

/r/3321 - Bug 1068186: Update window.sidebar and window.external APIs to support e10s.

Pull down this commit:

hg pull review -r 3e9caa49383e78e73e5f111ff09fb063f2cfa7c0

Comment 12

[:Felipe Gomes (needinfo for replies!)]

https://reviewboard.mozilla.org/r/3321/#review2769

Ship It!

Comment 13

[Dave Townsend [:mossop]]

Shipped: https://hg.mozilla.org/integration/fx-team/rev/9ebe4e3c1085

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9ebe4e3c1085

Comment 15

[Philip Chee]

Dave, you missed Metro:
/mozilla/browser/metro/components/Sidebar.js
I understand that some group in the innards of Mozilla Corp is doing Metro builds.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

Metro code is not maintained in m-c and will be removed in bug 1039866, it does not need to be patched.

Comment 18

[Dave Townsend [:mossop]]

Attachment: MozReview Request: Bug 1068186: Update window.sidebar and window.external APIs to support e10s.