520457 - Customize Toolbar leads to doubled account list in menu File > Get new Mail

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

A similar bug was in 3.0 b1 builds:
https://bugzilla.mozilla.org/show_bug.cgi?id=456940

STR:
Open the Customize Toolbar dialog. Exit the dialog with "Okay". Open menu File > Get new mail. The accounts list now is doubled - this iterates. The account list in the "Get mail" buttons drop down, doesn't duplicate this time.

BTW:
This bug is independent from Lightning.

Comment 1

[Alex Ihrig [:Thunderbird_Mail_DE]]

Thunderbird 3.0pre 20091004

Comment 2

[Ludovic Hirlimann [:Usul]]

This WFM on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.4pre) Gecko/20091004 Shredder/3.0pre + enigmail.

Alexander does it happen in safe-mode too ?

Comment 3

[Alex Ihrig [:Thunderbird_Mail_DE]]

Shredder 3.0pre 20091005

Yes, it happens in safe-mode too. The account list in File > Get all mail is doubled, too. Maybe this was all the time since bug 456940 fixed the problem for the buttons account list. But I'm not sure. The fix in 456940 uses DOM to fix only "button-getmsg".

The related fix:
https://bug456940.bugzilla.mozilla.org/attachment.cgi?id=358264

Comment 4

[[:Aureliano Buendía]]

If I undestrand well your problem here is WFM with

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20091006 Lightning/1.0pre Shredder/3.0pre ID:20091006032243

I have only this issue here: bug #518586

Comment 5

[Alex Ihrig [:Thunderbird_Mail_DE]]

I've now tested this in a linux VM using OpenSUSE 11.1 and Shredder 3.0pre 20091006 build:

This bug occurs there too.

To make it clear: this bug is about the accounts list in the _File menu_.

Comment 6

[[:Aureliano Buendía]]

Alexander could attach here a screenshot of the problem, please?

Comment 7

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Screenshot showing the iterated account list

Comment 8

[[:Aureliano Buendía]]

I'm sorry: you are right confirmed also here!

Comment 9

[Ludovic Hirlimann [:Usul]]

I really don't see that on the Mac. Anything missing in the STR ?

Comment 10

[[:Aureliano Buendía]]

(In reply to comment #9)
> I really don't see that on the Mac. Anything missing in the STR ?

Here it seems that comment #0 is complete:

1. click on main toolbar with mouse rx button;
2. select "custumize..." item;
3. when "custumize toolbar" window is open, click on "done" button;
4. goto menu-->File-->get new messages for
5. all account are duped.

I have 5 account: 3 in local folders and 2 others.
I try also in safe-mode on Windows XP professional sp3.

Maybe it is only Windows related?

Comment 11

[Magnus Melin [:mkmelin]]

I see it on linux. (Only after second time though??)

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

Blake, can you take a look at this, since you've got some Customizate Toolbar experience?

Comment 13

[Blake Winton (:bwinton) (:☕️)]

Yeah, sure.  It should fit right in with the work I'm doing on bug 518586.

Comment 14

[Blake Winton (:bwinton) (:☕️)]

Attachment: A patch to remove the old items from the menu.

I don't really know why the menu is getting re-created after customization, keeping its children but not its fields, but with this patch we clear out the generated entries, and it all looks good.

And it's based on top of the patch for 518586, because that fixes a lot of other related bugs.

Comment 15

[Mark Banner (:standard8)]

Will the patch cause the "Get All New Messages" option to be added back in as well? I believe that currently gets lost at the moment (which I think has been reported elsewhere).

Comment 16

[Blake Winton (:bwinton) (:☕️)]

This patch won't, but I believe the patch for bug 518586 will.  (Or rather, it will stop the option from being removed in the first place.)

Comment 17

[Magnus Melin [:mkmelin]]

Comment on attachment 405195 [details] [diff] [review]
A patch to remove the old items from the menu.

I'm not a mailnews/ peer but i can confirm it works.

Comment 18

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 405195 [details] [diff] [review]
A patch to remove the old items from the menu.

(In reply to comment #17)
> I'm not a mailnews/ peer but i can confirm it works.

D'oh, that's very true.  I suppose I should ask asuth for an additional review, then.

(I felt like I was asking him for a lot of reviews, and wanted to try to spread it around a little.)

Hopefully knowing that it works will make his review job at least a little easier.

Thanks,
Blake.

Comment 19

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/0f7ad55e29c3