Closed Bug 522007 Opened 17 years ago Closed 13 years ago

[sk] Choose search plug-ins for Fennec in Slovak

Categories

(Mozilla Localizations :: sk / Slovak, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stas, Assigned: rozbora)

References

Details

(Keywords: productization, Whiteboard: [bootstrapped][twitter][slovnik.sk][azet])

Attachments

(3 files)

You've indicated an interest in participating in the localization of mobile Firefox (aka Fennec). We want to ship Fennec with a good list of search engines for Slovak. As the technical details of implementation are being worked on, we'd like to start the discussion about the choice of search engines. This bug is about agreeing on a set of search engines, and will not tackle the implementation (at least not yet). First, the localization team and Staś will look at the market for the locale and come up with a good set of search providers. The guidelines for making recommendations are on https://wiki.mozilla.org/L10n:Mobile/Productization. You're welcome to suggest engines already shipped in desktop Firefox for Slovak, if they fit well in the categories outlined on the wiki. For en-US, we currently use the following set, which may serve as an inspiration: Google, Wikipedia, Amazon, Yahoo, Twitter. Note that according to the guidelines, for some categories it may be better to leave them empty than to ship with en engine that's irrelevant or unavailable in your region. After we decided on a particular search engine, we will need to test it in Fennec. You can test on a mobile device and on the desktop (download the builds from <http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/>). Staś will help with testing on a device, too. If the service works fine, Staś will contact the owner and ask for permission, and for specifics like proper search flags. We'll likely need your help to at least get the contact information if we don't have them already. We don't know the implementation details yet, so for now, please don't create patches nor land anything. We will keep you posted as we figure out the how's and when's. Thanks.
Hi Guys: Just a friendly reminder, as we move closer to the general availability date for Fennec in mid-December, has your team had any chance to consider search providers? Thanks!
Hi Seth, Stas. We do want Google, sk.Wikipedia and Twitter for sure, still discussing a local search and specific interest search. There won't be an e-commerce search for sk.
Here's a patch resetting the mobile/searchplugins/ directory to a minimal set of search engines that we would like to ship your locale with. Please read this comment carefully before you land this patch. *Important*: There has been a change to how we use the <Description/> elements present in the plug-ins (see bug 528655 and bug 529869). We want to emphasize that the search is integrated with the browser to better reflect what a search plugin is and what it does. You will need to edit the Wikipedia plug-in before you commit this patch. Please read <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions> for detailed instructions. For Google and Twitter, we don't have to copy the XML files to your mobile/searchplugins/ directory. Plugins identical to en-US are pulled from source automatically. It's enough to put the engine's name in list.txt for this to work (which I did). I also updated the Wikipedia plug-in to use a bigger icon, see bug 517997 for details. Please edit the Wikipedia plug-in and commit this patch before you opt-in in the mozilla.dev.l10n newsgroup. Opt-ins without this patch will not be taken. This does not mean that we don't want to include other search engines. On the contrary, the work and the discussion will continue in this bug until we choose a good set of search engines for your locale. Then, you will be able to opt in again, so that in the final release we include more search engines than the mineral set from this patch. This patch is simply meant to reset your mobile/searchplugins directory so that we keep the repository clean and happy. Thanks for understanding!
The plugin is based on the one added to Firefox in bug 467332, the only changes are: - updated icon (32x32) - shortened name 'Slovnik.sk (EN-SK)' in Firefox vs. 'Slovnik.sk' in Fennec - updated description for use in Fennec Add-ons manager Tested with current Fennec desktop nightlies.
Attachment #414716 - Flags: review?(stas)
Comment on attachment 414716 [details] [diff] [review] add specific interest search - Slovnik.sk dictionary >+<Description>Prekladové slovníky (predvolene EN-SK)</Description> Can you please change this description to highlight the fact that the search is integrated with the browser? <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions#L10n_implementation> has details about this. r=me with the above comment addressed, thanks.
Attachment #414716 - Flags: review?(stas) → review+
Whiteboard: [bootstrapped][twitter][slovnik.sk]
Attached patch add azet.sk — — Splinter Review
As I mentioned in comment 2 we'd like to add a local search provider for localized Fennec releases. We have decided to go with Azet.sk, which we are already using in desktop Firefox builds. The version for Fennec is offering a bit different functionality as it's primarily searching for the points of interest and offers geolocation feature as well. That means if you enter "restaurant" as a search term and allow the geolocation by tapping the "Firmy v mojom okoli" link, it will search for the restaurants in the near surroundings. The location can be entered manually as well. By adding this search to the default browser search plugin list we will be able provide local users with even better mobile web experience with one global general search and one local search provider. The plugin was tested with current nightly desktop fennec win builds. The contact person in Azet: Katarína Trnovcová (trnovcova@firma.azet.sk)
Attachment #489279 - Flags: review?(stas)
Thank you for the contact person. Mail sent to Katarína to confirm. I copied Vlado on the email.
Whiteboard: [bootstrapped][twitter][slovnik.sk] → [bootstrapped][twitter][slovnik.sk][azet]
By the way, in the email, I invited Azet.sk to add a parameter if they choose to Vlado's plugin.
Comment on attachment 489279 [details] [diff] [review] add azet.sk This plugin looks good to me, but I have not been able to test it locally. Can you land this on l10n-central and then do a test on your nightly build to confirm that it works OK? Once you have confirmed with testing, please sign off on Axel's sign off app. You can close this bug when you are finished.
Attachment #489279 - Flags: review?(stas) → review+
No longer blocks: fm-l10n-sk
Depends on: fm-l10n-sk
Vlado, have there been any changes to the list of search engines here since Seth's last comment? Karen, do you have any thoughts on this list?
Nope, Azet.sk was the last to land on central, aurora and beta. This was done some time ago and signed off as requested in comment 10. The list of engines as of now for Slovak: google azet-sk slovnik-sk twitter wikipedia-sk They are all approved, tested and working (re-checked with todays Aurora build 23a2 2013-05-24). We are happy with the list. As per Seth's comment 10 the bug may be resolved (unless there are some other comment/thoughts from you guys). Thanks.
(In reply to Vlado Valastiak [:wladow] @ Mozilla.sk from comment #13) > Nope, Azet.sk was the last to land on central, aurora and beta. This was > done some time ago and signed off as requested in comment 10. > > The list of engines as of now for Slovak: > google > azet-sk > slovnik-sk > twitter > wikipedia-sk > > They are all approved, tested and working (re-checked with todays Aurora > build 23a2 2013-05-24). We are happy with the list. As per Seth's comment 10 > the bug may be resolved (unless there are some other comment/thoughts from > you guys). Thanks. Thanks for confirming the list, Vlado. Glad to see that they're in Aurora. Karen needs to check on a couple of things before we can close it. Once she gives the ok, we'll resolve the bug.
I am going to just check that nothing has changed from a contractual perspective for azet.sk and slovnik-sk, but as Monday is a US holiday, I may not get an answer until after their long weekend. Will respond back as soon as I know. Thanks! Karen
If we have confirmation that azet-sk and slovnik-sk are aware that we intent on including them on our list, no other action is required from my side. Just want to ensure they are prepared for any increase in traffic, etc. So you have my ok if they know what we're up to.
(In reply to Karen Rudnitski [:kar] from comment #16) > If we have confirmation that azet-sk and slovnik-sk are aware that we intent > on including them on our list, no other action is required from my side. > Just want to ensure they are prepared for any increase in traffic, etc. So > you have my ok if they know what we're up to. Great! Thanks Karen. Vlado, would you feel comfortable reaching out to these two to notify them about what we intend to do? Let us know if we can help.
I'm pretty sure you already have the confirmations since that's the essential to get the approval to land stuff like this. Has this policy changed recently?
(In reply to Vlado Valastiak [:wladow] @ Mozilla.sk from comment #18) > I'm pretty sure you already have the confirmations since that's the > essential to get the approval to land stuff like this. Has this policy > changed recently? No, this hasn't changed. I suppose I simply missed this confirmation in the previous comments. Looks like Seth was on top of this prior to it landing. That being the case, I'm resolving this bug. Thanks for all of your help Vlado!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Blocks: fm-l10n-sk
No longer depends on: fm-l10n-sk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: