Closed Bug 522008 Opened 10 years ago Closed 10 years ago

[sl] Choose search plug-ins for Fennec in Slovene

Categories

(Mozilla Localizations :: sl / Slovene, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stas, Assigned: stas)

References

Details

(Keywords: productization, Whiteboard: [bootstrapped][twitter][ceneje.si][odpiralnicasi.com])

Attachments

(4 files, 10 obsolete files)

22.86 KB, patch
Details | Diff | Splinter Review
3.55 KB, application/octet-stream
Details
1.23 KB, image/png
Details
3.66 KB, patch
Details | Diff | Splinter Review
You've indicated an interest in participating in the localization of mobile Firefox (aka Fennec). We want to ship Fennec with a good list of search engines for Slovene. As the technical details of implementation are being worked on, we'd like to start the discussion about the choice of search engines. This bug is about agreeing on a set of search engines, and will not tackle the implementation (at least not yet).

First, the localization team and Staś will look at the market for the locale and come up with a good set of search providers. The guidelines for making recommendations are on https://wiki.mozilla.org/L10n:Mobile/Productization. You're welcome to suggest engines already shipped in desktop Firefox for Slovene, if they fit well in the categories outlined on the wiki.

For en-US, we currently use the following set, which may serve as an inspiration:
Google, Wikipedia, Amazon, Yahoo, Twitter.

Note that according to the guidelines, for some categories it may be better to leave them empty than to ship with en engine that's irrelevant or unavailable in your region.

After we decided on a particular search engine, we will need to test it in Fennec. You can test on a mobile device and on the desktop (download the builds from <http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/>). Staś will help with testing on a device, too. If the service works fine, Staś will contact the owner and ask for permission, and for specifics like proper search flags. We'll likely need your help to at least get the contact information if we don't have them already.

We don't know the implementation details yet, so for now, please don't create patches nor land anything. We will keep you posted as we figure out the how's and when's.

Thanks.
Assignee: nobody → brian
www.google.com
www.najdi.si
www.ceneje.si
www.odpiralnicasi.com
sl.wikipedia.org
Hey,

We are still discussing it, but right now it looks like the upper list is what we would like to have in Fennec (and Firefox 3.6, too).

Thanks
Matjaž: any suggestions for the social search? Is Twitter popular in Slovenia? Maybe there is a local equivalent? Please let me know.

Thanks.
Twitter is fine. I asked Matjaz to pull that in favour of more local ones, but if it is part of a Social category then it makes more sense.

So if there are only 5, we need to pull one. I suggest www.odpiralnicasi.com.
But then again, if we are limited to 5 search engines, I think odpiralnicasi.com (a Slovenian verison of yelp.com) is useful for many more people than twitter.
Here's a patch resetting the mobile/searchplugins/ directory to a minimal set of search engines that we would like to ship your locale with. Please read this comment carefully before you land this patch.

*Important*: There has been a change to how we use the  <Description/> elements present in the plug-ins (see bug 528655 and bug 529869). We want to emphasize that the search is integrated with the browser to better reflect what a search plugin is and what it does. You will need to edit the Wikipedia plug-in before you commit this patch. Please read <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions> for detailed instructions.

For Google, we don't have to copy the XML file to your mobile/searchplugins/ directory. Plugins identical to en-US are pulled from source automatically. It's enough to put the engine's name in list.txt for this to work (which I did). I also updated the Wikipedia plug-in to use a bigger icon, see bug 517997 for details.

Please edit the Wikipedia plug-in and commit this patch before you opt-in in the mozilla.dev.l10n newsgroup. Opt-ins without this patch will not be taken. This does not mean that we don't want to include other search engines. On the contrary, the work and the discussion will continue in this bug until we choose a good set of search engines for your locale. Then, you will be able to opt in again, so that in the final release we include more search engines than the mineral set from this patch.

This patch is simply meant to reset your mobile/searchplugins directory so that we keep the repository clean and happy.

Thanks for understanding!
(In reply to comment #5)
> But then again, if we are limited to 5 search engines, I think
> odpiralnicasi.com (a Slovenian verison of yelp.com) is useful for many more
> people than twitter.

Including odpiralnicasi.com is a really good idea. The site is clear, easy to use, plus it seems to support geolocation (although I couldn't really test it, being based in Poland). Almost a perfect candidate :)

I wonder, however, if we need two general search engines: google and najdi. I think I'd prefer to leave only google and add twitter in the social category. So the final list might look like this:

www.google.com
www.ceneje.si
www.odpiralnicasi.com
sl.wikipedia.org
twitter

Thoughts?
(In reply to comment #7)
> Including odpiralnicasi.com is a really good idea. The site is clear, easy to
> use, plus it seems to support geolocation (although I couldn't really test it,
> being based in Poland). Almost a perfect candidate :)
> 
> I wonder, however, if we need two general search engines: google and najdi. I
> think I'd prefer to leave only google and add twitter in the social category.
> So the final list might look like this:
> 
> www.google.com
> www.ceneje.si
> www.odpiralnicasi.com
> sl.wikipedia.org
> twitter
> 
> Thoughts?

I'm fine with this. Matjaž?

Staś, what are the next steps? Note that we are almost done with string translation, but the searchplugins/ folder is just a straight copy from en-US right now.

http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/sl/file/9237d10afe35/mobile/searchplugins
Status: NEW → ASSIGNED
(In reply to comment #8)

> Staś, what are the next steps? Note that we are almost done with string
> translation, but the searchplugins/ folder is just a straight copy from en-US
> right now.

For google, twitter and sl.wikipedia, you can land my patch from comment 6. Please follow the instructions at <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions> when doing this.

For ceneje.si and odpiralnicasi.com, we'll need to email them to ask for permissions, then create patches, get reviews and land. I found following contact information:
* ceneje.si: http://www.ceneje.si/oCeneje.aspx and info@ceneje.si
* odpiralnicasi.si: http://odpiralnicasi.com/contact and info@odpiralnicasi.com

Should I write to these addresses right now or do you happen to know better ways to contact these providers?

I'd suggest you land my patch today so that we have google, twitter and sl.wikipedia ready for 1.0. Then we can work in this bug on other two engines.
Attached patch Search Plugins cleanup #1 (obsolete) — Splinter Review
As per comment 6, this patch:

- remove the xml files for google, amazondotcom, yahoo, and wikipedia
- stips list.txt down to minimum of google and wikipedia-sl
- adds wikipedia-sl.xml

I've uncommented the Description in wikipedia-sl but it has not been reviewed so I won't opt in yet with this patch checked in. It's main goal is cleanup.
Attachment #415474 - Flags: review?(stas)
I agree with Stas, but we should change the order of search engines to this:

www.google.com
sl.wikipedia.org
www.odpiralnicasi.com
www.ceneje.si
twitter

I will contact guys from odpiralnicasi.com and ceneje.si and ask them for permission to include their engines in Firefox Mobile and Firefox 3.6.
Comment on attachment 415474 [details] [diff] [review]
Search Plugins cleanup #1

Thanks Brian. r=me, with a question and a comment.

>diff --git a/mobile/searchplugins/list.txt b/mobile/searchplugins/list.txt

>-amazondotcom
> google
>-twitter
>-wikipedia
>-yahoo
>+wikipedia-sl

No Twitter?


>diff --git a/mobile/searchplugins/wikipedia-sl.xml b/mobile/searchplugins/wikipedia-sl.xml

>+<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
>+<ShortName>Wikipedija</ShortName>
>+<Description>Wikipedija, prosta enciklopedija</Description>

If you're deciding to leave the description line in the plugin, please make the text read something like "Integrated search on Wikipedia". Otherwise, please remove the whole line (Fennec will use a generic "Integrated search" string instead). Please fix this before landing.
Attachment #415474 - Flags: review?(stas) → review+
I agree with Stas, but we should change the order of search engines to this:

www.google.com
sl.wikipedia.org
www.odpiralnicasi.com
www.ceneje.si
twitter

I will contact guys from odpiralnicasi.com and ceneje.si and ask them for permission to include their engines in Firefox Mobile and Firefox 3.6.
Checked in cleanup. See also:

http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/sl/rev/aee93f1ab18e

In addition to changes in the previous patch, this has:

- twitter added to list.txt
- twitter.xml removed
- Description in wikipedia-sl updated to something more suitable
Attachment #414632 - Attachment is obsolete: true
Attachment #415474 - Attachment is obsolete: true
(In reply to comment #13)
> I will contact guys from odpiralnicasi.com and ceneje.si and ask them for
> permission to include their engines in Firefox Mobile and Firefox 3.6.

You should aks about icons as well.
(In reply to comment #13)
> I agree with Stas, but we should change the order of search engines to this:
> 
> www.google.com
> sl.wikipedia.org
> www.odpiralnicasi.com
> www.ceneje.si
> twitter

Changes to order can be made through region.properties: http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/sl/file/aee93f1ab18e/mobile/chrome/region.properties#l6 but only for first two engines. 

(If more control is needed, we can do that as well by editing mobile-l10n.js, but that's not encouraged.)

> I will contact guys from odpiralnicasi.com and ceneje.si and ask them for
> permission to include their engines in Firefox Mobile and Firefox 3.6.

Firefox 3.6? :) Best way of phrasing this (IMO) would be to ask for permissions for Firefox, without specifying versions or editions. This will give us a lot of flexibility.

(In reply to comment #15)
> (In reply to comment #13)
> > I will contact guys from odpiralnicasi.com and ceneje.si and ask them for
> > permission to include their engines in Firefox Mobile and Firefox 3.6.
> 
> You should aks about icons as well.

Good point.

(In reply to comment #14)
> Created an attachment (id=415494) [details]
> [checked in] Search Plugins cleanup #1
> 
> Checked in cleanup. See also:
> 
> http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/sl/rev/aee93f1ab18e
> 
> In addition to changes in the previous patch, this has:
> 
> - twitter added to list.txt
> - twitter.xml removed
> - Description in wikipedia-sl updated to something more suitable

Brian, I missed one thing when doing the review, sorry.

http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/sl/file/aee93f1ab18e/mobile/searchplugins/wikipedia-sl.xml#l2

<ShortName>Wikipedija</ShortName>

should be

<ShortName>Wikipedija (sl)</ShortName>

to match the name of the plugin available on sl.wikipedia.org.

Would you mind doing a follow-up commit to fix this?
Whiteboard: [bootstrapped][twitter]
Sure, I will ask them for Firefox in general, I just wanted to stress we are making changes to search engines in Firefox 3.6 for the first time since... er... Firefox 1.0 ;)

And yes, I should ask about icons, too.
Just got confirmation emails from both Ceneje.si and Odpiralnicasi.com, so we can use their engines and icons.
(In reply to comment #16)
> Brian, I missed one thing when doing the review, sorry.
> 
> http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/sl/file/aee93f1ab18e/mobile/searchplugins/wikipedia-sl.xml#l2
> 
> <ShortName>Wikipedija</ShortName>
> 
> should be
> 
> <ShortName>Wikipedija (sl)</ShortName>
> 
> to match the name of the plugin available on sl.wikipedia.org.
> 
> Would you mind doing a follow-up commit to fix this?

Fixed:

http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/sl/rev/060beab34771
(In reply to comment #18)
> Just got confirmation emails from both Ceneje.si and Odpiralnicasi.com, so we
> can use their engines and icons.

Great. Please attach the icons when you get them and we'll make the XML files.
(In reply to comment #19)

> Fixed:
> 
> http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/sl/rev/060beab34771


Thanks, Brian. Please remember to re-opt in with this landing.
Forgot to mention that they are both extremly happy to be part of Slovenian Firefox. Ceneje.si will mention our "deal" in their next newsletter which has 50.000 subscribers.
(In reply to comment #22)
> http://odpiralnicasi.com/favicon.ico
> 
> http://media.ceneje.si/favicon.gif

Thanks Matjaž. These are 16x16px icons. Any chance they could provide 32x32px as well?

Also, would you mind forwarding these emails to me, please? It's for the archiving purposes.
Didn't know that we also need 32x32 icons... Is there anything else I should ask them?

Sure, I will FW you all the emails.
(In reply to comment #25)
> Didn't know that we also need 32x32 icons... Is there anything else I should
> ask them?

Please ask if they wish that we add a tracking parameter (e.g. from=fxmobile) so that they can identify the traffic that we're sending to them.

> Sure, I will FW you all the emails.

Cool, thanks.
Ceneje.si would like to have two parameters, one for mobile and one for desktop edition. That's possible, right?

I will attach their 32x32 icon.
Can this one be closed off?
Well, we have permissions and icons, but we don't have the plugins in a patch and nothing has landed so far. Would you like to prepare the patch or do you prefer that I do it?
(In reply to comment #31)
> Well, we have permissions and icons, but we don't have the plugins in a patch
> and nothing has landed so far. Would you like to prepare the patch or do you
> prefer that I do it?

Would be great if you could do it Stas if you have some cycles. Otherwise I'll get to it soon.
This is a patch adding Odpiralni-casi.
Attachment #423876 - Flags: review?(stas)
We'll need some information from Ceneji.si before we can create that search plugin.  I searched for an email contact for Ceneje.si, but only found a general feedback form so I inquired (in English) using that form.  

If there is a more direct email address, we will need to ask them for an open search description .xml file so we can create the proper plugin.  We will also need to ask them if they have any special parameters for their search plug-in.  

Matjaž, can you email your contact at Ceneje.si asking them for this.  Here is a good reference doc for you, if you like:

https://wiki.mozilla.org/L10n:Toolbox/Creating_a_search_plugin#...from_a_search_provider
Thank you Seth! I just emailed my contact at Ceneje.si, so let's wait for his response.
This is a patch adding Ceneje.si.
This is a patch adding m.Ceneje.si.
Ok, people from ceneje.si have send me the files we needed. Seth, could you please check if they are ok?

Now we have two XML open search description files, one for www.ceneje.si and one for m.ceneje.si, which is a mobile version of the page. We should probably use this one, what do you guys think?
m.Ceneje.si for here and www.ceneje.si for bug 542528 perhaps?
I agree with Brian.
(In reply to comment #38)
> Ok, people from ceneje.si have send me the files we needed. Seth, could you
> please check if they are ok?

You're going to need to convert the ceneje.si icon to an encoded format. You can do this by visiting the "URI Kitchen" and uploading the 32x32 file that you attached to this bug.

http://software.hixie.ch/utilities/cgi/data/data

I did this for you and generated that encoded icon.  Here it is:

http://pastebin.mozilla.org/700175

You will need to replace the "http://www.ceneje.si/favicon.ico" here

<Image height="16" width="16" type="image/x-icon">http://www.ceneje.si/favicon.ico</Image>

with the contents of that pastebin.  I believe you have to change the height and width numbers to "32", but Stas can confirm that for me.  Once you've done that, can you upload the new patch with changes?  Thanks!
Thank you Seth, I hope it's ok now. I added only m.Ceneje.si plugin.
Stas, Can you review Matjaz's latest patch for Ceneje.si.  Thanks.
Attachment #423992 - Attachment is obsolete: true
Attachment #423993 - Attachment is obsolete: true
Attachment #424067 - Attachment is obsolete: true
Attachment #424075 - Flags: review?(stas)
Attached patch Odpiralni Casi search plugin (obsolete) — Splinter Review
Patch attached instead of the diff.  Sorry about that.  I'll leave the diff attached to this bug.
Attachment #424095 - Flags: review?(stas)
Stas, can we have your eyes on latest attachments. We'd like to get this landed and the bug wrapped up.
Stas, ping. :-)
Alright, it took me a while, sorry for the wait. I went through the comments in this bug and in bug 542528 and I think that this patch should be fine.

Notes:

* All icons are base64-encoded png's.

* Following what we did in bug 542528, the name of the Ceneje.si plugin is ceneji.xml. Can you confirm that this is correct?

* I decided to use the 16x16 icon for Ceneje.si because it looked better than the icon from attachment 415639 [details] when scaled up to 32x32 by Fennec. I left the white background.

* For the Odpiralni Časi's plug-in, I used "Odpiralni Časi" in the <ShortName/>. This has 2 consequences:

** The search bar displays a pretty "Odpiralni Časi", which I believe is the correct form in Slovene.

** But, when you go to http://odpiralnicasi.com/, the page menu in Fennec will still offer you to install the search plugin. This is because they use "Odpiralni Casi" (without the "Č") in the title attribute in their <link/> element:

<link href='http://www.odpiralnicasi.com/opensearch/description.xml' rel='search' title='Odpiralni Casi' type='application/opensearchdescription+xml'>

I think that it's better to use the correct form rather than try to match the title used by the website. But, if you think that "Odpiralni Casi" would also be acceptable, feel free to change the <ShortName/> in the patch.

I tested both plugins and both worked fine. 

Please land this patch on 1.9.2 and sign off with the new changeset after verifying that everything works as expected.

We might still make it for 1.1 RC :)

Thanks!
Attachment #423876 - Attachment is obsolete: true
Attachment #424075 - Attachment is obsolete: true
Attachment #424095 - Attachment is obsolete: true
Attachment #423876 - Flags: review?(stas)
Attachment #424075 - Flags: review?(stas)
Attachment #424095 - Flags: review?(stas)
Same patch as above, except that I also remove the browser.search.order.2 pref from region.properties in this one.
Attachment #439550 - Attachment is obsolete: true
Comment on attachment 439551 [details] [diff] [review]
Cleaned up patch adding Ceneje and Odpiralni Časi, removed browser.search.order.2

Matjaz, can you review this patch?
Attachment #439551 - Flags: review?(m)
Hi and sorry for my late response. I have to questions to ask:

1. The name should be ceneje.si, not ceneji.si. But does it matter at all?

2. Do differnet <ShortName/> contents in the Odpiralni Časi's plug-in mean users will be offered to install another "version" of Odpiralni Časi's plugin? If that is the case, I will contact the guys and ask them to use the same description.xml as we do, ok?
(In reply to comment #51)
> 1. The name should be ceneje.si, not ceneji.si. But does it matter at all?

It does matter.  We should change it.

> 2. Do differnet <ShortName/> contents in the Odpiralni Časi's plug-in mean
> users will be offered to install another "version" of Odpiralni Časi's plugin?
> If that is the case, I will contact the guys and ask them to use the same
> description.xml as we do, ok?

Not sure what you are referencing here.  I am looking at the patch from Brian and I don't see different <ShortName> contents for Odpiralni Časi plugin.
1. Ok, let's change the name then, but I'm not sure how to do this. Can someone help me here please?

2. I talking about our Odpiralni Časi's plug-in <ShortName/> vs. this:
http://www.odpiralnicasi.com/opensearch/description.xml

See Stas's post.
(In reply to comment #53)
> 2. I talking about our Odpiralni Časi's plug-in <ShortName/> vs. this:
> http://www.odpiralnicasi.com/opensearch/description.xml

Are you just talking about C -> Č ? I think we should go with the latter and ask them to change their version.
Yes. Ok, I will talk to guys then.
Stas, your patch looks good to go .. you just need to change ceneji.si to ceneje.si.
Assignee: brian → stas
Guys from OdpiralniČasi have just updated their file:
http://www.odpiralnicasi.com/opensearch/description.xml
OK, here it is. I chage the name of the file from ceneji.xml to ceneje.xml. We might need to do the same for the browser; care to file a bug for that, please?

Matjaž, awesome work talking to Odpiralni Časi. It's great news that they changed the name to the correct one on their side.

If this patch is what you want, let's land it. We might still be able to make it for 1.1. Will you be able to land today/tomorrow, test and sign off?

Thanks, guys!
Attachment #439551 - Attachment is obsolete: true
Attachment #445152 - Flags: review?(m)
Attachment #439551 - Flags: review?(m)
Comment on attachment 445152 [details] [diff] [review]
Change ceneji.xml to ceneje.xml (the filename)

Looks good to me. 

Matjaz, you need to sign off on this before it lands.
Thanks Stas, it looks OK to me too.
Hey guys. Do you want to land this patch now and take it for 1.1?
Sure!
Stas, I thought you were going to land it because you had the changes locally. 

If you need me to do it, let me know.
Hey Brian. Please go ahead and land this patch, if you don't mind. Please reference this bug and the review in the commit message.

Thanks!
(In reply to comment #64)
> Hey Brian. Please go ahead and land this patch, if you don't mind. Please
> reference this bug and the review in the commit message.

http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/sl/rev/300fb56aaa0a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [bootstrapped][twitter] → [bootstrapped][twitter][ceneje.si][odpiralnicasi.com]
Thanks Brian.

l10n-src-verification updated in http://hg.mozilla.org/l10n/l10n-src-verification/rev/9f86320622f7
Attachment #445152 - Flags: review?(m)
You need to log in before you can comment on or make changes to this bug.