527422 - (tb-enigmail-incompat) Crash on send [@nsCOMPtr_base::assign_assuming_AddRef(nsISupports*)] caused by incompatible Enigmail version

Status: RESOLVED INVALID

(Thunderbird :: General, defect)

Description

[Ludovic Hirlimann [:Usul]]

All crashes are on 20091107031309 - seems to be different users , as some comments are not in english. 

Xref bug 527409 which has a similar stack.

This is currently top crash #1 - when selecting a weeks worth of crash reports. Hence requesting blocking.

Comment 1

[Ludovic Hirlimann [:Usul]]

0  	thunderbird.exe  	nsCOMPtr_base::assign_assuming_AddRef  	 objdir-tb/mozilla/dist/include/xpcom/nsAutoPtr.h:943
1 	thunderbird.exe 	nsRefPtr<nsSpeculativeScriptThread>::assign_with_AddRef 	objdir-tb/mozilla/dist/include/xpcom/nsAutoPtr.h:928
2 	thunderbird.exe 	nsMsgComposeAndSend::InitCompositionFields 	mailnews/compose/src/nsMsgSend.cpp:2813
3 	thunderbird.exe 	nsMsgComposeAndSend::Init 	mailnews/compose/src/nsMsgSend.cpp:3415
4 	thunderbird.exe 	nsMsgComposeAndSend::CreateAndSendMessage 	mailnews/compose/src/nsMsgSend.cpp:4290
5 	thunderbird.exe 	nsMsgCompose::_SendMsg 	mailnews/compose/src/nsMsgCompose.cpp:1050
6 	thunderbird.exe 	nsMsgCompose::SendMsg 	mailnews/compose/src/nsMsgCompose.cpp:1247
7 	xpcom_core.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
8 	thunderbird.exe 	XPCWrappedNative::CallMethod 	js/src/xpconnect/src/xpcwrappednative.cpp:2297
9 	thunderbird.exe 	XPC_WN_CallMethod 	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1590
10 	js3250.dll 	js_Invoke 	js/src/jsinterp.cpp:1386
11 	thunderbird.exe 	XPC_WN_GetObjectOpsWithCall 	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1398

Comment 2

[Mark Banner (:standard8)]

Unless I'm mistaken, this all seems to be a result of binary incompatibility changes and enigmail. See comments on bug 527409 for a starter.

These both landed which affected api changes:

http://hg.mozilla.org/releases/comm-1.9.1/rev/7b68edce5121 (bug 248681)
http://hg.mozilla.org/releases/comm-1.9.1/rev/d79070dab585 (bug 465618)

The first of these adjusted nsIMsgCompFields, looking at the source code the stack is pointing to where we create nsMsgCompFields:

http://hg.mozilla.org/releases/comm-1.9.1/annotate/b30435119c01/mailnews/compose/src/nsMsgSend.cpp#l2813

Whilst we could have done something in the constructor - we haven't, we've just added a few new functions, that wouldn't be likely to cause a crash like that which to me points to binary incompatibilities.

Additionally all of the crash stacks I've seen have enigmail in the list of modules, whilst not definitive proof, this adds to the weight that this isn't Thunderbird's problem.

Comment 3

[Patrick Brunschwig]

The problem with Enigmail in general is that if APIs like nsIMsgCompFields change, then Enigmail needs at least be re-compiled.

Unfortunately I can't force people to upgrade to the very latest nightly builds, so that this can potentially leads to crashes. The very latest nightly builds of Enigmail works fine with latest trunk, older releases indeed can crash.

Comment 4

[Mark Banner (:standard8)]

Ok, without evidence to the contrary we can't do anything about this bug because it isn't in core Thunderbird and the way binary extensions work are the limitation here.

Therefore closing as invalid.