529201 - fields.html should contain help for every field

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

Right now fields.html contains help for only a limited set of fields. It would be fairly easy to create a page that had help for every single field, by re-using the current search help stuff.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Here we go! The only thing that this actually requires from the blocker is page.css, so if you want to review this separately from the blocker, just copy page.css out of the other bug and into your installation.

Comment 2

[Max Kanat-Alexander]

Attachment: Screenshot of the whole page

And here's what the whole page looks like.

Comment 3

[Max Kanat-Alexander]

Attachment: v2

There were a few formatting errors in the Status/Resolution table that have now been fixed.

Comment 4

[Gordon P. Hemsley [:GPHemsley]]

Max, just a reminder that you can simply add an id attribute to the h2 headers (or any other element) to make them anchors. Do away with the old-fashioned <a name> business.

(Meanwhile, the currently-live code has a </a> missing from the "Importance" header.)

Comment 5

[Max Kanat-Alexander]

(In reply to comment #4)
> Max, just a reminder that you can simply add an id attribute to the h2 headers
> (or any other element) to make them anchors. Do away with the old-fashioned <a
> name> business.

  Oh, does that work in IE 6 and all the various mobile browsers and so on? I actually didn't know that.

Comment 6

[Gordon P. Hemsley [:GPHemsley]]

(In reply to comment #5)
> (In reply to comment #4)
> > Max, just a reminder that you can simply add an id attribute to the h2 headers
> > (or any other element) to make them anchors. Do away with the old-fashioned <a
> > name> business.
> 
>   Oh, does that work in IE 6 and all the various mobile browsers and so on? I
> actually didn't know that.
I would have to assume that all mobile browsers are new enough that they do. IE6 I wasn't sure enough, so I asked:
<GPHemsley> Does anyone know off-hand if IE6 supports @id anchors?
<annevk> it does
<GPHemsley> I thought so
<annevk> IE5 does too
<annevk> NN4 didn't
<annevk> but I never cared about that
<GPHemsley> :)

So it looks like we're even more in the clear than anyone could've been worried about.

Comment 7

[Max Kanat-Alexander]

Sweet, thanks for letting me know. We should file a bug for changing that in all of Bugzilla. If you want to do that yourself, feel free to go ahead, but I'll do it myself if not, later.

Comment 8

[Frédéric Buclin]

Comment on attachment 412767 [details] [diff] [review]
v2

patching file template/en/default/pages/fields.html.tmpl
Hunk #1 FAILED at 19.
Hunk #2 succeeded at 170 (offset -1 lines).
Hunk #3 succeeded at 185 (offset -1 lines).
Hunk #4 FAILED at 205.
2 out of 4 hunks FAILED -- saving rejects to file template/en/default/pages/fields.html.tmpl.rej

Bitrotten, probably by bug 519142.

Comment 9

[Max Kanat-Alexander]

There's no need to force this in to 3.6 at this point.

Comment 10

[Max Kanat-Alexander]

Attachment: v3 (contains rename)

Fixed the bitrot.

This contains a rename, but it's picked up if you just do "bzr mv --auto".

Comment 11

[Gordon P. Hemsley [:GPHemsley]]

(In reply to comment #4)
> (Meanwhile, the currently-live code has a </a> missing from the "Importance"
> header.)

I've filed bug 546338 for this.

(In reply to comment #7)
> Sweet, thanks for letting me know. We should file a bug for changing that in
> all of Bugzilla. If you want to do that yourself, feel free to go ahead, but
> I'll do it myself if not, later.

I've filed bug 546340 for this.

Comment 12

[Max Kanat-Alexander]

Attachment: v4

The patch had bitrotted slightly, so I updated it.

This is a bzr bundle, so you should be able to apply it with "bzr merge /path/to/patch" and it should do all the renames for you.

Comment 13

[Frédéric Buclin]

Comment on attachment 427066 [details] [diff] [review]
v4

Looks good. r=LpSolit

Comment 14

[Max Kanat-Alexander]

I added the footer to fields.html on checkin.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified page.cgi
modified Bugzilla/Field.pm
modified skins/standard/page.css
renamed template/en/default/search/search-help.html.tmpl => template/en/default/bug/field-help.none.tmpl
modified template/en/default/global/help.html.tmpl
modified template/en/default/pages/fields.html.tmpl
modified template/en/default/search/search-advanced.html.tmpl
Committed revision 6997.

Comment 15

[Max Kanat-Alexander]

Added to the release notes in bug 604256.