fields.html should contain help for every field

RESOLVED FIXED in Bugzilla 4.0

Status

()

Bugzilla
Bugzilla-General
--
enhancement
RESOLVED FIXED
9 years ago
5 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

unspecified
Bugzilla 4.0
Dependency tree / graph
Bug Flags:
approval +

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

9 years ago
Right now fields.html contains help for only a limited set of fields. It would be fairly easy to create a page that had help for every single field, by re-using the current search help stuff.
(Assignee)

Updated

9 years ago
Target Milestone: Bugzilla 3.4 → Bugzilla 3.6
(Assignee)

Comment 1

9 years ago
Created attachment 412763 [details] [diff] [review]
v1

Here we go! The only thing that this actually requires from the blocker is page.css, so if you want to review this separately from the blocker, just copy page.css out of the other bug and into your installation.
Assignee: general → mkanat
Status: NEW → ASSIGNED
Attachment #412763 - Flags: review?(LpSolit)
(Assignee)

Comment 2

9 years ago
Created attachment 412764 [details]
Screenshot of the whole page

And here's what the whole page looks like.
(Assignee)

Comment 3

9 years ago
Created attachment 412767 [details] [diff] [review]
v2

There were a few formatting errors in the Status/Resolution table that have now been fixed.
Attachment #412763 - Attachment is obsolete: true
Attachment #412767 - Flags: review?(LpSolit)
Attachment #412763 - Flags: review?(LpSolit)
(Assignee)

Updated

9 years ago
Blocks: 488940
(Assignee)

Updated

9 years ago
Blocks: 369489
Max, just a reminder that you can simply add an id attribute to the h2 headers (or any other element) to make them anchors. Do away with the old-fashioned <a name> business.

(Meanwhile, the currently-live code has a </a> missing from the "Importance" header.)
(Assignee)

Comment 5

9 years ago
(In reply to comment #4)
> Max, just a reminder that you can simply add an id attribute to the h2 headers
> (or any other element) to make them anchors. Do away with the old-fashioned <a
> name> business.

  Oh, does that work in IE 6 and all the various mobile browsers and so on? I actually didn't know that.
(In reply to comment #5)
> (In reply to comment #4)
> > Max, just a reminder that you can simply add an id attribute to the h2 headers
> > (or any other element) to make them anchors. Do away with the old-fashioned <a
> > name> business.
> 
>   Oh, does that work in IE 6 and all the various mobile browsers and so on? I
> actually didn't know that.
I would have to assume that all mobile browsers are new enough that they do. IE6 I wasn't sure enough, so I asked:
<GPHemsley> Does anyone know off-hand if IE6 supports @id anchors?
<annevk> it does
<GPHemsley> I thought so
<annevk> IE5 does too
<annevk> NN4 didn't
<annevk> but I never cared about that
<GPHemsley> :)

So it looks like we're even more in the clear than anyone could've been worried about.
(Assignee)

Comment 7

9 years ago
Sweet, thanks for letting me know. We should file a bug for changing that in all of Bugzilla. If you want to do that yourself, feel free to go ahead, but I'll do it myself if not, later.

Comment 8

9 years ago
Comment on attachment 412767 [details] [diff] [review]
v2

patching file template/en/default/pages/fields.html.tmpl
Hunk #1 FAILED at 19.
Hunk #2 succeeded at 170 (offset -1 lines).
Hunk #3 succeeded at 185 (offset -1 lines).
Hunk #4 FAILED at 205.
2 out of 4 hunks FAILED -- saving rejects to file template/en/default/pages/fields.html.tmpl.rej

Bitrotten, probably by bug 519142.
Attachment #412767 - Flags: review?(LpSolit) → review-
(Assignee)

Comment 9

9 years ago
There's no need to force this in to 3.6 at this point.
Target Milestone: Bugzilla 3.6 → Bugzilla 3.8
(Assignee)

Comment 10

9 years ago
Created attachment 425729 [details] [diff] [review]
v3 (contains rename)

Fixed the bitrot.

This contains a rename, but it's picked up if you just do "bzr mv --auto".
Attachment #412767 - Attachment is obsolete: true
Attachment #425729 - Flags: review?(LpSolit)
(In reply to comment #4)
> (Meanwhile, the currently-live code has a </a> missing from the "Importance"
> header.)

I've filed bug 546338 for this.

(In reply to comment #7)
> Sweet, thanks for letting me know. We should file a bug for changing that in
> all of Bugzilla. If you want to do that yourself, feel free to go ahead, but
> I'll do it myself if not, later.

I've filed bug 546340 for this.
(Assignee)

Updated

9 years ago
Blocks: 546340
(Assignee)

Comment 12

9 years ago
Created attachment 427066 [details] [diff] [review]
v4

The patch had bitrotted slightly, so I updated it.

This is a bzr bundle, so you should be able to apply it with "bzr merge /path/to/patch" and it should do all the renames for you.
Attachment #425729 - Attachment is obsolete: true
Attachment #427066 - Flags: review?(LpSolit)
Attachment #425729 - Flags: review?(LpSolit)

Comment 13

9 years ago
Comment on attachment 427066 [details] [diff] [review]
v4

Looks good. r=LpSolit
Attachment #427066 - Flags: review?(LpSolit) → review+

Updated

9 years ago
Flags: approval+
(Assignee)

Comment 14

9 years ago
I added the footer to fields.html on checkin.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified page.cgi
modified Bugzilla/Field.pm
modified skins/standard/page.css
renamed template/en/default/search/search-help.html.tmpl => template/en/default/bug/field-help.none.tmpl
modified template/en/default/global/help.html.tmpl
modified template/en/default/pages/fields.html.tmpl
modified template/en/default/search/search-advanced.html.tmpl
Committed revision 6997.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Keywords: relnote
(Assignee)

Comment 15

8 years ago
Added to the release notes in bug 604256.
Keywords: relnote

Updated

5 years ago
Blocks: 861582
You need to log in before you can comment on or make changes to this bug.