530935 - [IDE] use embedded Bespin for editor

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Heather Arthur [:harth]]

We should use Bespin embedded as our text editor b/c it's the best!

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Heather, can you please check the other "IDE" related bugs which could be fixed by this awesome replacement? We should add those as blockers for this bug.

https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced;short_desc=IDE;short_desc_type=allwordssubstr;component=Mozmill

Comment 2

[Heather Arthur [:harth]]

just noting that the work is going on here: http://github.com/harthur/mozmill/commits/newui

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks. Once you wanna have a first review feel free to ask. I can check then.

Comment 4

[Heather Arthur [:harth]]

Ready to try out now. It would be great if anyone could pull from my newui branch and let me know what they think.

Comment 5

[Heather Arthur [:harth]]

I should note that the UI here isn't final at all, I had to change it a lot because we got rid of the old editor tabs, but it isn't the UI we'll want in the end, just wanted to get Bespin in there as soon as possible.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I get conflicts when pulling the source from the newui branch:

CONFLICT (content): Merge conflict in mozmill/extension/content/menus.js
Auto-merging mozmill/extension/resource/modules/frame.js
Auto-merging mozmill/extension/resource/modules/mozmill.js
CONFLICT (content): Merge conflict in mozmill/extension/resource/modules/mozmill.js
Automatic merge failed; fix conflicts and then commit the result.

Comment 7

[Heather Arthur [:harth]]

just merged master into newui and resolved the error, so try pulling now.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Worked fine and looks great. Here some initial thoughts:

* We should reduce the margin around the editor to give as much as possible space for editing tests

* A tabbar with tabs for each editor would be great but it's probably something we should consider if we want to go back to XUL.

* Can we add a label right next to the test selection drop down?

* Switching between files doesn't set the focus to the editor. You will have to click into the editor to be able to continue writing the test.

* Can we use (shift)+ctrl+tab to switch between the tests?

* I cannot close an opened test with a keyboard shortcut (ctrl/cmd+w)

* Can we add separators into the actions menu? Even showing up shortcuts would be great.

* Selecting Run File/Directory doesn't close the actions drop down

* Arrange windows button doesn't work the first time you click on

Comment 9

[Heather Arthur [:harth]]

Bespin 0.9a1 is in my bespin09noiframe branch:
http://github.com/harthur/mozmill/compare/bespin09noiframe

Comment 10

[Heather Arthur [:harth]]

both "git diff -U8 -p master" and the GitHub UI are failing to show the real changes between master and bespin09noiframe branch. Might be better off looking at the tree:

http://github.com/harthur/mozmill/tree/bespin09noiframe/mozmill/mozmill/extension/

Comment 11

[Heather Arthur [:harth]]

(In reply to comment #10)
> both "git diff -U8 -p master" and the GitHub UI are failing to show the real
> changes between master and bespin09noiframe branch. Might be better off looking
> at the tree:
> 
> http://github.com/harthur/mozmill/tree/bespin09noiframe/mozmill/mozmill/extension/

retracted, patch and compare view are fine, got confused by an old file that has now been deleted

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That merge caused me a lot of trouble on master. I was able to solve merge conflicts and I have pushed the resolution to the master. I hope it helps others.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Clint, was that an accidental push to mozauto 1.4.2 or why have you landed all the bespin code on the 1.4.2 branch? We haven't marked that bug as a Mozmill 1.4.2 blocker so far.

See:
http://github.com/mozautomation/mozmill/commit/277f688928ff483971c524fe030baab5b8ccc399

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Also when we wanna stay with Bespin, please get rid of the following editarea folder:

http://github.com/mozautomation/mozmill/tree/1.4.2/mozmill/mozmill/extension/content/editarea/

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

What about including the compressed version of Bespin for Mozmill? That will reduce our code size even more.

Comment 16

[cmtalbert]

This has landed, please open follow-on bugs for issues with the editor.

Comment 17

[Aaron Train [:aaronmt]]

VERFIED FIXED w/1.4.2b2. The editor looks great Heather.

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #17)
> VERFIED FIXED w/1.4.2b2. The editor looks great Heather.

I would still advise everyone to play with the new editor and file issues as new bugs dependent on this bug. Thanks.