531489 - weave lost bookmarks with same url

Status: VERIFIED FIXED

(Firefox :: Sync, defect, critical)

Description

[Igor Velkov]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091127 SeaMonkey/2.1a1pre
Build Identifier: 

When I have some bookmarks with same url, but in different locations, or/and different fields, after 2 sync, some of bookmarks removed.

Reproducible: Always

Comment 1

[Igor Velkov]

Attachment: profile1 log

Comment 2

[Igor Velkov]

Attachment: profile2 log

Comment 3

[Igor Velkov]

http://yfrog.com/j5capture20091128053608px
there is a slideshow with screenshots of 2 browsers.

First we have 2 profile in sync. Then I copy bookmark named "linux.org.ru" to toolbar, and rename it to "lor"
After sync on 1 host appears only new bookmark named "lor" on toolbar. Then on source host boolmark "linux.org.ru" lost from original folder, but on toolbar appears 2 bookmarks named "lor".

Then I rename one of pair to "lor renamed". and bookmark in first profile appers as "lor renamed".

screenshot names ends with timestamps, it can help to place screenshots on log file timeline.

Comment 4

[Igor Velkov]

Maybe, flickr hosting will be more comfortable
http://www.flickr.com/photos/shtripok/sets/72157622889934260/

Comment 5

[[e-mail]]

i have the same situation, i have 3 computer to sync: computer A and B are in company, computer C is at home, A is windows, B is linux, C is windows, and i keep firefox on A running 7x24 for some reason. i got the bookmark D in directory E and F, i find sometime thers is no D in E, and sometime two D in E, even sometime D appear in the place it shouldn't be(eg. directory G).
when i use xmarks, it is ok.

Comment 6

[Mike Connor [:mconnor]]

Ed, is this a dupe?

Comment 8

[[e-mail]]

the only solution i have got is change the url, eg. i use one as "?order=dateline&action=spacenews" and the other "?action=spacenews&order=dateline"，or i use one as "abc.com/bbs" and the other "abc.com/bbs/", may this will help you.

Comment 9

[Tracy Walker [:tracy]]

confirmed. 

This is how I reproduced with bookmark of http://www.linux.org.ru

1) Visit the site on client A.
2) bookmark the page by clicking the star twice and putting it in the bookmarks menu folder under the default Mozilla Firefox folder.
3) open the library and copy then paste said bookmark into the Bookmarks tool bar folder.
4) Sync to cloud on client A
5) sync from cloud on client B

tested results:
The bookmark of LINUX.ORG.RU is not present on client B's Bookmark toolbar.  The bookmark is present in the Mozilla Firefox folder on client B

Expected results:
Both copies of the bookmark are present in the same locations on client B as they are on client A.

Tested from Mac 10.6 (client A) to Win XP (client B)

Testing in the other direction, the bookmark appears on the toolbar but not in the Mozilla Firefox folder upon sync from WinXP to Mac 10.6

Comment 10

[Tracy Walker [:tracy]]

Attachment: activity logs of 10.6 and WinXP

Comment 11

[Ed Lee :Mardak]

Are you sure you were syncing from os x to win xp? The logs seem to indicate weave creating a linux.org.ru bookmark on the os x side. Could you turn on Debug logging for bookmarks?

Comment 12

[Tracy Walker [:tracy]]

Attachment: 10.6 to XP sync

I set extensions.weave.log.logger.engine.bookmarks -> Trace on both clients.  I can't tell, nor do I know what differences should appear in the log.

Comment 13

[Tracy Walker [:tracy]]

Attachment: 10.6 to XP sync bookmark Trace on

Comment 14

[Tracy Walker [:tracy]]

Attachment: 10.6 to XP sync bookmark Trace on

sorry, didn't select plain text last time

Comment 15

[Daniel Holbert [:dholbert]]

(In reply to comment #14)
> sorry, didn't select plain text last time

(For future reference, you don't actually have to re-post in this situation -- you can just click "details" next to the attachment, and change the "MIME Type" field to say "text/plain")

Comment 16

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/a154534ae332
Do dupe detection for bookmarks like how we do folders/separators but check against the url/title. Add parentName to bookmark records, so bump version.

Comment 19

[Jonathan Griffin (:jgriffin)]

Add test for this as http://hg.mozilla.org/automation/crossweave/rev/6a800619dc81

Comment 20

[Tracy Walker [:tracy]]

removing in-litmus flag, it no longer exists