532874 - Unable to add new events or tasks because units for alarm preferences are missing

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[frank-buettner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: 1.0b1pre

Hello I use Lightning with Thunderbird 3.0RC
I use the German one.

Reproducible: Always

Steps to Reproduce:
1. click on Datei(file)
2. Neu(new)
3. select Task or Event
Actual Results:  
Nothing will happends.

Expected Results:  
The the dialogue will show for new task's/event's

Comment 1

[Stefan Sitter [:ssitter]]

Do you see any messages in Error Console?

Please note the detailed Thunderbird and Lightning version you are using.

Comment 2

[frank-buettner]

Hello,
no messages are shown in the error console.
Here more infos about the Lightning version:
Version: 1.0b1pre
Build: 20091202072211
Thunderbird:
Version: 3.0RC2
This are all version infos that i fount.
Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.5) Gecko/20091130 Lightning/1.0b1pre Thunderbird/3.0

If you need more, please tell me were I can find it.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

This works fine for me on Linux with Tb3rc2 and build 20091207050725. Are you maybe experiencing bug 398702 ?

Comment 4

[frank-buettner]

No, because I don't use Buttons! the extensions.

Comment 5

[frank-buettner]

Today I have installed TB3 final, but the problem still exists.

Comment 6

[frank-buettner]

Today I testet Lightning 1.02bpre Buidl 20091211033801 an it has the same porblem.

Comment 7

[frank-buettner]

I have found the problem. While updating from TB2 to TB3 and Lightning there was one default parameter lost. After setting it, now Lightning will work. There was no value set in the drop down box for the time selection.

Comment 8

[frank-buettner]

Attachment: This are the both fileds, that was not set.

Comment 10

[Martin Schröder [:mschroeder]]

Confirming per duplicate, although we don't know what causes this problem!

Comment 11

[Philipp Kewisch [:Fallen][📱📆]]

Frank, do you remember if have you changed this preference in the past?

I'd appreciate if you could test each of the following:

* Create a new Thunderbird 3 / 1.0b1 profile - does the bug still happen?
* Create a new Thunderbird2 / 0.9 profile, then try upgrading again to 
  Thunderbird 3 with 1.0b1.

If this prodcues the same errors, then please try:

* Repeat the same process as above, but make sure you are using the en-US lightning, instead of the German one.

Thanks in advance!

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

This quite simple patch takes care. It will still fail if you manually set the pref to something other than a valid unit, but it will catch empty values and default to minutes. I still don't know why this pref is unset in some profiles, but at least we are more robust now.

Comment 15

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v2

Ah what the hell, lets be even more robust!

Comment 16

[Martin Schröder [:mschroeder]]

Comment on attachment 470224 [details] [diff] [review]
Fix - v2

Easy one to review ;-) r=mschroeder

Comment 17

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/fb1967d0fd8c>
-> FIXED

Comment 18

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/80361e9b1de8>

a=philipp