Closed Bug 398702 Opened 13 years ago Closed 10 years ago

Thunderbirds File, Edit and View menus are hidden with some Lightning + other extensions combinations - Error: document.getElementById("show-completed-checkbox") is null Fichier Source : chrome://calendar/content/calendar-unifinder-todo.js Line : 61

Categories

(Thunderbird :: Mail Window Front End, defect, major)

defect
Not set
major

Tracking

(blocking-thunderbird3.0 needed, thunderbird3.0 .1-fixed)

RESOLVED FIXED
Thunderbird 3.1a1
Tracking Status
blocking-thunderbird3.0 --- needed
thunderbird3.0 --- .1-fixed

People

(Reporter: trevmrgn+bug, Assigned: anarchy)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.7) Gecko/20070914 Firefox/2.0.0.7
Build Identifier: Lightning 0.7rc1 + Buttons! 0.5.3.2 + Thunderbird 2.0.0.6

Running Thunderbird with Lightning and Buttons! extensions enabled.
The File, Edit and View menus in view message windows have no names.
The menus are still there but their names and some entries are blank.
The blank entries still work, if you know what they are.
Disabling either extension restores the menus.

Reproducible: Always

Steps to Reproduce:
1. Install lightning and Buttons! extensions
2. Double click an e-mail in the inbox to open a window
3. Look for the File, Edit and View menus
4. Click on one of the blank bits at the start of the menu bar
Actual Results:  
The first part of the menu bar is blank.  Small sections are highlighted when I mouse over and the menu appears when I click, but with the some entries blank.

Expected Results:  
File, Edit and View menus are visible

Blank menu items:
File
File->New
File->Close
Edit
Edit->Cut
Edit->Copy
Edit->Paste
View
View->Toolbars
View->Toolbars->Status bar
Tools->Options
IMO lightning can't be compatible with every created extension. 
Omar, if it is our bug, then we should fix it. But I wonder why Trevor assumes that this is our bug and not a bug on the Buttons! extension side?

Trevor? Any indication why you think this is our bug?
I think this is a lightning bug because it is does not appear using lightning 0.5

In checking this is true using a new profile I found that it also requires the 'Allow Html Temp' extension (version 1.0.3 tried).

Disabling any one of the three extensions cures the problem.
I tried to reproduce you issue by installing the following extensions

  - Allow HTML temp 1.0.3
  - Buttons! 0.5.3.2
  - Lightning 0.7 (2007100704)

in a clean profile using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.8pre) Gecko/2007100603 Thunderbird/2.0.0.7pre

I only see the following error from the Buttons! extension:

  Error: bUpdateUndoButtons is not defined
  Source File: chrome://buttons/content/composeWindow.js 
  Line: 146

but all menus are visible -> WORKSFORME.
(In reply to comment #4)

lightning 0.7 (2007100605)
Buttons! 0.5.3.2
Allow HTML temp 1.0.3
Thunderbird 2.0.0.6 (20070728)

WORKSFORME too
PS. I can't see any error in console
Whiteboard: [qa discussion needed]
I got Thunderbird 2.0.0.6. and Lightning 0.7, but no Buttons! extension.

And I don't see those menu items, too.

When disabling lightning they're there again.

Also, when pressing Crtl+c in the message window, the message is deleted. Trevor, do you have the same behaviour?

I installed lightning 0.5 before with apt from the ubuntu repositories, maybe this is important someway.
I just installed lightning to a fresh and clean thunderbird profile, there everything is ok.
A new twist to this bug:
If DOM inspector is installed, the bug goes away!
(In reply to comment #6)
I get message deleted when ctrl-c is pressed too.

Andy, what other extensions did you have in the profile that exhibited the bug?  And what extensions in the fresh profile?
The fresh profile only has the lightning extension installed.

The defekt profile got the following extensions installed:
 * Attachment Extractor
 * Attachment Sizes
 * Check and Send
 * Enigmail
 * Enigmail - DE Language Package
 * Folderpane Tools
 * MoreFunctionsForAdressBook
 * Quote Colors
 * SmtpSelect
 * SyncMab

When disabling all of these and enabling lightning, the bug exists, anyway.

I'll try to install those plugins in the fresh profile and check when the bug appears.
(In reply to comment #8)
> A new twist to this bug:
> If DOM inspector is installed, the bug goes away!

I can confirm that - funny.

Ok, it took me some time, but for me it's this combination of extensions that causes the bug:
 * Enigmail 0.95.5
 * Lightning 0.7
 * MoreFunctionsForAddressBook 0.4.0.5
 * Quote Colors 0.2.8
 * SmtpSelect 1.0.0

When removing one of them, the bug disappears, same when installing the DOM inspector.

Curious, isn't it.
Summary: Menus hidden with lightning & buttons! extension → File, Edit and View menus hidden with some Lightning + other extensions combinations
Keywords: qawanted
Whiteboard: [qa discussion needed]
Duplicate of this bug: 429182
note bug 429182 comment #2 for only
Buttons!+ Lightning + Image Zoom and assuming fist two as issue ..
Duplicate of this bug: 457241
I'm very sorry for creating the duplicate bug 457241. :"(

I can confirm
comments #6 and 9: Ctrl+c deletes the mail (that was a suprise ... ;-))
comments #8 and 11: Installing DOM Inspector 1.8.1.2 solved the problem for me, too.

I can't confirm
comment #12: Except for Lightning I have *none* of the add-ons Andy mentions.
Here are all my add-ons: http://img502.imageshack.us/my.php?image=addonsqd9.jpg.

Just (de)activating either Lightning or Buttons! creates(solves) the bug on my PC.

What's weird is that I had no problems until I updated to Lightning 0.9. I didn't make *any* other changes to my profile, but this one update. Before that Lightning and Buttons! worked just perfectly fine together.

P.S.: I'm running Thunderbird 2.0.0.16 on WinXP SP3.
This may be a thunderbird bug. Please try the following:

* Go to your thunderbird directory, the subdirectory "chrome"
* Open messenger.jar with winzip/winrar/file-roller
* locate content/messenger/mailWindowOverlay.xul
* Add the following line just above the first line starting with <?xul-overlay
    <?xul-overlay href="chrome://communicator/content/utilityOverlay.xul"?>
* Save mailWindowOverlay.xul back into the archive at the same location
* Restart thunderbird.

I've noticed this error on trunk too. A lot of other keys may delete messages (down arrow, ctrl+z, etc) so be careful.


Mark, this is the bug we were talking about shortly, it would be nice to find out if the above fix is worth a patch or if it should be solved differently.
Odd.
I had this problem using Thunderbird 2.0.0.16 and Lightning 0.8. I have just upgraded to Lightning 0.9 and the problem has been remedied. No other changes to Thunderbird or other add-ons.
The File, Edit and View menus are now displayed when opening an email in a new window, and CTRL-U, which used to delete the email, now correctly displays the message source.

Previously I had found that disabling Lightning removed the problem.
I have this same problem, I use the following add-ons

Ad-Block
British English Dictionary
Lightning
Lightning Nightly Updater
Minimize to tray
Provider for Google Calender
Web Mail
Web Mail - Hotmail

With all theses add-ons enabled I have the problem as shown above.  Disabling Provider for Google cures the problem but does mean I'm unable to use Google as my calender in Lightning
I'm confirming this issue based on the multiple reports.

Did someone tried to patch Thunderbird as described in Comment #17?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: tb-integration?
Summary: File, Edit and View menus hidden with some Lightning + other extensions combinations → Thunderbirds File, Edit and View menus are hidden with some Lightning + other extensions combinations
The last but one beta of lightning started causing the same problems and i had to disable lightning, the problem has stayed with the new beta.
With all the latest builds this problem seems to have stopped.
So, there are no problems using a recent Thunderbird 3 beta or nightly and Lightning 1.0pre?
Apart from the change of FTP folder, no problems.
(In reply to comment #24)
> Apart from the change of FTP folder, no problems.

FTP folder? Could you elaborate on this?
I use the Lightning Nightly Update extension and about two weeks ago it needed to be updated as according to the add-on author the location of the FTP folder had changed.  Should have made this clear in the original post.
Resolving as WORKSFORME (according to comment#22 and comment#24).

To everyone: Please, comment or reopen the bug report if you can (still) reproduce this issue in a recent Lightning 1.0pre build!
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: tb-integration?
Keywords: qawanted
Resolution: --- → WORKSFORME
Duplicate of this bug: 505466
Issue still exists in current Lightning 1.0pre + Shredder 3.0b4pre nightly builds according to Bug 505466.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
My builds of Lightning and Shredder are not displaying this problem.
I've discovered the bug is if I have Quicktext 0.9.10.0 and Lightning both installed at the same time. Using either individually is fine but using both at the same time causes the problem with the menu. However using older builds of Lightning with Quicktext didn't have this bug.
(http://extensions.hesslow.se/extension/4/Quicktext/)
Status: REOPENED → NEW
Duplicate of this bug: 532229
Did anybody tried the Thunderbird patch provided in Comment 17?
This effects all platforms and operating systems. This is not dependant on any other themes/extensions being installed. A clean setup with nothing more than lightning installed will produce same results.
OS: Windows XP → All
Hardware: x86 → All
(In reply to comment #33)
> Did anybody tried the Thunderbird patch provided in Comment 17?

A patch is indeed in need based on comment 17, it is confirmed to be working!!
I confirm that the bug is still present with Thunderbird 3.0 RC2 + Lightning 1.0b1pre (downloaded a few minutes ago). This seems to be a major bug to me -> requesting blocking.
Severity: normal → major
Flags: blocking-calendar1.0?
Version: unspecified → Trunk
Not had this problem at all, could it be as a result of certain extensions?
(In reply to comment #37)
> Not had this problem at all, could it be as a result of certain extensions?

Yes, Lightning 1.0b1pre + Enigmail 1.0. If Enigmail is disabled, the problem goes away.
Strange I have the exact same extensions and have no problems. Are you using the latest version of Thunderbird (Shredder)?  Could this bug already have been caught in one of the nightly's?
I have Tb 3.0 RC2, which is only 6 days old. :) Is that recent enough for you? ;)
When both extensions are active, I get the following error in the error console:

Erreur : document.getElementById("show-completed-checkbox") is null
Fichier Source : chrome://calendar/content/calendar-unifinder-todo.js
Ligne : 61

Else this error is not displayed.
Probably best to let the bods who do software look at this because I just use the programs rather then write them! :)
(In reply to comment #33)
> Did anybody tried the Thunderbird patch provided in Comment 17?

I tried the patch and it works like a charm.

Mozilla/5.0 (Windows; U; Windows NT 6.1; it; rv:1.9.1.5) Gecko/20091204 Lightning/1.0b1pre Thunderbird/3.0
Summary: Thunderbirds File, Edit and View menus are hidden with some Lightning + other extensions combinations → Thunderbirds File, Edit and View menus are hidden with some Lightning + other extensions combinations - Error: document.getElementById("show-completed-checkbox") is null Fichier Source : chrome://calendar/content/calendar-unifinder-todo.js Line : 61
If someone wants to have patch reviewed and pushed that is fine, I will leave that up to someone else for the time being.
Attachment #416612 - Attachment description: fix menus in 3.0 beta with calendar enabled with enigmail installed → fix menus in 3.0 with calendar enabled with enigmail installed
Attachment #416612 - Flags: review?(ssitter)
Comment on attachment 416612 [details] [diff] [review]
fix menus in 3.0 with calendar enabled with enigmail installed

Removing review request because a file from /mail is modified, and this needs review from a Thunderbird peer. In general, this bug should be moved to the Thunderbird product if there is evidence it is a bug in Thunderbird.
Attachment #416612 - Flags: review?(ssitter)
Comment on attachment 416612 [details] [diff] [review]
fix menus in 3.0 with calendar enabled with enigmail installed

Reviews for Thunderbird code need to be done by someone else, maybe Mark can
take over or assign to the appropriate reviewer.
Attachment #416612 - Flags: review?(bugzilla)
Comment on attachment 416612 [details] [diff] [review]
fix menus in 3.0 with calendar enabled with enigmail installed

I'm a bit busy, moving the review across to help this along.
Attachment #416612 - Flags: review?(bugzilla) → review?(philringnalda)
I have the final version of Thunderbird 3 installed on my Windows 7 box with Enigmail v1.0 installed.  If I install the latest Lightning 1.0 Beta Pre builds with the combination of Enigmail, I experience the bug.
Duplicate of this bug: 536138
Moving to Thunderbird land to make sure its not forgotten. This would make sense for 3.0.1.
Assignee: nobody → anarchy
Component: Lightning Only → Mail Window Front End
Flags: blocking-calendar1.0?
Product: Calendar → Thunderbird
QA Contact: lightning → front-end
Target Milestone: --- → Thunderbird 3
Version: Trunk → 3.0
blocking-thunderbird3.0: --- → ?
(In reply to comment #50)
> Moving to Thunderbird land to make sure its not forgotten. This would make
> sense for 3.0.1
As I stated in bug 536138, I see this happen with Lightning and QuickFolders extension with TB 3.0 and Lightning 1.0beta1 rc.

These two extensions worked together like a charm with TB 3.0 and Lightning nightlies before 1.0beta1 rc.
So out of curiosity, why did it stop working with 1.0beta1 rc? Due to Localization?
blocking-thunderbird3.0: ? → .1+
Comment on attachment 416612 [details] [diff] [review]
fix menus in 3.0 with calendar enabled with enigmail installed

This patch makes no sense. Both messenger.xul and messageWindow.xul already import utilityOverlay.xul.

Perhaps you could try in messenger.xul moving utilityOverlay.xul after mailWindowOverlay.xul e.g.
<?xul-overlay href="chrome://messenger/content/msgHdrViewOverlay.xul"?>
<?xul-overlay href="chrome://messenger/content/mailWindowOverlay.xul"?>
<?xul-overlay href="chrome://communicator/content/utilityOverlay.xul"?>

Has anyone used the DOM inspector to investigate what is happening to the messenger DOM when the bug manifests itself?
I haven't checked anything really but when I applied the patch everything worked fine afterwards. JFYI
This line looks decidedly dodgy:
<http://mxr.mozilla.org/comm-central/source/calendar/base/content/calendar-unifinder-todo.xul#54>
Caused by Bug 455733 some where between v6 of the patch and the version from the reviewer.
Last time I was supposed to look at this voodoo patch, for bug 408480, it didn't matter that I couldn't reproduce the problem since the badness that was being wallpapered over was obvious. This time it's not obvious what's being wallpapered over. Can someone please come up with steps to reproduce that start with "create a new profile" rather than with "come over to my house"? Just installing Enigmail+Lighting+Buttons! clearly is not it.
Comment on attachment 416612 [details] [diff] [review]
fix menus in 3.0 with calendar enabled with enigmail installed

Oh, look, in bug 408480 comment 5 dmose made the mistake of admitting he'd reproduced it at some time, earning himself the Hot Potato award.
Attachment #416612 - Flags: review?(philringnalda) → review?(dmose)
Here are the steps that reproducibly lead to the described situation for Thunderbird 3.0 with German localization (in my case).

1. Create a new profile and start TB with this profile (German locale!)
2. Search and install add-on "quickfolders" via the add-on manager
3. Restart TB
4. Install a Lightning XPI which is localized, e.g. from ftp://ftp.mozilla.org/pub/calendar/lightning/releases/1.0b1rc1/linux-i686/lightning.xpi
5. Restart TB

Now the described menu entries are not correctly shown anymore.

6. Deactivate either quickfolders or lightning add-on

Now the described menu entries are correctly shown again.

For me it is reproducible, not sure whether it depends on the localization, but with not-localized builds of lightning I have never seen this issue.
Whiteboard: [needs review dmose]
Also noticing this bug with TB3 + Lightning 1.0b1 + Enigmail 1.0.0 here.
Comment on attachment 416612 [details] [diff] [review]
fix menus in 3.0 with calendar enabled with enigmail installed

I'm having a hard time accepting this patch in good conscience, given that we don't know how it fixes the problem, it could conceivably have other side effects, and it adds another instance use of utilityOverlay.js when we're trying to kill that (bug 359748).

All that said, it doesn't seem reasonable to leave our users languishing with a bug this severe when we've got what appears to be at least something that will staunch the bleeding.

So I'm going to mark this r+ conditional on adding a comment to the XUL which explains what we're doing here.  I'll add that comment and land it, since we need to get this in for 3.0.1 code freeze today.

Jory, would you be willing to experiment more here with DOM Inspector to try and diagnose exactly what's going on when utilityOverlay is added and why that fixes the problem in order to come up with a cleaner fix?
Attachment #416612 - Flags: review?(dmose) → review+
Dan I will be more then willing to dig threw it with dom inspector. I will work on it later this weekend, if that is fine with you all. I agree this is a bandage but needed at the moment until true issue is found and solution to resolve is in place, then yes back out the change at same time.
blocking-thunderbird3.0: .1+ → needed
Jory, thanks so much for your willingness to continue working on this.
Here's the patch updated with a comment.  An automated test is going to need to wait for the non-band-aid fix.
Attachment #416612 - Attachment is obsolete: true
Attachment #420922 - Flags: review+
Whiteboard: [needs review dmose] → [needs landing dmose]
Whiteboard: [needs landing dmose] → [landed on trunk; needs approval, branch landing]
Attachment #420922 - Attachment description: band-aid patch, v2 → band-aid patch, v2 (checked in on trunk)
Attachment #420922 - Flags: approval-thunderbird3.0.1?
Flags: in-testsuite?
Attachment #420922 - Flags: approval-thunderbird3.0.1? → approval-thunderbird3.0.1+
band-aid patch v2 landed on branch:
<http://hg.mozilla.org/releases/comm-1.9.1/rev/b8cac30252da>
Whiteboard: [landed on trunk; needs approval, branch landing]
I just read the patch. It's not Mac only. Linux is affected as well FWIW.
Why is this bug left open?
In addition to the bug as described, I also am seeing the (unlabeled) File, Edit, and (labeled) Tools menus display with scroll icons (small triangles) at the top and bottom of the menu content.  The scroll amount appears to be just the size of the added scroll icon rows - so I suspect there's just a mis-computation regarding whether to show the scrollers.

Did other folks see this scroll behavior with this bug, and does the patch resolve it?  If not, I'll dig a little further and possibly open a separate bug as needed.  Thanks.
Ed, the patch here just wallpapers over the problem. The scroll buttons are probably just another manifestation of the underlying bug.
My 5 cents. This bug appears, when Locale Switcher extenstion installed.
Mozilla/5.0 (Windows; U; Windows NT 6.0; ru; rv:1.9.1.5) Gecko/20091204 Lightning/1.0b1 Thunderbird/3.0
Blocks: 539692
Given that we've applied a fix for this in Thunderbird 3.0.1, I'm marking this as fixed. Bug 539692 will take over the investigation of a full fix - discussed in comment 59 through comment 62.
Status: NEW → RESOLVED
Closed: 11 years ago10 years ago
Resolution: --- → FIXED
Target Milestone: Thunderbird 3 → Thunderbird 3.1a1
For completeness, the errant scrolling behavior I noted in comment 67 appears to have been resolved through this patch.  I no longer see the problem in TB 3.0.1.
Duplicate of this bug: 532618
You need to log in before you can comment on or make changes to this bug.