533865 - Doing a quick search in a cross-folder saved search clears cached results

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[David :Bienvenu]

If you do a quick search in a  cross-folder saved search (e.g., a smart mailbox), we remove from the cached results the messages that don't match the quick search. This slows down both the quick search, and returning to the saved search. Patch upcoming.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

This patch makes cross-folder saved searches compare the base search criteria for the saved search against the current search session's search criteria. If they are different, then we're doing a quick search, and we should not start with the old saved search results, nor should we update the cached results. This is a big performance win for quick search in saved searches, but it doesn't change the correctness of the saved searches, which are already covered by unit tests...

This is such a big win that I'd like to think about putting this in a 3.0x release.

Comment 3

[Wayne Mery (:wsmwk)]

nice!

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 416822 [details] [diff] [review]
proposed fix


>-    { "Message Filter Service", NS_MSGFILTERSERVICE_CID,
>-      NS_MSGFILTERSERVICE_CONTRACTID,
>-      nsMsgFilterServiceConstructor,

Can you do the same in mailnews/build/nsMailModule.cpp please - it has the same problem.

>+    nsCAutoString  stream;

nit: I know this is just copy/paste, but can you make that just one space please.

Comment 7

[David :Bienvenu]

Attachment: fix addressing comments plus a bug fix

this is what I'll check in...I found an issue with the code that converts search terms to strings; it was bailing after the ALL term, which doesn't work for the quick search terms in a smart folder, since quick search includes the all term...

Comment 8

[Mark Banner (:standard8)]

I just backed this out due to unit test failures in test_viewWrapper_virtualFolder.js (which exists under mail/!):

http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1262848429.1262850880.14500.gz#err0

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 420426 [details] [diff] [review]
fix addressing comments plus a bug fix

Needs some extra test fixes at least ;-)

Comment 10

[David :Bienvenu]

Attachment: fix regression found by test...

We were skipping the registering of folder listeners when doing quick search in saved searches...this fixes that, and the well-hidden tests pass.

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 420557 [details] [diff] [review]
fix regression found by test...

This patch is exactly the same as the last one :-(

Comment 12

[David :Bienvenu]

Attachment: correct patch

darnit, this should be the right file...

Comment 13

[David :Bienvenu]

fixed on trunk and branch.

Comment 14

[Ludovic Hirlimann [:Usul]]

Difficult to verify - but the search was very speedy on a very large smart folder. and none of the duped bugs symptoms where observed. Tested on XP.