Closed
Bug 534424
Opened 16 years ago
Closed 16 years ago
Fix the element getter for the FakeTreeBoxObject
Categories
(Thunderbird :: Folder and Message Lists, defect)
Thunderbird
Folder and Message Lists
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.1a1
People
(Reporter: rain1, Assigned: rain1)
References
Details
Attachments
(1 file)
948 bytes,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
The element getter seems to have been inadvertently named domElement. This seems to have caused the failures in bug 533170 and bug 531505.
nsIBoxObject has <http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/public/nsIBoxObject.idl#46>, and an mxr search for domElement in an idl yielded no results.
Attachment #417274 -
Flags: review?(bienvenu)
Comment 1•16 years ago
|
||
Sounds like maybe this could also fix bug 521123
Comment 2•16 years ago
|
||
Comment on attachment 417274 [details] [diff] [review]
patch
thx, Sid, sorry about that...
Attachment #417274 -
Flags: review?(bienvenu) → review+
Assignee | ||
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
Assignee | ||
Comment 4•16 years ago
|
||
Backed out because several other Mozmill tests started failing on Windows: http://hg.mozilla.org/comm-central/rev/bf4166703b8f
I don't know what my change has to do with the test failures, but I'm looking at it right now.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•16 years ago
|
||
Bug 534424 filed and a fix posted wrt the failures.
Assignee | ||
Comment 6•16 years ago
|
||
^ ugh, meant bug 534480 above.
Assignee | ||
Comment 7•16 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•16 years ago
|
||
I'm going to mark this as in-testsuite+ because trunk Mozmill tests are much happier than before (just one failure now).
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•