Closed
Bug 533170
Opened 15 years ago
Closed 15 years ago
No title for message tabs opened from a single folder saved search
Categories
(Thunderbird :: Toolbars and Tabs, defect)
Thunderbird
Toolbars and Tabs
Tracking
(thunderbird3.0 .1-fixed)
VERIFIED
FIXED
Thunderbird 3.1a1
| Tracking | Status | |
|---|---|---|
| thunderbird3.0 | --- | .1-fixed |
People
(Reporter: rain1, Assigned: rain1)
References
Details
Attachments
(2 files, 1 obsolete file)
|
10.02 KB,
patch
|
Bienvenu
:
review+
standard8
:
approval-thunderbird3.0.1+
|
Details | Diff | Splinter Review |
|
6.79 KB,
text/plain
|
Details |
I found this while investigating bug 531505.
I'm not sure if this should make a point release. The fix seems straightforward (this.underlyingFolder is the virtual folder, not the actual one) and has tests -- David, does this look correct?
|
Assignee | |
Updated•15 years ago
|
Attachment #416335 -
Flags: review?(bienvenu)
|
||
Updated•15 years ago
|
status-thunderbird3.0:
--- → ?
|
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #416335 -
Attachment is obsolete: true
Attachment #416896 -
Flags: review?(bienvenu)
Attachment #416335 -
Flags: review?(bienvenu)
|
||
Comment 2•15 years ago
|
||
I tried running this test w/ the patch from the subsequent bug applied. It failed a few times. I'll try w/o the other patch applied next.
|
|
||
Comment 3•15 years ago
|
||
It fails the same way without the patch for bug 531505 applied. This is on comm-central and moz-central trunk. Any suggestions for things to try?
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 416896 [details] [diff] [review]
a couple of test names fixed
minusing based on test failures...
Attachment #416896 -
Flags: review?(bienvenu) → review-
|
|
Assignee | |
Comment 5•15 years ago
|
||
Comment on attachment 416896 [details] [diff] [review]
a couple of test names fixed
Could you please recheck with the patch to bug 534424 applied?
Attachment #416896 -
Flags: review- → review?(bienvenu)
|
|
||
Comment 6•15 years ago
|
||
Comment on attachment 416896 [details] [diff] [review]
a couple of test names fixed
this works now, modulo the tree row count assertions, which are a core issue, I believe.
Attachment #416896 -
Flags: review?(bienvenu) → review+
|
|
Assignee | |
Comment 8•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
|
|
Assignee | |
Updated•15 years ago
|
Attachment #416896 -
Flags: approval-thunderbird3.0.1?
|
|
Assignee | |
Updated•15 years ago
|
Flags: in-testsuite+
|
|
||
Comment 9•15 years ago
|
||
Sid, to get this into 3.0.1, do we need any of the other mozmill test fixes?
|
|
Assignee | |
Comment 10•15 years ago
|
||
No, but I'd like bug 534480 to land as a correctness fix.
|
||
Comment 11•15 years ago
|
||
Tested with an hourly Shredder/3.1a1pre
Confirming that this fixes bug 521123 and just to be clear, that bug was about the tab content not being displayed, as well as the tab title.
|
|
||
Updated•15 years ago
|
Attachment #416896 -
Flags: approval-thunderbird3.0.1? → approval-thunderbird3.0.1+
|
|
||
Comment 13•15 years ago
|
||
Comment on attachment 416896 [details] [diff] [review]
a couple of test names fixed
a=Standard8
|
|
Assignee | |
Comment 14•15 years ago
|
||
Pushed to branch: http://hg.mozilla.org/releases/comm-1.9.1/rev/609bc79176fb
|
||
Comment 15•15 years ago
|
||
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.7) Gecko/20100107 Shredder/3.0.1pre
Status: RESOLVED → VERIFIED
Keywords: verified-thunderbird3.0
You need to log in
before you can comment on or make changes to this bug.
Description
•