534750 - make shift-reload work in fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

Sometimes you really have to leave your cache behind.  We should make Shift-Reload work so that you can do this (this is how it works in desktop firefox).

While we're at it, Ctrl-R doesn't work for reload in Fennec at the moment, but should.  In that case, Ctrl-Shift-R would also do the fuller refresh.

Comment 1

[Michael Wu [:mwu]]

Attachment: Add more refresh keys

This takes a simple and dumb approach to adding ctrl-r, ctrl-shift-r, and shift-F5. Not sure what people prefer here. Firefox does fancier things to handle shift when shift reloading.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 419062 [details] [diff] [review]
Add more refresh keys

>diff -r 34179ce6dd5c chrome/content/browser-ui.js

>+      case "cmd_forceReload":
>+      {
>+        const reloadFlags = Ci.nsIWebNavigation.LOAD_FLAGS_BYPASS_PROXY |
>+                            Ci.nsIWebNavigation.LOAD_FLAGS_BYPASS_CACHE;
>+        browser.reloadWithFlags(reloadFlags);
>+        break;
>+      }

The Firefox equivalent attempts to use nsSHistory::Reload if it can, and despite the comment I couldn't figure out why. I ended up at bug 68847 comment 16, which isn't particularly helpful and might just be irrelevant now, so I think we should just go with this for now and can re-investigate if something ever comes up (seems unlikely)!

>diff -r 34179ce6dd5c chrome/content/browser.xul

>+    <command id="cmd_forceReload" label="&reload.label;" oncommand="CommandUpdater.doCommand(this.id);"/>

Let's not add a label here. It's cruft left over from when we had a key editor - wouldn't mind if you cleaned up the others too, but that's probably best left to another bug since it also involves removing strings.

>+    <key id="key_reload2" key="r" modifiers="control" command="cmd_reload"/>
>+    <key id="key_forceReload2" key="r" modifiers="control,shift" command="cmd_forceReload"/>

These want to use "accel", I think (means Cmd on Mac, Ctrl otherwise, not that it matters that much).

r=me with those changes.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

mfinkle filed bug 538676

Comment 4

[Michael Wu [:mwu]]

Attachment: Add more refresh keys, v2

Thanks gavin - all review comments addressed.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/638103705788

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.2pre) Gecko/20100217 Namoroka/3.6.2pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a2pre) Gecko/20100217 Namoroka/3.7a2pre Fennec/1.1a2pre

Comment 7

[Aakash Desai [:aakashd]]

litmus testcase https://litmus.mozilla.org/show_test.cgi?id=11803 created to regression test this bug.