Closed Bug 543946 Opened 14 years ago Closed 14 years ago

Tidy up content-tabs and cookies mozmill tests now that bug 508999/bug 511240 have landed

Categories

(Thunderbird :: Testing Infrastructure, defect)

Product:
Thunderbird
Component:
Testing Infrastructure
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird3.0 .2-fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.1b1
Tracking Flags:
Tracking Status
thunderbird3.0 --- .2-fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

The fix
2.45 KB, patch
Bienvenu
: review+
standard8
: approval-thunderbird3.0.2+
Details | Diff | Splinter Review
Attached patch The fix — — Splinter Review 
Bug 508999 and Bug 511240 landed a while ago. I realised yesterday when looking at some older tests I hadn't done the mozmill clean up that I should have done.

The changes here use waitForEval rather than just plain sleep. So we only will wait as long as we need to (the content-policy tests already do this).

I think this will resolve a couple of random oranges I've seen on these tests as well.
Attachment #424955 - Flags: review?(bienvenu)
Attachment #424955 - Flags: review?(bienvenu) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/d088cb13bc1a
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b1
Attachment #424955 - Flags: approval-thunderbird3.0.2?
Comment on attachment 424955 [details] [diff] [review]
The fix

Test only tidy up and applies to 1.9.1, we should take this.
Attachment #424955 - Flags: approval-thunderbird3.0.2? → approval-thunderbird3.0.2+
Verifying as fixed for 3.0.2 based on the fact that these are test-only patches and the last 5 runs from MozMill/unit tests have been green with no failures relating to these patches.
Keywords: verified-thunderbird3.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: