Tidy up content-tabs and cookies mozmill tests now that bug 508999/bug 511240 have landed

RESOLVED FIXED in Thunderbird 3.1b1

Status

Thunderbird
Testing Infrastructure
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 3.1b1
Bug Flags:
in-testsuite +

Thunderbird Tracking Flags

(thunderbird3.0 .2-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 424955 [details] [diff] [review]
The fix

Bug 508999 and Bug 511240 landed a while ago. I realised yesterday when looking at some older tests I hadn't done the mozmill clean up that I should have done.

The changes here use waitForEval rather than just plain sleep. So we only will wait as long as we need to (the content-policy tests already do this).

I think this will resolve a couple of random oranges I've seen on these tests as well.
Attachment #424955 - Flags: review?(bienvenu)

Updated

8 years ago
Attachment #424955 - Flags: review?(bienvenu) → review+
(Assignee)

Comment 1

8 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/d088cb13bc1a
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b1
(Assignee)

Updated

8 years ago
Attachment #424955 - Flags: approval-thunderbird3.0.2?
(Assignee)

Comment 2

8 years ago
Comment on attachment 424955 [details] [diff] [review]
The fix

Test only tidy up and applies to 1.9.1, we should take this.
Attachment #424955 - Flags: approval-thunderbird3.0.2? → approval-thunderbird3.0.2+
(Assignee)

Comment 3

8 years ago
Checked in to branch: http://hg.mozilla.org/releases/comm-1.9.1/rev/77502bac40b9
status-thunderbird3.0: --- → .2-fixed
(Assignee)

Comment 4

8 years ago
Verifying as fixed for 3.0.2 based on the fact that these are test-only patches and the last 5 runs from MozMill/unit tests have been green with no failures relating to these patches.
Keywords: verified-thunderbird3.0
You need to log in before you can comment on or make changes to this bug.