548527 - Category recommended results are showing main recommended addons only, instead of category recommended addons only

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[yotam]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6 GTB6 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6 GTB6 (.NET CLR 3.5.30729)

In all categories, in the section at the top for category recommended addons, instead of showing category recommended addons, main recommended addons are showing. For example in the Langauge category https://addons.mozilla.org/en-US/firefox/browse/type:1/cat:37 IMTranslator is showing only. Instead six addons should be showing (from the category recommended list)

Reproducible: Always

Steps to Reproduce:
1. Open a category page, for example language category: https://addons.mozilla.org/en-US/firefox/browse/type:1/cat:37
2. Look at the top section
3. You will see main recommended addons instead of category recommended addons
Actual Results:  
See that the main recommended addons are showing instead of the category recommended addons

Expected Results:  
Show category recommended addons in categories top section

Comment 1

[Justin Scott [:fligtar]]

We fixed a regression with another regression. And it looks like the main recommended add-ons page is only showing half of the add-ons that are actually actively recommended.

What is going on? Did anyone review the patch in bug 544881?

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

We're serving featured/recommended via sphinx.  But I don't beleive we take into account category/featured recommended.

As for the main recommended page - what's missing?

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Attachment: v1

Indexing category_feature...

Comment 4

[Justin Scott [:fligtar]]

(In reply to comment #2)
> We're serving featured/recommended via sphinx.  But I don't beleive we take
> into account category/featured recommended.

Oh... did that land in 5.6? what was the bug number?

> As for the main recommended page - what's missing?

I'll file a separate bug.

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

(In reply to comment #4)
> (In reply to comment #2)
> > We're serving featured/recommended via sphinx.  But I don't beleive we take
> > into account category/featured recommended.
> 
> Oh... did that land in 5.6? what was the bug number?

https://bugzilla.mozilla.org/show_bug.cgi?id=538825

Yes, it was in 5.6

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

r63492

Comment 7

[krupa raj[:krupa]]

Attachment: screenshot of imTranslator in Download Management

I see ImTranslator in Download Management  landing page when imTranslator is not recommended in that category.

See screenshot.Reopening for clarification.

Comment 8

[krupa raj[:krupa]]

NOTE:I have noted behavior for both remora and zamboni as /themes is now being QAed.

Make a note of the themes nominated as featured for categories in the admin panel

1.Go to https://preview.addons.mozilla.org/en-US/thunderbird/browse/type:2/cat:60?sort=popular&show=20
2.Notice that "Silvermel","Walnut for Thunderbird" and "Aero Thunderbird" are recommended under the category Miscellaneous

expected behavior:
Only "Aero thunderbird" is recommended for the category -Miscellaneous

actual behavior for [remora]:
-Silvermel which is nominated as a theme for Firefox(under Modern category) is also listed for Thunderbird
-"Walnut for Thunderbird" which is nominated for category-"Nature" is also listed as recommended for category-"Miscellaneous"

actual behavior for [zamboni]:
-"Walnut for Thunderbird" which is nominated for category-"Nature" is also listed as recommended for category-"Miscellaneous"

reopening

Comment 9

[krupa raj[:krupa]]

Attachment: recommended themes for zamboni

Comment 10

[krupa raj[:krupa]]

verified.Filed bug 551044 for comment 8

Comment 11

[krupa raj[:krupa]]

in-litmus: https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=11567

Comment 12

[yotam]

When will this be fixed on production? Is there a date for the next push?

Comment 13

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

(In reply to comment #12)
> When will this be fixed on production? Is there a date for the next push?

The dates for our pushes are always on irc.mozilla.org/#amo in the topic:

We'll push tomorrow the 23rd.