Closed
Bug 552754
Opened 15 years ago
Closed 15 years ago
Fix browser_pluginnotification.js
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a5
People
(Reporter: mossop, Assigned: Unfocused)
References
()
Details
(Keywords: regression, Whiteboard: [rewrite])
Attachments
(1 file, 1 obsolete file)
|
9.54 KB,
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Updated•15 years ago
|
Status: NEW → ASSIGNED
|
Reporter | |
Comment 1•15 years ago
|
||
Blair, this is yours I think. Clicking on disabled plugins is meant to open the add-ons manager but of course the code that does that and this test will need to be changed slightly.
|
|
||
Updated•15 years ago
|
Status: NEW → ASSIGNED
|
|
||
Updated•15 years ago
|
Keywords: regression
|
Assignee | |
Comment 2•15 years ago
|
||
|
|
Assignee | |
Comment 3•15 years ago
|
||
Attachment #440146 -
Flags: review?(dtownsend)
|
|
Assignee | |
Updated•15 years ago
|
Attachment #440146 -
Flags: review?(dtownsend) → review?(sdwilsh)
|
||
Comment 4•15 years ago
|
||
Can you attach a patch with, say, 20 lines of context so I can see more code around what you are changing please?
|
|
Assignee | |
Comment 5•15 years ago
|
||
Attachment #440146 -
Attachment is obsolete: true
Attachment #441631 -
Flags: review?(sdwilsh)
Attachment #440146 -
Flags: review?(sdwilsh)
|
|
||
Updated•15 years ago
|
Attachment #441631 -
Flags: review?(sdwilsh) → review+
|
|
||
Comment 6•15 years ago
|
||
Comment on attachment 441631 [details] [diff] [review]
Patch v1 (more context)
r=sdwilsh
|
|
Reporter | |
Comment 7•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
|
|
||
Comment 8•15 years ago
|
||
Dave, what has to be manually tested here? Also does it need more work for the automated test or can we flag in-testsuite+?
|
|
Reporter | |
Comment 9•15 years ago
|
||
We should be able to just automate this.
Flags: in-litmus? → in-litmus-
|
||
Comment 10•15 years ago
|
||
verified fixed
Status: RESOLVED → VERIFIED
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•