Closed Bug 552754 Opened 14 years ago Closed 14 years ago

Fix browser_pluginnotification.js

Categories

(Toolkit :: Add-ons Manager, defect, P1)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.3a5

People

(Reporter: mossop, Assigned: Unfocused)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [rewrite])

Attachments

(1 file, 1 obsolete file)

Patch v1 (more context)
9.54 KB, patch
sdwilsh
: review+
Details | Diff | Splinter Review 
      No description provided.
Status: NEW → ASSIGNED
Blair, this is yours I think. Clicking on disabled plugins is meant to open the add-ons manager but of course the code that does that and this test will need to be changed slightly.
Assignee: dtownsend → bmcbride
Blocks: 550048
No longer blocks: 461973
Status: ASSIGNED → NEW
Flags: in-testsuite?
Flags: in-litmus?
Depends on: 554234
http://hg.mozilla.org/projects/addonsmgr/rev/ab92e7f5f657
Depends on: 560449
No longer depends on: 554234
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr]
Attached patch Patch v1 (obsolete) — — Splinter Review 

        Attachment #440146 -
        Flags: review?(dtownsend)

        Attachment #440146 -
        Flags: review?(dtownsend) → review?(sdwilsh)

    
    

    
  
Can you attach a patch with, say, 20 lines of context so I can see more code around what you are changing please?

    
    

    
  


  

        Attachment #440146 -
        Attachment is obsolete: true

        Attachment #441631 -
        Flags: review?(sdwilsh)

        Attachment #440146 -
        Flags: review?(sdwilsh)

        Attachment #441631 -
        Flags: review?(sdwilsh) → review+

    
    

    
  
Comment on attachment 441631 [details] [diff] [review]
Patch v1 (more context)

r=sdwilsh

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/e60dfa400464
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5

    
    

    
  
Dave, what has to be manually tested here? Also does it need more work for the automated test or can we flag in-testsuite+?

    
    

    
  
We should be able to just automate this.
Flags: in-litmus? → in-litmus-

    
    

    
  
verified fixed
Status: RESOLVED → VERIFIED
Flags: in-testsuite? → in-testsuite+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: