560449 - Add support for opening the addons manager at a specific pane

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

The old addons manager could be opened with a specific pane showing. Need to support this in the new UI too.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Would that imply manual tests or can we cover all of that with automation? I wonder under which circumstances users could see that.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

The automated tests seem to cover this for the old UI - should just be a matter of adapting them (er, and adding more).

Comment 3

[Brian King [:kinger]]

Need help with this?

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #3)
> Need help with this?

Yea, that'd be great! Feel free to grab this and any other bug that blocks bug 550048.

I haven't come up with any concrete plans on the best way to tackle this.

Comment 5

[Dave Townsend [:mossop]]

Passing the addons:// url as the argument seems like the best way to do this.

Comment 6

[Brian King [:kinger]]

(In reply to comment #4)
> Yea, that'd be great! Feel free to grab this and any other bug that blocks bug
> 550048.
> 
> I haven't come up with any concrete plans on the best way to tackle this.

/me goes to build http://hg.mozilla.org/projects/addonsmgr/

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The current behavior is also visible and annoying when going forward and backward in the history. Each time you open the add-ons manager we open the extension pane at the moment.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

IMO we should block on this.

Comment 10

[Dave Townsend [:mossop]]

Have a patch in progress for this.

Comment 11

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This turns on persistence for the initial view (though it doesn't work when viewing as about:addons right now) and adds a global method to load a new view. The main browser code now waits for the tab to complete loading and then calls it to select a specific view if necessary. Made the test for the plugin case work.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 451323 [details] [diff] [review]
patch rev 1

>diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js

>+ * @param A callback to call when the tab is open, the tab will be passed as
>+ *        an argument

looks like it's actually "the tab's browser", right?

Comment 13

[Dave Townsend [:mossop]]

Landed and tested: http://hg.mozilla.org/mozilla-central/rev/ac6d4d6dfea1

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
rv:1.9.3a6pre) Gecko/20100616 Minefield/3.7a6pre

Works for the plugin pane case, but we show all the add-ons and not only the ones with the given type. See bug 572653.