557358 - JM: getprop PIC for getters

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Mandelin [:dmandelin]]

Extend the PIC to handle properties with getters.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is being a pretty serious performance drag on the DOM.  Chris, would you be willing to look at this?

Comment 2

[Brian Hackett [Laid off!]]

Attachment: WIP

WIP.  Handles property ops on GETPROP, not yet GETELEM (should be able to handle the monomorphic case there), and can't yet rejoin from recompilation triggered by the op.

function foo(f) {
  for (var i = 0; i < 5000000; i++)
    f.caller;
}
foo(foo);

              Before  After
js -m -j -p:  415     188
js -m -n:     630     188

Comment 3

[Brian Hackett [Laid off!]]

Attachment: patch

Handles GETPROP and CALLPROP, not GETELEM.  GETELEM is structured somewhat differently and bug 683631 did not identify hot GETELEM on DOM properties with getter hooks.

Comment 4

[Brian Hackett [Laid off!]]

http://hg.mozilla.org/projects/jaegermonkey/rev/c2726640029f

Comment 5

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/mozilla-central/rev/c02868b913d5