Slow property access on dromaeo's "jQuery -attr(class) x 100" benchmark

NEW
Unassigned

Status

()

defect
9 years ago
Last year

People

(Reporter: bzbarsky, Unassigned)

Tracking

(Blocks 3 bugs, {perf})

Trunk
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(platform-rel +)

Details

(Whiteboard: [platform-rel-jQuery][qf:p3])

This is in the "DOM Attributes (jQuery)" section in dromaeo.  Nearly 20% of the time is dealing with resolves (due to JM not PICing DOM stuff with getters?) and in particular calling XPC_WN_ModsAllowed_ProtoResolve is about 10% of the total time.  Peter, is that used for just normal DOM objects too?
Blocks: 614164
Depends on: 557358

Comment 1

8 years ago
Something to keep in mind is Dromaeo is using jQuery v1.2.3.
http://docs.jquery.com/Release:jQuery_1.2.3 from February 2008.
Yes, but it's just using the DOM.  A newer jquery may use the DOM slightly differently, but it may not....

Or do you have concrete evidence the attr() has been significantly changed since in a way that makes this bug somehow irrelevant to our DOM performance?

Comment 3

8 years ago
DOM performance is important regardless of JS lib or lib version so please keep digging/investigating for perf improvements. 
jQuery did do an overhaul of their attribute/property related methods in v1.6
http://blog.jquery.com/2011/05/03/jquery-16-released/
Assignee: general → nobody
Whiteboard: [platform-rel-jQuery]
platform-rel: --- → ?
platform-rel: ? → +
Rank: 45
Whiteboard: [platform-rel-jQuery] → [platform-rel-jQuery][qf]

Comment 4

2 years ago
Marking [qf:investigate:p1] so that someone would first investigate whether this is still an issue.
Whiteboard: [platform-rel-jQuery][qf] → [platform-rel-jQuery][qf:investigate:p1]
Whiteboard: [platform-rel-jQuery][qf:investigate:p1] → [platform-rel-jQuery][qf:p3]
Keywords: perf
You need to log in before you can comment on or make changes to this bug.